Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,19 @@ All notable changes to this project will be documented in this file. Dates are d

Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).

#### [1.4.2](https://github.com/rdkcentral/tr69hostif/compare/1.4.1...1.4.2)

- RDK-59998 : Remove getprofiledata dml from hostif [`#455`](https://github.com/rdkcentral/tr69hostif/pull/455)
- Update workflow for the partner Defaults usage [`#451`](https://github.com/rdkcentral/tr69hostif/pull/451)
- RDKEMW-15141 Update the Missing Coverity Reports Fixes [`#441`](https://github.com/rdkcentral/tr69hostif/pull/441)
- Merge tag '1.4.1' into develop [`7005cc7`](https://github.com/rdkcentral/tr69hostif/commit/7005cc788d3a55b18928a7228bffb42a31f61211)

#### [1.4.1](https://github.com/rdkcentral/tr69hostif/compare/1.4.0...1.4.1)

> 8 April 2026

- RDKEMW-15041: Add RFC Handlers for meminsight RFC [`#426`](https://github.com/rdkcentral/tr69hostif/pull/426)
- tr69hostif 1.4.1 release changelog updates [`16fb130`](https://github.com/rdkcentral/tr69hostif/commit/16fb1306008950273f9cfcf65be958641a0e008a)
- Merge tag '1.4.0' into develop [`fe37481`](https://github.com/rdkcentral/tr69hostif/commit/fe374814ab61d33d3dcd23581eef526c9f467a3d)

#### [1.4.0](https://github.com/rdkcentral/tr69hostif/compare/1.3.9...1.4.0)
Expand Down
5 changes: 0 additions & 5 deletions src/hostif/handlers/src/hostIf_DeviceClient_ReqHandler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -494,11 +494,6 @@ int DeviceClientReqHandler::handleGetMsg(HOSTIF_MsgData_t *stMsgData)
{
ret = pIface->get_Device_DeviceInfo_X_RDKCENTRAL_COM_BootStatus(stMsgData);
}

else if(strcasecmp(stMsgData->paramName,"Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.RDKRemoteDebugger.getProfileData") == 0)
{
ret = pIface->get_Device_DeviceInfo_X_RDKCENTRAL_COM_RDKRemoteDebuggergetProfileData(stMsgData);
}
else if (strcasecmp(stMsgData->paramName,"Device.DeviceInfo.X_RDKCENTRAL-COM_PreferredGatewayType") == 0)
{
ret = pIface->get_Device_DeviceInfo_X_RDKCENTRAL_COM_PreferredGatewayType(stMsgData);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3607,11 +3607,6 @@
<default type="factory" value="false"/>
</syntax>
</parameter>
<parameter base="getProfileData" access="readOnly" notification="0" maxNotification="2" >
<syntax>
<string/>
</syntax>
</parameter>
<parameter base="IssueType" access="readWrite" notification="0" maxNotification="2" >
<syntax>
<string/>
Expand Down
121 changes: 0 additions & 121 deletions src/hostif/profiles/DeviceInfo/Device_DeviceInfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4318,127 +4318,6 @@ int hostIf_DeviceInfo::set_Device_DeviceInfo_X_RDKCENTRAL_COM_RDKRemoteDebuggerI
return retVal;
}

int hostIf_DeviceInfo::get_Device_DeviceInfo_X_RDKCENTRAL_COM_RDKRemoteDebuggergetProfileData(HOSTIF_MsgData_t *stMsgData)
{
stMsgData->paramtype = hostIf_StringType;
int retStatus = NOK;
const char *filename = "/etc/rrd/remote_debugger.json";
FILE *fp = nullptr;
char *fileBuf = nullptr;
long fileSz = 0;
size_t bytesRead = 0;
cJSON *root = nullptr;
cJSON *filtered = nullptr;
char *outStr = nullptr;
size_t outLen = 0;
RDK_LOG(RDK_LOG_TRACE1, LOG_TR69HOSTIF, "[%s] Entering …\n", __FUNCTION__);
fp = fopen(filename, "rb");
if (!fp)
{
RDK_LOG(RDK_LOG_ERROR, LOG_TR69HOSTIF, "[%s] Cannot open %s\n", __FUNCTION__, filename);
RDK_LOG(RDK_LOG_ERROR, LOG_TR69HOSTIF, "[%s] Leaving with NOK\n", __FUNCTION__);
return retStatus;
}
if (fseek(fp, 0L, SEEK_END) != 0)
{
RDK_LOG(RDK_LOG_ERROR, LOG_TR69HOSTIF, "[%s] fseek failed\n", __FUNCTION__);
fclose(fp);
RDK_LOG(RDK_LOG_ERROR, LOG_TR69HOSTIF, "[%s] Leaving with NOK\n", __FUNCTION__);
return retStatus;
}
fileSz = ftell(fp);
rewind(fp);
if (fileSz < 0)
{
RDK_LOG(RDK_LOG_ERROR, LOG_TR69HOSTIF, "[%s] fileSz is negative, Returning....\n", __FUNCTION__);
fclose(fp);
RDK_LOG(RDK_LOG_ERROR, LOG_TR69HOSTIF, "[%s] Leaving with NOK\n", __FUNCTION__);
return retStatus;
}
fileBuf = (char*)malloc((size_t)fileSz + 1);
if (!fileBuf)
{
RDK_LOG(RDK_LOG_ERROR, LOG_TR69HOSTIF, "[%s] malloc(%ld) failed\n", __FUNCTION__, fileSz + 1);
fclose(fp);
RDK_LOG(RDK_LOG_ERROR, LOG_TR69HOSTIF, "[%s] Leaving with NOK\n", __FUNCTION__);
return retStatus;
}
bytesRead = fread(fileBuf, 1U, (size_t)fileSz, fp);
fileBuf[bytesRead] = '\0';
fclose(fp); fp = nullptr;
root = cJSON_Parse(fileBuf);
if (!root)
{
RDK_LOG(RDK_LOG_ERROR, LOG_TR69HOSTIF, "[%s] JSON parse error: %s\n", __FUNCTION__, cJSON_GetErrorPtr());
free(fileBuf);
RDK_LOG(RDK_LOG_ERROR, LOG_TR69HOSTIF, "[%s] Leaving with NOK\n", __FUNCTION__);
return retStatus;
}
filtered = cJSON_CreateObject();
if (!filtered)
{
free(fileBuf);
cJSON_Delete(root);
RDK_LOG(RDK_LOG_ERROR, LOG_TR69HOSTIF, "[%s] Leaving with NOK\n", __FUNCTION__);
return retStatus;
}

for (cJSON *top = root->child; top; top = top->next)
{
if (top->type != cJSON_Object)
{
continue;
}
cJSON *arr = cJSON_CreateArray();
if (!arr)
{
free(fileBuf);
cJSON_Delete(root);
cJSON_Delete(filtered);
RDK_LOG(RDK_LOG_ERROR, LOG_TR69HOSTIF, "[%s] Leaving with NOK\n", __FUNCTION__);
return retStatus;
}
for (cJSON *sub = top->child; sub; sub = sub->next)
{
cJSON_AddItemToArray(arr, cJSON_CreateString(sub->string));
}
if (cJSON_GetArraySize(arr) > 0)
{
cJSON_AddItemToObject(filtered, top->string, arr);
}
else
{
cJSON_Delete(arr);
}
}

outStr = cJSON_PrintUnformatted(filtered);
if (!outStr)
{
free(fileBuf);
cJSON_Delete(root);
cJSON_Delete(filtered);
RDK_LOG(RDK_LOG_ERROR, LOG_TR69HOSTIF, "[%s] Leaving with NOK\n", __FUNCTION__);
return retStatus;
}
outLen = strlen(outStr);
if (outLen >= sizeof(stMsgData->paramValue))
{
outLen = sizeof(stMsgData->paramValue) - 1;
}
memcpy(stMsgData->paramValue, outStr, outLen);
stMsgData->paramValue[outLen] = '\0';
stMsgData->paramLen = outLen;
RDK_LOG(RDK_LOG_INFO, LOG_TR69HOSTIF, "[%s] Extracted profile map: %s\n", __FUNCTION__, outStr);
retStatus = OK;
free(fileBuf);
cJSON_Delete(root);
cJSON_Delete(filtered);
free(outStr);
RDK_LOG(RDK_LOG_TRACE1, LOG_TR69HOSTIF, "[%s] Leaving with OK\n", __FUNCTION__);
return retStatus;
}

int hostIf_DeviceInfo::set_Device_DeviceInfo_X_RDKCENTRAL_COM_RDKRemoteDebuggerWebCfgData (HOSTIF_MsgData_t *stMsgData)
{
char *issueStr = NULL;
Expand Down
1 change: 0 additions & 1 deletion src/hostif/profiles/DeviceInfo/Device_DeviceInfo.h
Original file line number Diff line number Diff line change
Expand Up @@ -1293,7 +1293,6 @@ class hostIf_DeviceInfo {

int set_Device_DeviceInfo_X_RDKCENTRAL_COM_RDKRemoteDebuggerIssueType(HOSTIF_MsgData_t *);
int set_Device_DeviceInfo_X_RDKCENTRAL_COM_RDKRemoteDebuggerWebCfgData(HOSTIF_MsgData_t *);
int get_Device_DeviceInfo_X_RDKCENTRAL_COM_RDKRemoteDebuggergetProfileData(HOSTIF_MsgData_t *);
#endif

/*
Expand Down
Loading