Skip to content

Fix misleading log messages in WiFi endpoint RPC response handling - #395

Merged
Vismalskumar0 merged 2 commits into
topic/RDKEMW-14755from
copilot/sub-pr-393-again
Mar 11, 2026
Merged

Fix misleading log messages in WiFi endpoint RPC response handling#395
Vismalskumar0 merged 2 commits into
topic/RDKEMW-14755from
copilot/sub-pr-393-again

Conversation

Copilot AI commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

After switching to !response.empty() guards, the else branches in Device_WiFi_EndPoint.cpp still logged "curl init failed" — inaccurate since an empty response from getJsonRPCData() can result from RPC-level failures unrelated to curl initialization.

Changes

  • Device_WiFi_EndPoint.cpp: Replaced all three occurrences of "curl init failed" in else branches following !response.empty() checks with "getJsonRPCData() failed or returned empty response"
// Before
RDK_LOG(RDK_LOG_ERROR, LOG_TR69HOSTIF, "%s: curl init failed\n", __FUNCTION__);

// After
RDK_LOG(RDK_LOG_ERROR, LOG_TR69HOSTIF, "%s: getJsonRPCData() failed or returned empty response\n", __FUNCTION__);

Applies to all three RPC call sites: GetWiFiSignalStrength, GetConnectedSSID, and the initial endpoint query.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…getJsonRPCData() failure

Co-authored-by: Vismalskumar0 <188226757+Vismalskumar0@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on crash issue checks from PR #393 Fix misleading log messages in WiFi endpoint RPC response handling Mar 11, 2026
@Vismalskumar0
Vismalskumar0 marked this pull request as ready for review March 11, 2026 07:23
@Vismalskumar0
Vismalskumar0 requested a review from a team as a code owner March 11, 2026 07:23
Copilot AI review requested due to automatic review settings March 11, 2026 07:23
@Vismalskumar0
Vismalskumar0 merged commit 0d8ca9c into topic/RDKEMW-14755 Mar 11, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 11, 2026
Copilot AI removed the request for review from Copilot March 23, 2026 20:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants