Fix misleading log messages in WiFi endpoint RPC response handling - #395
Merged
Conversation
…getJsonRPCData() failure Co-authored-by: Vismalskumar0 <188226757+Vismalskumar0@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on crash issue checks from PR #393
Fix misleading log messages in WiFi endpoint RPC response handling
Mar 11, 2026
Vismalskumar0
marked this pull request as ready for review
March 11, 2026 07:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After switching to
!response.empty()guards, theelsebranches inDevice_WiFi_EndPoint.cppstill logged"curl init failed"— inaccurate since an empty response fromgetJsonRPCData()can result from RPC-level failures unrelated to curl initialization.Changes
Device_WiFi_EndPoint.cpp: Replaced all three occurrences of"curl init failed"inelsebranches following!response.empty()checks with"getJsonRPCData() failed or returned empty response"Applies to all three RPC call sites:
GetWiFiSignalStrength,GetConnectedSSID, and the initial endpoint query.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.