Skip to content

Rebase - #210

Merged
Abhinavpv28 merged 16 commits into
feature/get_newfrom
develop
Aug 20, 2025
Merged

Rebase#210
Abhinavpv28 merged 16 commits into
feature/get_newfrom
develop

Conversation

@Abhinavpv28

Copy link
Copy Markdown
Contributor

No description provided.

@Abhinavpv28
Abhinavpv28 requested review from a team July 28, 2025 05:40
Co-authored-by: mtirum011 <madhubabu_tirumala@comcast.com>
Comment on lines +9 to +52
name: Test coverage report for release
runs-on: ubuntu-latest
container:
image: ghcr.io/rdkcentral/docker-rdk-ci:latest

steps:
- name: Checkout code
uses: actions/checkout@v3

- name: Run unit tests with coverage flags enabled
run: |
sh run_ut.sh --enable-cov
- name: Caculate the code coverage summary
run: |
lcov --list tr69hostif_coverage.info | grep "Lines\|Total" > /tmp/coverage_summary.txt
cd -

- name: Update the coverage report to Pull request using actions
uses: actions/github-script@v4
with:
script: |
const fs = require('fs');
const lcov_result = fs.readFileSync('/tmp/coverage_summary.txt', 'utf8');

github.issues.createComment({
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
body:
'## Code Coverage Summary \n' +
' ' +
'```' +
lcov_result +
'```'
});
- name: Generate the html report
run: |
genhtml tr69hostif_coverage.info --output-directory /tmp/coverage_report
cd -
- name: Upload the coverage report to Pull request using actions
uses: actions/upload-artifact@v4
with:
name: coverage-report
path: /tmp/coverage_report

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

Copilot Autofix

AI about 1 year ago

To fix the problem, explicitly set the permissions key for the job (or at the workflow root) to grant only the minimum required privileges. In this workflow, the job needs contents: read (to check out code) and issues: write (to create a comment on the pull request). The best way to fix this is to add a permissions block under the execute-unit-code-coverage-report-on-release job, specifying contents: read and issues: write. This change should be made directly under the job definition (after name: and before runs-on:) in .github/workflows/code-coverage.yml. No additional imports or definitions are needed.


Suggested changeset 1
.github/workflows/code-coverage.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/code-coverage.yml b/.github/workflows/code-coverage.yml
--- a/.github/workflows/code-coverage.yml
+++ b/.github/workflows/code-coverage.yml
@@ -9,2 +9,5 @@
     name: Test coverage report for release
+    permissions:
+      contents: read
+      issues: write
     runs-on: ubuntu-latest
EOF
@@ -9,2 +9,5 @@
name: Test coverage report for release
permissions:
contents: read
issues: write
runs-on: ubuntu-latest
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
shibu-kv and others added 14 commits July 29, 2025 09:02
Reason for change:
Include DebugMode and TR069support RFC's with default valuse as false.

Priority: P1
Test Procedure: Follow the steps provided in description.

Risks: Low
Signed-off-by:Natraj Muthusamy <Natraj_Muthusamy@comcast.com>
RDKEMW-4344 : Include the missed RFCs in RDKE.
RDKEMW-6520: tr69hostif service starts before iarmbusd
[RDKEMW-5582] -[RDKE] tr69hostif.log contains any garbage data for the paramValue field
@Abhinavpv28
Abhinavpv28 merged commit 1e4aa14 into feature/get_new Aug 20, 2025
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants