Skip to content

rebase - #110

Open
nhanasi wants to merge 361 commits into
feature/RDK-56223from
develop
Open

rebase#110
nhanasi wants to merge 361 commits into
feature/RDK-56223from
develop

Conversation

@nhanasi

@nhanasi nhanasi commented Apr 3, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@nhanasi
nhanasi requested review from a team April 3, 2025 19:49
@CLAassistant

CLAassistant commented Apr 3, 2025

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
15 out of 18 committers have signed the CLA.

✅ NatrajMuthusamygithubpractice
✅ tpaul627
✅ shibu-kv
✅ madhubabutt
✅ DamianoBaroneSky
✅ AravindanNC
✅ nhanasi
✅ venkat0557
✅ leenaS-d
✅ Abhinavpv28
✅ MonekaLakshmi
✅ Alan-Ryan
✅ apatel859
✅ NareshM1702
✅ Vismalskumar0
❌ Tharun Kumar Venkatachalem
❌ udaykrishnag
❌ naveenkumarhanasi


Tharun Kumar Venkatachalem seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-advanced-security

Copy link
Copy Markdown
Contributor

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Vismalskumar0 and others added 12 commits August 5, 2025 13:29
[RDKEMW-5582] -[RDKE] tr69hostif.log contains any garbage data for the paramValue field
Reason for change: Set Gamepad RFC as True

Test Procedure: verify the steps in Ticket description
Risks: Medium
Priority: P1

Signed-off-by: Tharun Kumar Venkatachalem <tharunkumar_venkatachalem@comcast.com>
RDK-56291 - [RDKE] Increase L2 Test Coverage For Remote Debugger : Target 80% [ Phase 2 ]
Comment on lines +9 to +52
name: Test coverage report for release
runs-on: ubuntu-latest
container:
image: ghcr.io/rdkcentral/docker-rdk-ci:latest

steps:
- name: Checkout code
uses: actions/checkout@v3

- name: Run unit tests with coverage flags enabled
run: |
sh run_ut.sh --enable-cov
- name: Caculate the code coverage summary
run: |
lcov --list tr69hostif_coverage.info | grep "Lines\|Total" > /tmp/coverage_summary.txt
cd -

- name: Update the coverage report to Pull request using actions
uses: actions/github-script@v4
with:
script: |
const fs = require('fs');
const lcov_result = fs.readFileSync('/tmp/coverage_summary.txt', 'utf8');

github.issues.createComment({
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
body:
'## Code Coverage Summary \n' +
' ' +
'```' +
lcov_result +
'```'
});
- name: Generate the html report
run: |
genhtml tr69hostif_coverage.info --output-directory /tmp/coverage_report
cd -
- name: Upload the coverage report to Pull request using actions
uses: actions/upload-artifact@v4
with:
name: coverage-report
path: /tmp/coverage_report

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

Copilot Autofix

AI about 1 year ago

To fix the problem, explicitly set the permissions key for the job (or at the workflow root) to grant only the minimum required privileges. In this workflow, the job needs contents: read (to check out code) and issues: write (to create a comment on the pull request). The best way to fix this is to add a permissions block under the execute-unit-code-coverage-report-on-release job, specifying contents: read and issues: write. This change should be made directly under the job definition (after name: and before runs-on:) in .github/workflows/code-coverage.yml. No additional imports or definitions are needed.


Suggested changeset 1
.github/workflows/code-coverage.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/code-coverage.yml b/.github/workflows/code-coverage.yml
--- a/.github/workflows/code-coverage.yml
+++ b/.github/workflows/code-coverage.yml
@@ -9,2 +9,5 @@
     name: Test coverage report for release
+    permissions:
+      contents: read
+      issues: write
     runs-on: ubuntu-latest
EOF
@@ -9,2 +9,5 @@
name: Test coverage report for release
permissions:
contents: read
issues: write
runs-on: ubuntu-latest
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
Venkata Bojja and others added 13 commits August 21, 2025 12:48
* Update cov_build.sh

* Update hostIf_utils.cpp

* Update cov_build.sh

* Update cov_build.sh

* Update cov_build.sh

* Update cov_build.sh

* Update hostIf_utils.cpp
…th function "hostIf_WiFi_SSID::get_Device_WiFi_SSID_Fields" and "81598460" fingerprint (#223)

* Update Device_WiFi.cpp

* Update Device_WiFi_SSID.cpp

* Update Device_WiFi_EndPoint.cpp

---------

Co-authored-by: nhanasi <navihansi@gmail.com>
Co-authored-by: Venkata Bojja <39968865+venkat0557@users.noreply.github.com>
…ode from RDKE (#505)

Reason for change: Deprecated DataModel Removal for HWSelftest and SNMP code from RDKE
Test Procedure: Build and verify
Risks: Medium
Priority: P1

Signed-off-by: Tirumala, Madhubabu (Contractor) <Madhubabu_Tirumala@comcast.com>
Co-authored-by: mtirum011 <madhubabu_tirumala@comcast.com>
Copilot AI review requested due to automatic review settings July 10, 2026 16:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

Copilot AI review requested due to automatic review settings July 10, 2026 19:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

* Refactor Docker exec command in L2-tests.yml

* Update L2-tests.yml

---------

Co-authored-by: nhanasi <navihansi@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

Co-authored-by: mtirum011 <madhubabu_tirumala@comcast.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

* RDKEMW-20790 : Improve L2 Coverage for tr69hostif

* RDKEMW-20790 : L2 Coverage for tr69hostif update

---------

Co-authored-by: mtirum011 <madhubabu_tirumala@comcast.com>
Co-authored-by: madhubabutt <114217841+madhubabutt@users.noreply.github.com>
Co-authored-by: Hanasi <nhanas001c@cable.comcast.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

* Update data-model-generic.xml

* Update data-model-generic.xml

* Update Device_DeviceInfo.cpp

* Update Device_DeviceInfo.h

* Potential fix for pull request finding 'CodeQL / File created without restricting permissions'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* Update data-model-generic.xml

---------

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

santoshcomcast and others added 2 commits July 31, 2026 13:52
#502)

* RDKEMW-19163:Migrate to Existing Thunder Plugin for libds Methods and Event Notification using OSDD.

Reason for change: Migrate  to Existing Thunder Plugin.
Test Procedure: refer RDKEMW-19163
Risks: Medium
Signed-off-by:gsanto722 <grandhi_santoshkumar@comcast.com>

* archive the changes

* Update Makefile.am

* update missing migaration code

* fix build error

* fix issue and formats

* Fix all issue

* fix build issue

* fix format issue

* fix displayinfo callsign

* added compiler flag

* fix build issue and cleanup

* disable libds include in rdke

* added loging for NOT_HANDEL API in RDK-e

* fix build issue with flag

* fix build issue

* address review comments

* add L1 and L2 test cases. remove unwanted AI files

* Updated L1 and L2 test cases

* fix the L1 and L2. cleanup data-model

* fix L1, L2 run

* fix L1 and L2 tests

* fix L1 and L2

* fix build issus

* fix build issue

* fix build issue with libds cleanup

* fix coverity issue

* Potential fix for pull request finding

Update document

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* fix high copilot issue

* fix code-coverage and L1, L2 issue

* fix code coverage

* fix HDMI coverage

* add HDMI L1 test cases

* fix HDMI L1 test cases error

* fix HDMI faile test case

* Add L1 cases to increase code and funcation coverage

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

* RDKEMW-22811: Remove WiFi DML from tr69hostIf

Reason for change: WiFi DMLs for RDK-E have been added to the
WiFiMetrics component. Therefore, they are being removed from
tr69hostif.
Test procedure: Flash the build and ensure tr69hostif works
without any issues.
Risks: low
Priority: P1

Signed-off-by: Anand N Anand_N@comcast.com

* RDKEMW-22811: Remove WiFi DML from tr69hostIf

Reason for change: WiFi DMLs for RDK-E have been added to the
WiFiMetrics component. Therefore, they are being removed from
tr69hostif.
Test procedure: Flash the build and ensure tr69hostif works
without any issues.
Risks: low
Priority: P1

Signed-off-by: Anand N Anand_N@comcast.com

* RDKEMW-22811: Remove WiFi DML from tr69hostIf

Reason for change: WiFi DMLs for RDK-E have been added to the
WiFiMetrics component. Therefore, they are being removed from
tr69hostif.
Test procedure: Flash the build and ensure tr69hostif works
without any issues.
Risks: low
Priority: P1

Signed-off-by: Anand N Anand_N@comcast.com

* RDKEMW-22811: Remove WiFi DML from tr69hostIf

Reason for change: WiFi DMLs for RDK-E have been added to the
WiFiMetrics component. Therefore, they are being removed from
tr69hostif.
Test procedure: Flash the build and ensure tr69hostif works
without any issues.
Risks: low
Priority: P1

Signed-off-by: Anand N Anand_N@comcast.com

* RDKEMW-22811: Remove WiFi DML from tr69hostIf

Reason for change: WiFi DMLs for RDK-E have been added to the
WiFiMetrics component. Therefore, they are being removed from
tr69hostif.
Test procedure: Flash the build and ensure tr69hostif works
without any issues.
Risks: low
Priority: P1

Signed-off-by: Anand N Anand_N@comcast.com

* RDKEMW-22811: Remove WiFi DML from tr69hostIf

Reason for change: WiFi DMLs for RDK-E have been added to the
WiFiMetrics component. Therefore, they are being removed from
tr69hostif.
Test procedure: Flash the build and ensure tr69hostif works
without any issues.
Risks: low
Priority: P1

Signed-off-by: Anand N Anand_N@comcast.com

* RDKEMW-22811: Remove WiFi DML from tr69hostIf

Reason for change: WiFi DMLs for RDK-E have been added to the
WiFiMetrics component. Therefore, they are being removed from
tr69hostif.
Test procedure: Flash the build and ensure tr69hostif works
without any issues.
Risks: low
Priority: P1

Signed-off-by: Anand N Anand_N@comcast.com

---------

Signed-off-by: Anand N Anand_N@comcast.com
Co-authored-by: Anand <anand_n@comcast.com>
Co-authored-by: nhanasi <navihansi@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.