Skip to content

Rebase - #583

Merged
NareshM1702 merged 44 commits into
topic/RDK-61784from
develop
Jul 28, 2026
Merged

Rebase #583
NareshM1702 merged 44 commits into
topic/RDK-61784from
develop

Conversation

@NareshM1702

Copy link
Copy Markdown
Contributor

No description provided.

nhanasi and others added 30 commits January 28, 2026 10:53
…443)

Reason for change :
1] Adding utility that DS manager can use for critical deep sleep event notification to telemetry cloud
2] This provides a short circuited path only to be used for time critical eventing which is constrained
     by scenarios like the CPU going to hibernate modes.
* Update timesyncd-conf-update.sh

* Update timesyncd-conf-update.sh

---------

Co-authored-by: sindhu-krishnan <102755514+sindhu-krishnan@users.noreply.github.com>
…oth Service (#458)

Co-authored-by: nhanas001c <naveenkumar_hanasi@comcast.com>
* SERXIONE-8445:PREVIOUS_LOG event observed false reporting telemetry in RDK-E R40

Signed-off-by: PriyaDharshini_Kathiravan <priyakathiravan05@gmail.com>
(cherry picked from commit 3682e17)

* Changelog updates for hotfix 4.2.1v8 release

---------

Signed-off-by: PriyaDharshini_Kathiravan <priyakathiravan05@gmail.com>
Co-authored-by: PriyaDharshini_Kathiravan <priyakathiravan05@gmail.com>
…#462)

* RDKEMW-14555 : Updating wifi reassociation threshould tolerance RFC

* [RDKEMW-14555] : Updating wifi reassociation threshould tolerance RFC

* [RDKEMW-14555] : Updating wifi reassociation threshould tolerance RFC

---------

Co-authored-by: Garpathi, Uday Krishna <UdayKrishna_GARPATHI@comcast.com>
…al Value (#515)

Signed-off-by: PriyaDharshini_Kathiravan <priyakathiravan05@gmail.com>
…anges in sysint (#518)

Co-authored-by: mtirum011 <madhubabu_tirumala@comcast.com>
* RDKEMW-18793a: avoid thermal call in deepsleep

Signed-off-by: apatel859 <Amit_Patel5@comcast.com>

* Apply suggestions from code review

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Signed-off-by: apatel859 <Amit_Patel5@comcast.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
naveenkumarhanasi and others added 14 commits May 20, 2026 17:02
)

Co-authored-by: mtirum011 <madhubabu_tirumala@comcast.com>
… present (#551)

Reason for change: gstreamer-cleanup is happening on every reboot when /opt/cdl_flashed_file_name is missing. Fixing the issues as well as re-locating gstreamer-cleanup.service file to recipies-multimedia instead of sysint folder
Test Procedure: Boot the TV and check for gstreamer-cleanup metrics in rdk_milestones.log
Risks: low

Signed-off-by: Renuka Varry <rvarry049_comcast@cable.comcast.com>
Co-authored-by: Renuka Varry <rvarry049_comcast@cable.comcast.com>
…nly/IPv6-only networks (#581)

* DELIA-70624: updated to reset counters only if gateway is available for ipv6.

Signed-off-by: Balaji Punnuru <Balaji_Punnuru@comcast.com>

* DELIA-70624: Added debug in the script

Signed-off-by: Balaji Punnuru <Balaji_Punnuru@comcast.com>

* DELIA-70624: networkConnectionRecovery: presence-aware packet-loss recovery trigger

Recovery now fires only when no routed IP stack has acceptable
connectivity and at least one routed stack is at/above the reassociate
tolerance. This fixes the IPv4-only / IPv6-only case where a stack with
no default route left packetsLost at 0 and suppressed recovery.

Also folded in reliability/logging fixes:
- clear stale gwIp on the V6 test-hook path
- guard packet-loss comparisons against unparseable ping output
- emit SYST_WARN_GW100PERC_PACKETLOSS to the logs file on every run
- ping the IPv4 default-route interface explicitly (ping -I)
- log total ipv4/ipv6 packet loss when above threshold
- simplify the trigger to anyGood/anyBad classification

* DELIA-70624: networkConnectionRecovery: add log() helper and per-call packet-loss fix

- Introduce a log() helper that prepends the timestamp and appends to
  $logsFile, and convert the timestamped echo call sites to use it.
- Rename packetsLostipv4/packetsLostipv6 globals to
  ipv4PacketLoss/ipv6PacketLoss for clarity.
- Reset the per-call packetLoss to "" at the top of checkPacketLoss and
  guard the packet-loss telemetry block with [ -n "$packetLoss" ], so a
  routeless or unparseable ping no longer reuses the other family's value
  or triggers integer-comparison errors.
- Fix a "[" spacing bug in checkWifiDrvErrors.

Telemetry markers and t2CountNotify calls are unchanged.

* DELIA-70624: networkConnectionRecovery: log route/loss snapshot on state change

Emit a "network state changed" line with the per-stack route-present flags
and packet-loss values only when the snapshot differs from the previous run
(persisted in /tmp/.ncr_laststate), so field logs capture every transition
without printing on every run. Debugging aid for customer-site triage.

* DELIA-70624: remove debug logging and make script POSIX/busybox-sh safe

- Drop the temporary DEBUG_NCR field-debug logging; retain the
  "network state changed" transition log (now unprefixed).
- checkWifiDrvErrors(): $dir already holds the full debugfs path, so remove
  the duplicated /sys/kernel/debug/ieee80211/ prefix from the log messages,
  and capture the cat exit status so the failure log reports the real status
  instead of the enclosing test's result.
- Replace bashisms with POSIX/busybox-ash equivalents: source -> .,
  [[ =~ ]] -> case, [[ ]] -> [ ], and {1..9} -> explicit list (the brace
  form never expands under busybox ash, which had left the
  WIFIV_WARN_PL_20..90PERC packet-loss markers non-functional on target).
- Minor whitespace cleanup in checkDnsFile().

* DELIA-70624: restore 100% packet-loss triage marker and fix marker case

Reinstate the field-triage log marker for 100% packet loss that was lost
when checkPacketLoss() moved to a tolerance-based recovery decision. The
new log-only marker "100% Packet loss is observed on all routed IP stacks"
fires when every routed IP stack shows exactly 100% loss. It is independent
of WifiReassociateTolerance and does not alter the recovery/return path, so
recovery behaviour is unchanged. Unlike the legacy dual-stack
"...for both ipv4 and ipv6" print, it is also emitted correctly on
IPv4-only and IPv6-only networks. Triage associates the old and new strings
to the same 100%-packet-loss marker for trend continuity across images.

Also capitalise the "Packet loss more than 10% observed" marker (was
lowercase "packet loss ...") since triage marker matching is case-sensitive.

---------

Signed-off-by: Balaji Punnuru <Balaji_Punnuru@comcast.com>
Co-authored-by: Balaji Punnuru <Balaji_Punnuru@comcast.com>
Sysint release for 8.4 hotfix
Copilot AI review requested due to automatic review settings July 28, 2026 06:45
@NareshM1702
NareshM1702 requested a review from a team as a code owner July 28, 2026 06:45
@NareshM1702
NareshM1702 merged commit 7d4c459 into topic/RDK-61784 Jul 28, 2026
3 of 6 checks passed
@github-actions

Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


8 out of 9 committers have signed the CLA.
nhanasi
shibu-kv
egalla204
dharshini555
madhubabutt
apatel859
AravindanNC
vrenu2018
udaykrishnag
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@github-actions github-actions Bot locked and limited conversation to collaborators Jul 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.