Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/component-release-finish-on-approval.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ jobs:
name: Finish release when PR is approved
if: >
github.event.review.state == 'approved' &&
github.event.pull_request.base.ref == 'develop' &&
github.event.pull_request.base.ref == 'main' &&
startsWith(github.event.pull_request.head.ref, 'release/')
runs-on: comcast-ubuntu-latest
runs-on: ubuntu-latest
env:
REPO: ${{ github.repository }}
ACTOR: ${{ github.event.review.user.login }}
GH_TOKEN: ${{ secrets.RDKCM_RDKE }}
GH_TOKEN: ${{ github.token }}
RELEASE_BRANCH: ${{ github.event.pull_request.head.ref }}

steps:
Expand Down
15 changes: 11 additions & 4 deletions .github/workflows/component-release-workflow-usage.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ This prevents two runs for the same version/type from racing on branches/tags.
**Main release - approvable**
1. Validates version format.
2. Runs `git flow release start` -> changelog -> `release publish`.
3. Creates a PR: `release/<version>` -> `develop`.
3. Creates a PR: `release/<version>` -> `main`.
4. Stops and waits for PR approval.
5. On approval, the second workflow finishes the release.

Expand All @@ -48,21 +48,28 @@ This prevents two runs for the same version/type from racing on branches/tags.

### 2. Component Release Finish On Approval (`component-release-finish-on-approval.yml`)

Triggered on approved review for `release/*` PRs targeting `develop`.
Triggered on approved review for `release/*` PRs targeting `main`.

#### What it does
1. Verifies PR review decision is `APPROVED`.
2. Checks out release branch.
3. Runs `git flow release finish` (merge to `main` + `develop`, create tag).
4. Pushes `main`, `develop`, and tags.
5. Closes the release PR.
5. Deletes remote `release/<version>` branch.
6. Closes the release PR.

## Authentication and Secrets

Both workflows use:

- `RDKCM_DEPLOY_KEY`: SSH private key used by checkout and git push operations.
- `RDKCM_RDKE`: token used by `gh` API/CLI calls.
- `github.token`: built-in GitHub Actions token used by `gh` API/CLI calls.

Why `github.token`:

- It is automatically provided for each workflow run.
- It avoids introducing a custom repository secret for API access.
- It works with the workflow permissions already declared in these jobs.

## Failure Cleanup Safety

Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/component-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,15 @@ concurrency:

jobs:
release:
runs-on: comcast-ubuntu-latest
runs-on: ubuntu-latest
env:
RELEASE_VERSION: ${{ github.event.inputs.release_version }}
RELEASE_TYPE: ${{ github.event.inputs.release_type }}
RELEASE_MODE: ${{ github.event.inputs.release_mode }}
SOURCE_BRANCH: ${{ github.event.inputs.source_branch }}
REPO: ${{ github.repository }}
ACTOR: ${{ github.actor }}
GH_TOKEN: ${{ secrets.RDKCM_RDKE }}
GH_TOKEN: ${{ github.token }}

steps:
- name: Validate version format
Expand Down Expand Up @@ -119,7 +119,7 @@ jobs:
git push origin main
git push origin --tags
git push origin develop
git push origin --delete "release/${RELEASE_VERSION}" || true
git push origin --delete "release/${RELEASE_VERSION}" || true

#
# ── APPROVABLE RELEASE ──
Expand Down Expand Up @@ -148,16 +148,16 @@ jobs:
git flow release publish "${RELEASE_VERSION}"
fi

existing_pr=$(gh pr list --head "${release_branch}" --base develop --state open --json number -q '.[0].number')
existing_pr=$(gh pr list --head "${release_branch}" --base main --state open --json number -q '.[0].number')
if [ -z "${existing_pr}" ]; then
gh pr create \
--base develop \
--base main \
--head "${release_branch}" \
--title "Release ${RELEASE_VERSION}" \
--body "Automated release PR for ${RELEASE_VERSION}. Approve this PR to trigger release finish."
echo "PR created. Waiting for approval to finish release."
else
echo "PR from ${release_branch} to develop already exists (#${existing_pr})."
echo "PR from ${release_branch} to main already exists (#${existing_pr})."
fi

#
Expand Down
15 changes: 14 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,22 @@ All notable changes to this project will be documented in this file. Dates are d

Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).

#### [6.0.0](https://github.com/rdkcentral/sysint/compare/5.1.0...6.0.0)
#### [6.0.1](https://github.com/rdkcentral/sysint/compare/6.0.0...6.0.1)

- RDKE-1065: Automated workflow - create pull request to main instead of develop [`#572`](https://github.com/rdkcentral/sysint/pull/572)
- RDKEMW-20916 : [RDKE] [Develop] RDKV-to-RDKE Migration: Unexpected Network Connectivity Prior to Migration Completion [`#571`](https://github.com/rdkcentral/sysint/pull/571)
- RDKEMW-10439: Reboot device with WareHouse plugin resetDevice [`#381`](https://github.com/rdkcentral/sysint/pull/381)
- RDKEMW-21159: avoid thermal call in deepsleep (#548) [`#566`](https://github.com/rdkcentral/sysint/pull/566)
- RDKE-1065: Automated Component release workflow [`#562`](https://github.com/rdkcentral/sysint/pull/562)
- RDKE-1065: Using ubuntu-latest runner for release workflow [`#557`](https://github.com/rdkcentral/sysint/pull/557)
- Merge tag '6.0.0' into develop [`e96c345`](https://github.com/rdkcentral/sysint/commit/e96c34560bc16714dec958463ebf64772902f45d)

### [6.0.0](https://github.com/rdkcentral/sysint/compare/5.1.0...6.0.0)

> 29 June 2026

- RDKE-1065: Automated Component Release workflow [`#553`](https://github.com/rdkcentral/sysint/pull/553)
- 6.0.0 release changelog updates [`58e2d19`](https://github.com/rdkcentral/sysint/commit/58e2d19f3d246800212a97f5bd95aeeb923fa4be)
- Merge tag '5.1.0' into develop [`4e51a4f`](https://github.com/rdkcentral/sysint/commit/4e51a4f92b24157d5062264fde85c9469242494f)

#### [5.1.0](https://github.com/rdkcentral/sysint/compare/5.0.2...5.1.0)
Expand Down
1 change: 0 additions & 1 deletion lib/rdk/factory-reset.sh
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ if [ -f /etc/os-release ];then
/bin/systemctl stop dump-backup.service
/bin/systemctl stop dnsmasq.service
/bin/systemctl stop syslog.socket
/bin/systemctl stop wpeframework.service
if [ "$DOBBY_ENABLED" == "true" ]; then
/bin/systemctl stop dobby.service
fi
Expand Down
9 changes: 8 additions & 1 deletion lib/rdk/temperature-telemetry.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,14 @@
if [ -f /lib/rdk/t2Shared_api.sh ]; then
source /lib/rdk/t2Shared_api.sh
fi
boardTemp=`/bin/cat /sys/class/thermal/thermal_zone0/temp | sed 's/./&./2'`c

powerState=$(/usr/bin/QueryPowerState)

if [ "$powerState" != "DEEPSLEEP" ]; then
boardTemp=`/bin/cat /sys/class/thermal/thermal_zone0/temp | sed 's/./&./2'`c
else
boardTemp="Device in Deepsleep"
fi

/bin/echo Temperature:$boardTemp
t2ValNotify "Board_temperature_split" "$boardTemp"
3 changes: 2 additions & 1 deletion systemd_units/NetworkManager_ecfs.conf
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
[Unit]
After=securemount.service
After=securemount.service bootversion-loader.service
Wants=bootversion-loader.service
Loading