RDKEMW-19100:gst-cleanup conditions when cdl_flashed_file_name is not present - #551
Merged
Conversation
… present Reason for change: gstreamer-cleanup is happening on every reboot when /opt/cdl_flashed_file_name is missing. Fixing the issues as well as re-locating gstreamer-cleanup.service file to recipies-multimedia instead of sysint folder Test Procedure: Boot the TV and check for gstreamer-cleanup metrics in rdk_milestones.log Risks: low Signed-off-by: Renuka Varry <rvarry049_comcast@cable.comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR intends to stop gstreamer-cleanup from running on every reboot when /opt/cdl_flashed_file_name is missing, and to relocate the gstreamer-cleanup.service unit out of systemd_units/.
Changes:
- Removes
systemd_units/gstreamer-cleanup.servicefrom this repository.
Comments suppressed due to low confidence (1)
systemd_units/gstreamer-cleanup.service:1
- The PR description says this change fixes the cleanup conditions (when /opt/cdl_flashed_file_name is missing) and relocates gstreamer-cleanup.service under recipes-multimedia, but the PR diff shown here only deletes this unit. In this repo checkout there is no replacement unit/recipe (no other occurrences of "gstreamer-cleanup"), so this appears to remove the cleanup behavior entirely rather than adjusting its conditions. Please either add the new unit/recipe to this PR (and ensure it’s installed/enabled), or update the PR description/scope to reflect that the relocation happens in a different repo.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nhanasi
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: gstreamer-cleanup is happening on every reboot when /opt/cdl_flashed_file_name is missing. Fixing the issues as well as re-locating gstreamer-cleanup.service file to recipies-multimedia instead of sysint folder
Test Procedure: Boot the TV and check for gstreamer-cleanup metrics in rdk_milestones.log
Risks: low