Skip to content

RDKEMW-10017 : NetworkManager based connectivity check in RDKE #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tdeva14 merged 7 commits into from
Nov 3, 2025
Merged

RDKEMW-10017 : NetworkManager based connectivity check in RDKE #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
86a3569
Update NM_Dispatcher.sh
sindhu-krishnan Oct 31, 2025
55141c8
Delete lib/rdk/connectivitycheck.sh
sindhu-krishnan Oct 31, 2025
2da8ab5
Create notify-network-ready.service
sindhu-krishnan Oct 31, 2025
5e5227b
Update minidump-upload.service
sindhu-krishnan Oct 31, 2025
47ea9b7
Update minidump-secure-upload.service
sindhu-krishnan Oct 31, 2025
6850a49
Update coredump-upload.service
sindhu-krishnan Oct 31, 2025
ea91a11
Update service dependencies for coredump upload
sindhu-krishnan Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions lib/rdk/NM_Dispatcher.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,15 +107,9 @@ interfaceName=$1
interfaceStatus=$2

if [ "$interfaceStatus" = "up" ]; then
/usr/bin/nm-online -q -t 60 # If Network manager is not online wait for 60 sec. TODO: Revisit this during connectivity check enable time

CON_STATE=$(nmcli -t -f GENERAL.STATE device show "$interfaceName" 2>/dev/null | cut -d: -f2)
NMdispatcherLog "Connection state of interface $interfaceName=$CON_STATE"
if [ "$CON_STATE" = "100 (connected)" ] || [ "$CON_STATE" = "120 (connected (site only))" ]; then
NMdispatcherLog "Connection state of $interfaceName is connected."
sh /lib/rdk/connectivitycheck.sh &
else
NMdispatcherLog "Connection state of $interfaceName Up But Not Fully connected."
fi
fi

if [ "x$interfaceName" != "x" ] && [ "$interfaceName" != "lo" ]; then
Expand Down
79 changes: 0 additions & 79 deletions lib/rdk/connectivitycheck.sh
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions systemd_units/coredump-secure-upload.service
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
[Unit]
Description=COREDUMP UPLOAD

After=network-up.target tr69hostif.service
Requires=network-up.target
After=network-online.target tr69hostif.service
Requires=network-online.target

[Service]
ExecStart=/lib/rdk/uploadDumps.sh "" 1 secure
Expand Down
4 changes: 2 additions & 2 deletions systemd_units/coredump-upload.service
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
[Unit]
Description=COREDUMP UPLOAD

After=network-up.target
Requires=network-up.target
After=network-online.target
Requires=network-online.target

[Service]
ExecStart=/lib/rdk/uploadDumps.sh "" 1
Expand Down
4 changes: 2 additions & 2 deletions systemd_units/minidump-secure-upload.service
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
[Unit]
Description=MINIDUMP UPLOAD

After=network-up.target tr69hostif.service
Requires=network-up.target
After=network-online.target tr69hostif.service
Requires=network-online.target

[Service]
ExecStart=/lib/rdk/uploadDumps.sh "" 0 secure
Expand Down
4 changes: 2 additions & 2 deletions systemd_units/minidump-upload.service
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
[Unit]
Description=MINIDUMP UPLOAD

After=network-up.target
Requires=network-up.target
After=network-online.target
Requires=network-online.target

[Service]
ExecStart=/lib/rdk/uploadDumps.sh "" 0
Expand Down
8 changes: 8 additions & 0 deletions systemd_units/notify-network-ready.service
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
[Unit]
Description=Log Internet connectivity and Trigger network target
After=dbus.service

[Service]
Type=oneshot
ExecStartPre=/bin/touch /tmp/connectivity_check_done
ExecStart=/lib/rdk/logMilestone.sh "INTERNET_FULLY_CONNECTED"