Skip to content

RDKEMW-9440 : Fixed issue with TV Builds. - #339

Merged
bpunnuru merged 7 commits into
support/2.2.0from
feature/RDKEMW-4148
Oct 17, 2025
Merged

RDKEMW-9440 : Fixed issue with TV Builds.#339
bpunnuru merged 7 commits into
support/2.2.0from
feature/RDKEMW-4148

Conversation

@bpunnuru

Copy link
Copy Markdown
Contributor

No description provided.

Balaji Punnuru added 6 commits October 14, 2025 11:50
Signed-off-by: Balaji Punnuru <Balaji_Punnuru@comcast.com>
Signed-off-by: Balaji Punnuru <Balaji_Punnuru@comcast.com>
Signed-off-by: Balaji Punnuru <Balaji_Punnuru@comcast.com>
…ed settings.

Signed-off-by: Balaji Punnuru <Balaji_Punnuru@comcast.com>
Signed-off-by: Balaji Punnuru <Balaji_Punnuru@comcast.com>
@bpunnuru
bpunnuru requested a review from a team as a code owner October 16, 2025 15:32
@CLAassistant

CLAassistant commented Oct 16, 2025

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Balaji Punnuru seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bpunnuru
bpunnuru changed the base branch from develop to support/2.2.0 October 16, 2025 15:33
@karuna2git karuna2git changed the title RDKEMW-4148: Fixed issue with TV Builds. RDKEMW-9379 : Fixed issue with TV Builds. Oct 17, 2025
Comment thread lib/rdk/NM_Bootstrap.sh
cp /opt/NetworkManager/system-connections/* /opt/secure/NetworkManager/system-connections/
rm -rf /opt/NetworkManager/system-connections/*
fi
nmcli conn reload

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be moved inside the if - fi as thats where we do the connection settings moved.
Having it outside will lead to calling reload on every reboot.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with Balaji and confirmed that this is not affecting the boot-up and having zero impact.. so leaving it as is; we can address it in develop properly

Comment thread lib/rdk/NM_Bootstrap.sh
if [ -d /opt/NetworkManager/system-connections ]; then
rm -rf /opt/NetworkManager/system-connections/*
fi
if [ "$RDK_PROFILE" == "TV" ]; then

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block of script will not execute at all for TV platforms as the SSID will be ALWAYS empty.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with Balaji and he mentioned that this is just to double-sure. Im okey with this change

@karuna2git karuna2git changed the title RDKEMW-9379 : Fixed issue with TV Builds. RDKEMW-9440 : Fixed issue with TV Builds. Oct 17, 2025
@bpunnuru
bpunnuru merged commit d597234 into support/2.2.0 Oct 17, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants