Release 1.3.0 - #13
Closed
bunnam988 wants to merge 4 commits into
Closed
Conversation
Release 1.1.0 1.1.0
Reason for change: Remove all accountId-based pairing restrictions so devices pair irrespective of accountId Test Procedure: Risks: Low Coverage: Signed-off-by:Veeraputhiran_Thangavel@comcast.com --------- Co-authored-by: veeraputhiran <veeraputhiran_thangavel@comcast.com> Co-authored-by: veeraputhiran-thangavel <224542127+veeraputhiran-thangavel@users.noreply.github.com>
## Summary Adds a caller workflow that runs the shared PR format check from `rdkcentral/build_tools_workflows`. ## What it does Automatically checks every new/edited PR (including fork PRs) for: - Title format: `TICKET-123 : description` (multiple tickets supported) - Required description fields: Reason for change, Test Procedure, Risks, Priority Fails the check and posts a reminder comment if format is incorrect. Deletes the comment automatically when fixed. ## Files changed - `.github/workflows/pr-lint.yml` (9 lines — caller only, no logic)
There was a problem hiding this comment.
Pull request overview
Release 1.3.0 updates the IDM (Inter Device Manager) components to use CCSP/RDK logging primitives, adds telemetry events for discovery/device association, and introduces a PR format lint workflow as part of the release packaging.
Changes:
- Add PR format check GitHub Actions workflow.
- Switch IDM components from
g_message/g_printerr/fprintftoCcspTrace*logging (and add optional telemetry events). - Update build/link flags for
libupnpidmand bump changelog for 1.3.0.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/Makefile.am |
Adds target-specific flags/libs for libupnpidm to support CCSP/RDK logging. |
src/idm_server.c |
Converts server-side IDM logging to CcspTrace*. |
src/idm_library.c |
Converts library logging to CcspTrace* (including error reporting paths). |
src/idm_client.c |
Converts client logging to CcspTrace*, adds telemetry events, and adjusts discovery/device association flow. |
CHANGELOG.md |
Adds 1.3.0 entry (but currently missing key release metadata/details). |
.github/workflows/pr-lint.yml |
Introduces PR format check workflow via reusable workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
78
to
+80
| libupnpidm_la_SOURCES = idm_server.c idm_client.c idm_library.c | ||
| libupnpidm_la_CFLAGS = $(AM_CFLAGS) -DFEATURE_SUPPORT_RDKLOG | ||
| libupnpidm_la_LIBADD = -lrdkloggers -lccsp_common |
Comment on lines
51
to
+53
| result = g_file_get_contents ("//etc//udhcpc.vendor_specific", &udhcpcvendorfile, NULL, &error); | ||
| if (result == FALSE) { | ||
| g_message("Problem in reading /etc/udhcpcvendorfile file %s", error->message); | ||
| CcspTraceError(("Problem in reading /etc/udhcpcvendorfile file %s\n", error->message)); |
Comment on lines
891
to
895
| if(!(dc_obj->interface)||(dc_obj->port)==0||(dc_obj->discovery_interval)==0||(dc_obj->loss_detection_window)==0) | ||
| { | ||
| g_message("some of mandatory values are missing"); | ||
| g_message("interface=%s port=%d discovery_interval=%d loss_detection_window=%d\n", dc_obj->interface, dc_obj->port, dc_obj->discovery_interval, dc_obj->loss_detection_window); | ||
| CcspTraceError(("some of mandatory values are missing\n")); | ||
| CcspTraceInfo(("interface=%s port=%d discovery_interval=%d loss_detection_window=%d\n", dc_obj->interface, dc_obj->port, dc_obj->discovery_interval, dc_obj->loss_detection_window)); | ||
| return; |
Comment on lines
+7
to
+10
| #### [1.3.0](https://github.com/rdkcentral/secure-upnp/compare/1.2.0...1.3.0) | ||
|
|
||
| - RDKB-66032 : Add PR Format Check workflow [`#12`](https://github.com/rdkcentral/secure-upnp/pull/12) | ||
|
|
Comment on lines
+3
to
+11
| on: | ||
| pull_request_target: | ||
| types: [opened, edited, synchronize, reopened] | ||
|
|
||
| permissions: | ||
| contents: read | ||
| issues: write | ||
| pull-requests: write | ||
|
|
Comment on lines
+7
to
+10
| #### [1.3.0](https://github.com/rdkcentral/secure-upnp/compare/1.2.0...1.3.0) | ||
|
|
||
| - RDKB-66032 : Add PR Format Check workflow [`#12`](https://github.com/rdkcentral/secure-upnp/pull/12) | ||
|
|
|
📋 PR Format Reminder
Expected: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 1.3.0