Skip to content

Update rfc_xconf_handler.cpp #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nhanasi wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Update rfc_xconf_handler.cpp #185

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
209890e
Update rfc_xconf_handler.cpp
nhanasi Mar 9, 2026
0ac50d4
Update rfc_xconf_handler.cpp
nhanasi Mar 9, 2026
0144772
Update rfc_xconf_handler.cpp
nhanasi Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions rfcMgr/rfc_xconf_handler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1296,9 +1296,9 @@ void RuntimeFeatureControlProcessor::clearDB(void)
std::ofstream touch_file(TR181STOREFILE);
touch_file.close();

set_RFCProperty(name, ClearDB, clearValue);
set_RFCProperty(name, BootstrapClearDB, clearValue);
set_RFCProperty(name, ConfigChangeTimeKey, ConfigChangeTime);
set_RFCProperty(name, ClearDB, std::move(clearValue));

Copilot AI Mar 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation on this line uses a tab while surrounding lines use spaces, which makes formatting inconsistent. Align indentation with the existing spacing style in this function/file.

Suggested change
set_RFCProperty(name, ClearDB, std::move(clearValue));
set_RFCProperty(name, ClearDB, std::move(clearValue));

Copilot uses AI. Check for mistakes.
set_RFCProperty(name, BootstrapClearDB, std::move(clearValue));

@rdkcmf-jenkins rdkcmf-jenkins Mar 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity Issue - Using a moved object

"clearValue" is used after it has been already moved.

High Impact, CWE-457
USE_AFTER_MOVE

set_RFCProperty(name, std::move(ConfigChangeTimeKey), ConfigChangeTime);

RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] Clearing DB Value: %s\n", __FUNCTION__,__LINE__,ClearDB.c_str());

@rdkcmf-jenkins rdkcmf-jenkins Mar 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Using a moved object

"ClearDB" is used after it has been already moved.

High Impact, CWE-457
USE_AFTER_MOVE

RDK_LOG(RDK_LOG_INFO, LOG_RFCMGR, "[%s][%d] Bootstrap Clearing DB Value: %s\n", __FUNCTION__,__LINE__,BootstrapClearDB.c_str());

@rdkcmf-jenkins rdkcmf-jenkins Mar 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Using a moved object

"BootstrapClearDB" is used after it has been already moved.

High Impact, CWE-457
USE_AFTER_MOVE

Expand Down
Loading