Skip to content

Remote Debugger1.2.8 release #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nhanasi wants to merge 4 commits into from
Closed

Remote Debugger1.2.8 release #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
37a89a1
Merge tag '1.2.7' into develop
naveenkumarhanasi May 19, 2025
6ae85f4
DELIA-68076: RRD Various commands getting "failed because the control…
AravindanNC May 29, 2025
778c4c1
DELIA-68122 - RRD device stopped running RRD commands, logs show no p…
Abhinavpv28 Jun 25, 2025
84074ba
1.2.8 release changelog updates
nhanasi Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,22 @@ All notable changes to this project will be documented in this file. Dates are d

Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).

#### [1.2.8](https://github.com/rdkcentral/remote_debugger/compare/1.2.7...1.2.8)

- DELIA-68122 - RRD device stopped running RRD commands, logs show no progress [`#136`](https://github.com/rdkcentral/remote_debugger/pull/136)
- DELIA-68076: RRD Various commands getting "failed because the control process exited with error code." [`#134`](https://github.com/rdkcentral/remote_debugger/pull/134)
- Merge tag '1.2.7' into develop [`37a89a1`](https://github.com/rdkcentral/remote_debugger/commit/37a89a12e83462bc5e2c36e677d7f3ebab32c200)

#### [1.2.7](https://github.com/rdkcentral/remote_debugger/compare/1.2.6...1.2.7)

> 19 May 2025

- [DELIA-68036] RRD failing in device for some commands, getting invalid message type (SCXI11BEI) [`#121`](https://github.com/rdkcentral/remote_debugger/pull/121)
- RDKEMW-3380 : Evaluate the Deepsleep Scenario for Static and Dynamic method [`#125`](https://github.com/rdkcentral/remote_debugger/pull/125)
- Revert " RDK-56291 L2 Tests And Integration With CI for Remote Debugger Dynam…" [`#126`](https://github.com/rdkcentral/remote_debugger/pull/126)
- RDKEMW-3380 : Evaluate the Deepsleep Scenario for Static and Dynamic method [`#123`](https://github.com/rdkcentral/remote_debugger/pull/123)
- RDK-56291 L2 Tests And Integration With CI for Remote Debugger Dynamic Updates [`#117`](https://github.com/rdkcentral/remote_debugger/pull/117)
- 1.2.7 release changelog updates [`d893197`](https://github.com/rdkcentral/remote_debugger/commit/d893197f25f8f2f27394e1d757669000c38b1068)
- Merge tag '1.2.6' into develop [`81ef88a`](https://github.com/rdkcentral/remote_debugger/commit/81ef88a4171be7188d4fd72dfecd4fc9b48288dc)

#### [1.2.6](https://github.com/rdkcentral/remote_debugger/compare/1.2.5...1.2.6)
Expand Down
8 changes: 5 additions & 3 deletions src/rrdInterface.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,13 +318,15 @@ void _remoteDebuggerEventHandler(rbusHandle_t handle, rbusEvent_t const* event,
return;
}

int len = strlen(rbusValue_GetString(value, NULL));
dataMsg = (char*) rbusValue_GetString(value, NULL);
int len = strlen(rbusValue_GetString(value, NULL))+1;
dataMsg = (char *) calloc(1, len);
if(!dataMsg)
{
RDK_LOG(RDK_LOG_ERROR,LOG_REMDEBUG,"[%s:%d]: Returning dataMsg being NULL \n", __FUNCTION__, __LINE__);
RDK_LOG(RDK_LOG_ERROR,LOG_REMDEBUG,"[%s:%d]: Memory Allocation Failed for %s \n", __FUNCTION__, __LINE__, rbusValue_ToString(value, NULL, 0));
return;
}
strncpy(dataMsg, rbusValue_GetString(value, NULL), len-1);
dataMsg[len-1]='\0';
if (dataMsg[0] == '\0' || len <= 0 )
{
RDK_LOG(RDK_LOG_DEBUG,LOG_REMDEBUG,"[%s:%d]: Message Received is empty, Exit Processing!!! \n", __FUNCTION__, __LINE__);
Expand Down
3 changes: 1 addition & 2 deletions src/rrdRunCmdThread.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ bool executeCommands(issueData *cmdinfo)

removeQuotes(cmdData->command);

FILE *systemdfp = v_secure_popen("r", "systemd-run -r --unit=%s --service-type=oneshot /bin/sh -c %s", remoteDebuggerServiceStr, cmdData->command);
FILE *systemdfp = v_secure_popen("r", "systemd-run -r --unit=%s --service-type=oneshot -p RemainAfterExit=yes /bin/sh -c %s", remoteDebuggerServiceStr, cmdData->command);
if(systemdfp == NULL)
{
RDK_LOG(RDK_LOG_ERROR,LOG_REMDEBUG,"[%s:%d]: Starting remote_debugger_%s service failed!!!\n",__FUNCTION__,__LINE__,cmdData->rfcvalue);
Expand Down Expand Up @@ -417,7 +417,6 @@ bool executeCommands(issueData *cmdinfo)
/*Stop or Reset runtime service for issue*/
RDK_LOG(RDK_LOG_INFO,LOG_REMDEBUG,"[%s:%d]: Stopping remote_debugger_%s service...\n",__FUNCTION__,__LINE__,cmdData->rfcvalue);
v_secure_system("systemctl stop %s", remoteDebuggerServiceStr);
v_secure_system("systemctl reset-failed %s", remoteDebuggerServiceStr);
free(cmdData->rfcvalue); // free rfcvalue received from RRDEventThreadFunc
free(cmdData->command); // free updated command info received from RRDEventThreadFunc
free(cmdData);
Expand Down
Loading