RDKEMW-17503:[support/8.3.4.0][RDKE] Xumo TV devices with older builds failing to upgrade due to image verification failure error - #238
Conversation
…s failing to upgrade due to image verification failure error
There was a problem hiding this comment.
Pull request overview
Updates the firmware-upgrade flow and unit-test scaffolding to use an updated eraseFolderExce* helper (now taking a PDRI-related parameter), and adjusts local test/build scripts to fetch/build common_utilities where that helper likely lives.
Changes:
- Update
eraseFolderExcePramaFile→eraseFolderExceParamFileusage and add a new PDRI parameter in the upgrade path. - Update unit-test mocks/prototypes to match the new function signature.
- Add
common_utilitiesclone/build steps to UT/L2/Coverity scripts.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
unittest/miscellaneous_mock.cpp |
Updates mock method + C-wrapper to new eraseFolderExceParamFile signature. |
unittest/basic_rdkv_main_gtest.cpp |
Updates extern prototype to match the new signature for tests. |
src/rdkv_main.c |
Calls the renamed helper with an additional PDRI argument during upgrade trigger. |
run_ut.sh |
Adds building common_utilities before running unit tests. |
run_l2.sh |
Adds building common_utilities before running L2 tests. |
cov_build.sh |
Adds building common_utilities before Coverity build. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
run_l2.sh:33
common_utilitiesis configured with--prefix=${INSTALL_DIR}beforeINSTALL_DIRis exported (it’s set later at line 32). This means the dependency may install into an unintended prefix and can cause later build/runtime failures. Move theROOT/INSTALL_DIRexport block above thecommon_utilitiesbuild (or pass an explicit prefix).
git clone https://github.com/rdkcentral/common_utilities.git
cd common_utilities
git checkout develop
autoreconf -i
./configure --enable-rdkcertselector --prefix=${INSTALL_DIR} CFLAGS=" -DRDK_LOGGER "
make && make install
cd ../
WORKDIR=`pwd`
export ROOT=/usr
export INSTALL_DIR=${ROOT}/local
mkdir -p $INSTALL_DIR
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.