Skip to content

RDKEMW-9936: Create a Distro to build Player Interface Component - #92

Open
ALSAMEEMA wants to merge 4 commits into
developfrom
feature/RDKEMW-9936
Open

RDKEMW-9936: Create a Distro to build Player Interface Component#92
ALSAMEEMA wants to merge 4 commits into
developfrom
feature/RDKEMW-9936

Conversation

@ALSAMEEMA

Copy link
Copy Markdown
Contributor

No description provided.

@ALSAMEEMA
ALSAMEEMA requested a review from a team as a code owner December 10, 2025 09:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new distribution feature flag build_player_interface to enable building the Player Interface Component as part of the RDKE distribution configuration. The change follows the existing pattern for feature additions in the distro configuration file.

  • Adds build_player_interface feature flag to DISTRO_FEATURES

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 16, 2026 08:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread conf/rdke-distros.inc
DISTRO_FEATURES:append = ' memcapture'
DISTRO_FEATURES:append = ' build_external_player_interface'


Copilot AI Jan 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two unnecessary blank lines added after the new distro feature. The file follows a pattern where most distro features are added consecutively without blank lines between them, with only occasional single blank lines for logical grouping. Adding two consecutive blank lines here is inconsistent with the rest of the file.

Suggested change

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task: Soc Separation with Distro

3 participants