[RDKDEV-1435] Infosys-LGI extensions of the LED states - #214
Open
abhayadev-sankaran-infosys wants to merge 1 commit into
Open
[RDKDEV-1435] Infosys-LGI extensions of the LED states#214abhayadev-sankaran-infosys wants to merge 1 commit into
abhayadev-sankaran-infosys wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Device Settings HAL front-panel LED state enumeration to include additional Infosys-LGI-specific device states, enabling platforms and clients to represent more granular operational conditions via dsFPDLedState_t.
Changes:
- Added 7 new
dsFPD_LED_DEVICE_*enumerators for cold-standby, boot-in-progress, PSU failure, WPS session overlap, IP acquired/no IP, and RCU command. - Grouped the new values under an “Infosys-LGI extensions” section within
dsFPDLedState_t.
Suppressed comments (1)
include/dsFPDTypes.h:208
dsFPD_LED_DEVICE_WPS_SES_OVERLAPuses the abbreviationSES, which is ambiguous in a public API and breaks the clearer naming style used by the other WPS-related states. Consider spelling it out asdsFPD_LED_DEVICE_WPS_SESSION_OVERLAP.
dsFPD_LED_DEVICE_PSU_FAILURE, ///< Power supply failure
dsFPD_LED_DEVICE_WPS_SES_OVERLAP, ///< WPS session overlap detected
dsFPD_LED_DEVICE_IP_ACQUIRED, ///< Device acquired IP address
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+203
to
+205
| /* Infosys-LGI extensions */ | ||
| dsFPD_LED_DEVICE_COLDSTANDBY, ///< Device is in Cold Standby mode | ||
| dsFPD_LED_DEVICE_BOOT_IN_PROGRESS, ///< Bootup is in progress |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[RDKDEV-1435] Adding the following additional LED states,
dsFPD_LED_DEVICE_COLDSTANDBY #Device is in Cold Standby mode
dsFPD_LED_DEVICE_BOOT_IN_PROGRESS #Bootup is in progress
dsFPD_LED_DEVICE_PSU_FAILURE #Power supply failure
dsFPD_LED_DEVICE_WPS_SES_OVERLAP #WPS session overlap detected
dsFPD_LED_DEVICE_IP_ACQUIRED #Device acquired IP address
dsFPD_LED_DEVICE_NO_IP #Device did not get any IP address assigned
dsFPD_LED_DEVICE_RCU_COMMAND #RCU command received by device