Skip to content

updated PLAT_DS_SetDeepSleep to report DEEPSLEEPMGR_WAKEUP_FAILURE - #18

Merged
kanjoe24 merged 6 commits into
developfrom
additional-erro-code-PLAT_DS_SetDeepSleep
May 8, 2026
Merged

updated PLAT_DS_SetDeepSleep to report DEEPSLEEPMGR_WAKEUP_FAILURE#18
kanjoe24 merged 6 commits into
developfrom
additional-erro-code-PLAT_DS_SetDeepSleep

Conversation

@apatel859

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: apatel859 <Amit_Patel5@comcast.com>
Copilot AI review requested due to automatic review settings May 6, 2026 13:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the public Deep Sleep Manager HAL header documentation to reflect that PLAT_DS_SetDeepSleep() may return DEEPSLEEPMGR_WAKEUP_FAILURE when resume/wakeup handling fails.

Changes:

  • Documented DEEPSLEEPMGR_WAKEUP_FAILURE as a possible return value for PLAT_DS_SetDeepSleep().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread include/deepSleepMgr.h Outdated
@hari22yuva
hari22yuva changed the base branch from main to develop May 6, 2026 13:52
Comment thread include/deepSleepMgr.h Outdated
Signed-off-by: apatel859 <Amit_Patel5@comcast.com>
srinivasgtl
srinivasgtl previously approved these changes May 8, 2026

@srinivasgtl srinivasgtl left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.

Comment thread include/deepSleepMgr.h Outdated
Copilot AI review requested due to automatic review settings May 8, 2026 13:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

Comment thread include/deepSleepMgr.h Outdated
Comment thread include/deepSleepMgr.h Outdated
Comment thread include/deepSleepMgr.h

@JohnMelvin23 JohnMelvin23 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copilot AI review requested due to automatic review settings May 8, 2026 16:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread include/deepSleepMgr.h

@srinivasgtl srinivasgtl left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.

@JohnMelvin23 JohnMelvin23 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kanjoe24
kanjoe24 merged commit 5c450bb into develop May 8, 2026
3 checks passed
@kanjoe24
kanjoe24 deleted the additional-erro-code-PLAT_DS_SetDeepSleep branch May 8, 2026 16:36
@github-actions github-actions Bot locked and limited conversation to collaborators May 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Status: Resolved

Development

Successfully merging this pull request may close these issues.

Feature: Adding Extra error code for the failures during deepsleep resume

6 participants