Skip to content

rbuscli: fixup resource leak in execute_discover_elements_cmd #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Permanence-AI-Coder wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

rbuscli: fixup resource leak in execute_discover_elements_cmd #389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion utils/rbuscli/rbuscli.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1009,7 +1009,7 @@ void execute_discover_elements_cmd(int argc, char *argv[])
int numOfInputParams = argc - 2;
bool nextLevel = true;
int numElements = 0;
char** pElementNames; // FIXME: every component will have more than RBUS_CLI_MAX_PARAM elements right?
char** pElementNames = NULL; // FIXME: every component will have more than RBUS_CLI_MAX_PARAM elements right?

if (!verify_rbus_open())
return;
Expand Down Expand Up @@ -1040,11 +1040,13 @@ void execute_discover_elements_cmd(int argc, char *argv[])
else
{
printf("No elements discovered!\r\n");
free(pElementNames);
}
}
else
{
printf ("Failed to discover elements. Error Code = %d\r\n", rc);
free(pElementNames);
}
}

Expand Down