Release 2.4.0 - #38
Closed
bunnam988 wants to merge 4 commits into
Closed
Conversation
Release 2.3.0 2.3.0
…36) Signed-off-by: DeepakRathn <deepak.rathn@gmail.com>
## Summary Adds a caller workflow that runs the shared PR format check from `rdkcentral/build_tools_workflows`. ## What it does Automatically checks every new/edited PR (including fork PRs) for: - Title format: `TICKET-123 : description` (multiple tickets supported) - Required description fields: Reason for change, Test Procedure, Risks, Priority Fails the check and posts a reminder comment if format is incorrect. Deletes the comment automatically when fixed. ## Files changed - `.github/workflows/pr-lint.yml` (9 lines — caller only, no logic)
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Contributor
There was a problem hiding this comment.
Pull request overview
Release 2.4.0 updates MoCA device reporting behavior and adds repository automation to enforce PR formatting, alongside the corresponding changelog entry.
Changes:
- Adjust MoCA associated-device enumeration and synchronization behavior in the TR-181 middle-layer code.
- Add a PR format check GitHub workflow (reusable workflow invocation).
- Update
CHANGELOG.mdwith the 2.4.0 release notes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
source/TR-181/middle_layer_src/cosa_moca_network_info.c |
Updates MoCA client counting and device status synchronization / notification payloads. |
CHANGELOG.md |
Adds the 2.4.0 section and links to included PRs/commits. |
.github/workflows/pr-lint.yml |
Introduces a PR lint workflow using a reusable workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
318
to
322
| #ifdef CISCO_MOCA_CPE | ||
| pnum_cpes = *pulCount ; //temporary work around to bypass connected client behind node implementation for CXB3 due to CISCOXB3-4969 | ||
| #else | ||
| pnum_cpes = *pulCount ; //fix solve incorrect moca client count | ||
| #endif |
Comment on lines
+833
to
+837
| else | ||
| { | ||
| Set_MoCADevices_Status_Offline(); | ||
| Send_Update_to_LMLite(FALSE); | ||
| } |
| cur->ssidType = NULL; | ||
| } | ||
| cur->ssidType = strdup("Device.MoCA.Interface.1."); | ||
| cur->ssidType = strdup(" "); |
| (NULL != cur->ssidType) ? cur->ssidType : "NULL", | ||
| (NULL != cur->parentMac) ? cur->parentMac : "NULL", | ||
| "Device.MoCA.Interface.1.", | ||
| " ", |
|
|
||
| jobs: | ||
| lint: | ||
| uses: rdkcentral/build_tools_workflows/.github/workflows/pr-lint.yml@develop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 2.4.0