RDKMVE-3024: [RPI4] Install Vulkan manifest file to GPU layer for DAC 2.0. - #382
Open
smuthu065 wants to merge 2 commits into
Open
RDKMVE-3024: [RPI4] Install Vulkan manifest file to GPU layer for DAC 2.0.#382smuthu065 wants to merge 2 commits into
smuthu065 wants to merge 2 commits into
Conversation
… 2.0. Reason for change: Install broadcom_icd.arm.json file to gpu-layer. Test Procedure: Build and verify. Risks: Low. Signed-off-by: sundaramuneeswaran_muthuraj@comcast.com
Contributor
There was a problem hiding this comment.
Pull request overview
Installs the Broadcom Vulkan ICD manifest into the gpu-layer bundled rootfs so Vulkan can be discovered/used from within the GPU layer for the RPI4 DAC 2.0 environment.
Changes:
- Conditionally installs
broadcom_icd.arm.jsoninto the gpu-layer Vulkan ICD directory whenDISTRO_FEATURESincludesvulkan.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (2)
recipes-graphics/gpu-layer/gpu-layer.bb:91
- The install step hardcodes the Broadcom Vulkan ICD manifest name as
broadcom_icd.arm.json. This makes the recipe brittle for other Raspberry Pi variants/architectures (the layer has araspberrypi4-64machine, e.g.recipes-kernel/android/android-raspberrypi.inc:20), where the staged ICD manifest filename may differ. Consider selecting the availablebroadcom_icd.*.jsonfrom the sysroot and installing it while preserving its basename.
if [ ! -e "${STAGING_DATADIR}/vulkan/icd.d/broadcom_icd.arm.json" ]; then
bbfatal "Vulkan enabled but Broadcom ICD manifest not found in sysroot: ${STAGING_DATADIR}/vulkan/icd.d/broadcom_icd.arm.json"
fi
install -m 0444 "${STAGING_DATADIR}/vulkan/icd.d/broadcom_icd.arm.json" "${VULKAN_ICD_LAYER_DIR}/broadcom_icd.arm.json"
recipes-graphics/gpu-layer/gpu-layer.bb:94
- There is trailing whitespace on the blank line after the Vulkan install block. Please remove the whitespace to avoid noisy diffs and style issues.
fi
# Install GPU configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Install broadcom_icd.arm.json file to gpu-layer.
Test Procedure: Build and verify.
Risks: Low.
Signed-off-by: sundaramuneeswaran_muthuraj@comcast.com