Skip to content

RDKMVE-3024: [RPI4] Install Vulkan manifest file to GPU layer for DAC 2.0. - #382

Open
smuthu065 wants to merge 2 commits into
developfrom
feature/RDKMVE-3024
Open

RDKMVE-3024: [RPI4] Install Vulkan manifest file to GPU layer for DAC 2.0.#382
smuthu065 wants to merge 2 commits into
developfrom
feature/RDKMVE-3024

Conversation

@smuthu065

Copy link
Copy Markdown
Contributor

Reason for change: Install broadcom_icd.arm.json file to gpu-layer.
Test Procedure: Build and verify.
Risks: Low.
Signed-off-by: sundaramuneeswaran_muthuraj@comcast.com

… 2.0.

Reason for change: Install broadcom_icd.arm.json file to gpu-layer.
Test Procedure: Build and verify.
Risks: Low.
Signed-off-by: sundaramuneeswaran_muthuraj@comcast.com
Copilot AI review requested due to automatic review settings August 5, 2026 09:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Installs the Broadcom Vulkan ICD manifest into the gpu-layer bundled rootfs so Vulkan can be discovered/used from within the GPU layer for the RPI4 DAC 2.0 environment.

Changes:

  • Conditionally installs broadcom_icd.arm.json into the gpu-layer Vulkan ICD directory when DISTRO_FEATURES includes vulkan.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread recipes-graphics/gpu-layer/gpu-layer.bb
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings August 5, 2026 09:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (2)

recipes-graphics/gpu-layer/gpu-layer.bb:91

  • The install step hardcodes the Broadcom Vulkan ICD manifest name as broadcom_icd.arm.json. This makes the recipe brittle for other Raspberry Pi variants/architectures (the layer has a raspberrypi4-64 machine, e.g. recipes-kernel/android/android-raspberrypi.inc:20), where the staged ICD manifest filename may differ. Consider selecting the available broadcom_icd.*.json from the sysroot and installing it while preserving its basename.
        if [ ! -e "${STAGING_DATADIR}/vulkan/icd.d/broadcom_icd.arm.json" ]; then
            bbfatal "Vulkan enabled but Broadcom ICD manifest not found in sysroot: ${STAGING_DATADIR}/vulkan/icd.d/broadcom_icd.arm.json"
        fi
        install -m 0444 "${STAGING_DATADIR}/vulkan/icd.d/broadcom_icd.arm.json" "${VULKAN_ICD_LAYER_DIR}/broadcom_icd.arm.json"

recipes-graphics/gpu-layer/gpu-layer.bb:94

  • There is trailing whitespace on the blank line after the Vulkan install block. Please remove the whitespace to avoid noisy diffs and style issues.
    fi
    
    # Install GPU configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants