Rebase to develop - #211
Conversation
|
|
|
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Pull request overview
This PR rebases changes to the develop branch, integrating multiple middleware component updates, new recipes, configuration changes, and infrastructure improvements across the RDK ecosystem.
Changes:
- Updated versions and SRCREVs for numerous middleware components (rbus, telemetry, bluetooth, dobby, systimemgr, rfc, etc.)
- Added new recipes for components like aker, paroduscl, network-hotplug, mustach, littlesheens, irtt, cpeabs, and others
- Introduced configuration changes for RDKB stack integration, systemd preferences, and layer dependencies
- Added GitHub workflow files for CLA, FOSSID scanning, and automated PR creation
Reviewed changes
Copilot reviewed 93 out of 93 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| setup-environment | Enhanced to support both openembedded-core and poky directory structures, added kirkstone distro support |
| rename_srcrev.sh | Removed several XRE-related SRCREV replacement lines |
| Multiple .bb recipe files | Added new recipes for various RDK components with version control and dependencies |
| conf/distro/ files | Updated RDKB and RDKV configurations, systemd preferences, security flags |
| GitHub workflows | Added automation for CLA, FOSSID scanning, and PR validation |
| CHANGELOG.md | Comprehensive changelog covering releases 1.4.0 through 1.14.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -28,6 +28,7 @@ | ||
| #include <glib-unix.h> | ||
| #include <libmanette/libmanette.h> | ||
| #include <linux/input.h> |
There was a problem hiding this comment.
The backtick character at the end of this include statement appears to be a typo. It should be removed as it will likely cause a compilation error.
| @@ -0,0 +1,51 @@ | |||
| SUMMARY = "This receipe compiles and builds aker." | |||
There was a problem hiding this comment.
Spelling error in SUMMARY field. The word "receipe" should be "recipe".
| @@ -0,0 +1,24 @@ | |||
| SUMMARY = "mustach" | |||
| DESCRIPTION = "A C library implementation of the mustache templating languge" | |||
There was a problem hiding this comment.
Spelling error in DESCRIPTION field. The word "languge" should be "language".
| @@ -0,0 +1 @@ | |||
| SUBSYSTEM=="net", KERNEL!="lo", ENV{SYSTEMD_WANTS}+="network@$name.service" ENV{SYSTEMD_ALIAS}="/$name" | |||
There was a problem hiding this comment.
Missing comma between environment variables. The ENV{SYSTEMD_WANTS} assignment should be separated from ENV{SYSTEMD_ALIAS} with a comma.
| SRC_URI = "git://github.com/Comcast/littlesheens.git;protocol=https;branch=master" | ||
| SRCREV = "${AUTOREV}" | ||
| PV := "${PV}+${SRCPV}" |
There was a problem hiding this comment.
The littlesheens recipe fetches build code from git://github.com/Comcast/littlesheens.git;branch=master with SRCREV = "${AUTOREV}", meaning every build pulls whatever is at the current branch head instead of an immutable commit. This creates a supply-chain risk where a compromised or hijacked upstream repository (or DNS/route to it) could inject malicious code that will be built and run with your build-time and device privileges. Pin this dependency to a specific trusted commit SHA or release tag (and avoid AUTOREV for production builds) so that only audited code is fetched and built.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 93 out of 93 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| CFLAGS:append:broadband += " ${@bb.utils.contains('DISTRO_FEATURES', 'bci', '', '-DFEATURE_SUPPORT_ONBOARD_LOGGING',d)}" | ||
|
|
||
| S = "${WORKDIR}/git" | ||
| CFLAGS:append += " ${@bb.utils.contains('DISTRO_FEATURES', 'bci', '', '-DFEATURE_SUPPORT_ONBOARD_LOGGING',d)}" | ||
| inherit pkgconfig cmake | ||
| EXTRA_OECMAKE += "-DRDK_LOGGER=ON -DBUILD_TESTING=OFF -DBUILD_YOCTO=true" | ||
| EXTRA_OECMAKE:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'bci', '', ' -DFEATURE_SUPPORT_ONBOARD_LOGGING=true',d)}" | ||
|
|
There was a problem hiding this comment.
The variable name has inconsistent spelling throughout the file. Lines 16-18 use "CFLAGS:append" for broadband, but line 28 uses "CFLAGS:append" without the broadband suffix, creating potential override conflicts. Additionally, line 21 removes an EXTRA_OECMAKE line that may still be needed for non-broadband builds.
| fi | ||
|
|
||
| OE_CORE_LAYER="openembedded-core" | ||
| if [ -d "poky" ];then |
There was a problem hiding this comment.
Missing space after semicolon in the if statement condition. For shell scripts, it's best practice to include a space after the semicolon for readability.
| SYSTEMD_AUTO_ENABLE:${PN} = "enable" | ||
| SYSTEMD_SERVICE:${PN} = " dsm.service " |
There was a problem hiding this comment.
The SYSTEMD_SERVICE configuration has duplicate entries. Line 34 sets "SYSTEMD_AUTO_ENABLE:${PN} = enable" and line 35 sets "SYSTEMD_SERVICE:${PN} = dsm.service", which are then duplicated on lines 24-25. The duplicate lines 34-35 should be removed.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 93 out of 93 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,96 @@ | |||
| Date: Fri, Aug 30 20:30:21 2024 +0000 | |||
There was a problem hiding this comment.
The date "Fri, Aug 30 20:30:21 2024" is in the past but the patch context suggests this is part of a future merge (2025). Please verify the date is correct or update it to reflect the actual date of the change.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 93 out of 93 changed files in this pull request and generated 30 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| CFLAGS:append:broadband += " ${@bb.utils.contains('DISTRO_FEATURES', 'bci', '', '-DFEATURE_SUPPORT_ONBOARD_LOGGING',d)}" | ||
|
|
||
| S = "${WORKDIR}/git" | ||
| CFLAGS:append += " ${@bb.utils.contains('DISTRO_FEATURES', 'bci', '', '-DFEATURE_SUPPORT_ONBOARD_LOGGING',d)}" | ||
| inherit pkgconfig cmake | ||
| EXTRA_OECMAKE += "-DRDK_LOGGER=ON -DBUILD_TESTING=OFF -DBUILD_YOCTO=true" |
There was a problem hiding this comment.
The cimplog recipe has moved the CFLAGS:append line from after the 'S =' assignment to before it. While this should work, the EXTRA_OECMAKE line that was after the moved CFLAGS has been removed. The removed line was 'EXTRA_OECMAKE:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'bci', '', ' -DFEATURE_SUPPORT_ONBOARD_LOGGING=true',d)}"'. Verify that this CMake flag is no longer needed or is set elsewhere, as removing it could disable onboard logging support.
| sed -z 's/"name": "gwfailover",\n[[:blank:]]*"bitposition": 1,\n[[:blank:]]*"support": true,/"name": "gwfailover",\n"bitposition": 1,\n"support": false,/g' ${WORKDIR}/webconfig_broadband_metadata.json > ${WORKDIR}/out.txt | ||
| mv ${WORKDIR}/out.txt ${WORKDIR}/webconfig_broadband_metadata.json | ||
| fi | ||
| install -d ${D}/usr/ccsp/webconfig | ||
| install -d ${D}/etc | ||
| touch ${D}/etc/WEBCONFIG_ENABLE | ||
| (${PYTHON} ${WORKDIR}/metadata_parser.py ${WORKDIR}/webconfig_metadata.json ${D}/etc/webconfig.properties ${MACHINE}) | ||
| (${PYTHON} ${WORKDIR}/metadata_parser.py ${WORKDIR}/webconfig_broadband_metadata.json ${D}/etc/webconfig.properties ${MACHINE}) |
There was a problem hiding this comment.
Line 71 and 72 both reference the same file 'webconfig_metadata.json' but line 71 changes it to 'webconfig_broadband_metadata.json' while line 77 also makes the same change. However, the original lines show different patterns - one has the filename used in sed command and the other in the metadata_parser.py invocation. Verify that both occurrences should use 'webconfig_broadband_metadata.json' and that this file exists, as this could cause build or runtime failures if the file is missing.
| # add BBMASK .= "!<pattern>" | ||
| # in your layer | ||
| BBMASK =. "recipes-gnome/gnome-settings-daemon" | ||
| BBMASK .= "|.meta-rdk-oss-reference/recipes-rdk/breakpad_wrapper/breakpad-wrapper.bb" |
There was a problem hiding this comment.
Line 25 adds a BBMASK pattern to mask out the breakpad-wrapper recipe from meta-rdk-oss-reference. This means if that layer has a breakpad-wrapper.bb file, it will be ignored. However, this PR also adds a recipes-common/breakpad_wrapper/breakpad-wrapper.bb file. Verify that there's no conflict and that the correct version of breakpad-wrapper is being used.
| ExecStartPre=/bin/sh -c '/bin/mkdir -p ${DUMPSDIR_TEMP}; /bin/chmod -R 777 ${DUMPSDIR_TEMP}' | ||
| ExecStartPre=/usr/bin/find ${DUMPSDIR_TEMP} -mindepth 1 -exec rm {} \; | ||
| ExecStart=/usr/bin/memcr -d "${DUMPSDIR_PERSIST};${DUMPSDIR_TEMP}" -N -l ${LOCATOR} -f -z -e -t ${TIMEOUT} | ||
| ExecStart=/usr/bin/memcr -d "${DUMPSDIR_PERSIST};${DUMPSDIR_TEMP}" -N -l ${LOCATOR} -c -f -z -e -t ${TIMEOUT} |
There was a problem hiding this comment.
The '-c' flag is added to the memcr ExecStart command without explanation. According to the context, this enables checksum functionality. Enabling checksums will add CPU overhead and may impact performance. This change should be documented and verified that systems can handle the additional processing requirements.
| DISTRO_FEATURES_RDK ?= "rdk-dlna" | ||
|
|
||
| DISTRO_FEATURES = "alsa argp logbacktrace directfb ext2 ipv4 ipv6 largefile multiarch nfs opengl pam systemd usbhost wayland xattr zeroconf directfb wayland pam opencdm ${DISTRO_FEATURES_LIBC} ${DISTRO_FEATURES_RDK}" | ||
| DISTRO_FEATURES = "alsa argp logbacktrace directfb ext2 ipv4 ipv6 largefile multiarch nfs opengl pam systemd usbhost wayland xattr zeroconf directfb wayland pam opencdm ${DISTRO_FEATURES_RDK}" |
There was a problem hiding this comment.
Line 67 in rdk.conf removes '${DISTRO_FEATURES_LIBC}' from the DISTRO_FEATURES definition. This variable typically includes libc-specific features. Removing it could cause issues with recipes that depend on specific libc features being declared in DISTRO_FEATURES. Verify that this removal is intentional and won't break libc-dependent functionality.
| DISTRO_FEATURES = "alsa argp logbacktrace directfb ext2 ipv4 ipv6 largefile multiarch nfs opengl pam systemd usbhost wayland xattr zeroconf directfb wayland pam opencdm ${DISTRO_FEATURES_RDK}" | |
| DISTRO_FEATURES = "alsa argp logbacktrace directfb ext2 ipv4 ipv6 largefile multiarch nfs opengl pam systemd usbhost wayland xattr zeroconf directfb wayland pam opencdm ${DISTRO_FEATURES_LIBC} ${DISTRO_FEATURES_RDK}" |
| inherit pkgconfig autotools systemd ${@bb.utils.contains("DISTRO_FEATURES", "kirkstone", "python3native", "pythonnative", d)} breakpad-logmapper | ||
|
|
||
| CFLAGS += " -DDROP_ROOT_PRIV " | ||
| CFLAGS += " -DDROP_ROOT_PRIV -DENABLE_MTLS " |
There was a problem hiding this comment.
Line 30 changes CFLAGS from adding '-DDROP_ROOT_PRIV' to adding '-DDROP_ROOT_PRIV -DENABLE_MTLS'. Adding ENABLE_MTLS flag enables mutual TLS authentication. Verify that the code supports this flag and that enabling MTLS by default won't break existing configurations that don't have MTLS certificates configured.
| DEPENDS:append:broadband += " rbus" | ||
| export rbus_CFLAGS = "-I$(PKG_CONFIG_SYSROOT_DIR)${includedir}/rbus" | ||
| export rbus_LIBS = "-lrbus" | ||
|
|
||
| EXTRA_OEMAKE += "-e MAKEFLAGS=" | ||
| EXTRA_OECONF:append = " --enable-iarmbus=yes --enable-tr69hostif=yes" | ||
| EXTRA_OECONF:append:client = " --enable-iarmbus=yes --enable-tr69hostif=yes" | ||
| EXTRA_OECONF:append:broadband = " --enable-rdkb=yes --enable-tr181set=yes" |
There was a problem hiding this comment.
Line 28 adds 'DEPENDS:append:broadband += " rbus"' which changes rbus from being included conditionally to being a hard dependency for broadband builds. Line 27 previously had EXTRA_OECONF only for :client. Verify that broadband builds can satisfy the rbus dependency and that this doesn't break builds.
| SRCREV_ecfsgeneric= "822d726d14e575ec9c73198ce939733abd0d365b" | ||
| SRCREV:pn-remotedebugger = "300d29e105f6a7244bff81fa0357dac914dd8913" | ||
| SRCREV_sshkeys = "3a1c7d6a07586117bd992fe72ae3365fdd7ef2f3" | ||
| SRCREV_mount-utils = "c1aeb29c8e1f236babdd6a1a4538c5b451c7b8c1" |
There was a problem hiding this comment.
The rdkb.inc file adds many new BBMASKs (lines 159-177) and introduces a new MIDDLEWARE_ARCH override (line 186). More importantly, it adds numerous SRCREV overrides for specific packages (lines 195-213). Setting SRCREV for multiple packages to specific values could cause issues if these packages need to be updated independently. This centralized version pinning should be carefully managed to avoid blocking necessary updates.
| SRCREV_mount-utils = "c1aeb29c8e1f236babdd6a1a4538c5b451c7b8c1" | |
| SRCREV:pn-mount-utils ?= "c1aeb29c8e1f236babdd6a1a4538c5b451c7b8c1" |
| @@ -28,6 +28,7 @@ | ||
| #include <glib-unix.h> | ||
| #include <libmanette/libmanette.h> | ||
| #include <linux/input.h> |
There was a problem hiding this comment.
Missing space after #include directive. Line 18 shows '#include <dlfcn.h>`' with a backtick at the end instead of proper quote/angle bracket. This should be '#include <dlfcn.h>' without the backtick.
| DEPENDS = "cjson rdk-logger trower-base64 msgpack-c webconfig-framework rbus libsyswrapper" | ||
| DEPENDS:append:client = " iarmbus iarmmgrs" |
There was a problem hiding this comment.
The DEPENDS line removes 'iarmbus iarmmgrs' for all configurations and only adds them back for ':client' override. This could break builds that previously had these dependencies. Verify that all non-client configurations don't need these dependencies, or if this is a breaking change that needs to be documented.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 93 out of 93 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| # Clean PATH of any previous oe-core bitbake or scripts directories | ||
| export PATH="$(echo $PATH | sed 's!/[^:]\+/openembedded-core/\(bitbake/bin\|scripts\):!!g')" | ||
| export PATH="$(echo $PATH | sed 's!/[^:]\+/$OE_CORE_LAYER/\(bitbake/bin\|scripts\):!!g')" |
There was a problem hiding this comment.
The variable OE_CORE_LAYER is used inside single quotes in the sed pattern, which prevents variable expansion. The sed pattern 's!/[^:]+/$OE_CORE_LAYER/(bitbake/bin|scripts):!!g' will look for the literal string "$OE_CORE_LAYER" instead of its value. This should use double quotes or the variable should be concatenated outside the sed pattern to allow proper variable expansion.
| #include <glib-unix.h> | ||
| #include <libmanette/libmanette.h> | ||
| #include <linux/input.h> | ||
| +#include <dlfcn.h>` |
There was a problem hiding this comment.
There is an extra backtick () at the end of the line "#include <dlfcn.h>". This appears to be a formatting error in the patch file. While patch files often have their own formatting, this trailing backtick looks like a mistake from copying or formatting the diff.
| @@ -0,0 +1,24 @@ | |||
| SUMMARY = "mustach" | |||
| DESCRIPTION = "A C library implementation of the mustache templating languge" | |||
There was a problem hiding this comment.
Spelling error: "languge" should be "language".
| @@ -0,0 +1 @@ | |||
| SUBSYSTEM=="net", KERNEL!="lo", ENV{SYSTEMD_WANTS}+="network@$name.service" ENV{SYSTEMD_ALIAS}="/$name" | |||
There was a problem hiding this comment.
Missing comma between ENV{SYSTEMD_WANTS} and ENV{SYSTEMD_ALIAS}. In udev rules syntax, multiple assignments should be separated by commas. This line should have a comma after the closing quote of "network@$name.service".
| @@ -0,0 +1,51 @@ | |||
| SUMMARY = "This receipe compiles and builds aker." | |||
There was a problem hiding this comment.
Spelling error: "receipe" should be "recipe".
|
|
||
|
|
||
| # Add any extra packaging if needed | ||
| FILES_${PN} += "${bindir}/logupload" |
There was a problem hiding this comment.
The variable syntax FILES_${PN} is deprecated in newer Yocto versions. It should be updated to use the modern syntax FILES:${PN} with a colon instead of an underscore. This is consistent with other variable overrides shown elsewhere in the recipe (e.g., CFLAGS:append, LDFLAGS:append on nearby lines).
| FILES_${PN} += "${bindir}/logupload" | |
| FILES:${PN} += "${bindir}/logupload" |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 93 out of 93 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,51 @@ | |||
| SUMMARY = "This receipe compiles and builds aker." | |||
There was a problem hiding this comment.
The spelling "receipe" in the SUMMARY should be corrected to "recipe". This is a common misspelling.
| @@ -1,48 +1,29 @@ | |||
| SUMMARY = "This receipe compiles rmfcore code base. This has interface clasess that would be necessary for all the mediaplayers" | |||
| SUMMARY = "This recipe builds the rdk_logger code base, providing logging interfaces required by all mediaplayers" | |||
There was a problem hiding this comment.
The spelling "receipe" in the SUMMARY should be corrected to "recipe".
| # Warning: Sourcing the oe-init-build-env script changes the current directory. | ||
|
|
||
| TEMPLATECONF=${_PWD_PREV}/meta-rdk/conf source openembedded-core/oe-init-build-env ${_BUILDDIR} | ||
| TEMPLATECONF=${_PWD_PREV}/meta-rdk/conf source $OE_CORE_LAYER/oe-init-build-env ${_BUILDDIR} |
There was a problem hiding this comment.
The variable substitution in this sed command will not work correctly because shell variables are not expanded within single quotes. The $OE_CORE_LAYER variable will be treated as a literal string instead of being substituted with its value. This should use double quotes or concatenation to ensure proper variable expansion.
| # ie bitbake version 1.28 needs to map to "daisy", not "jethro". | ||
|
|
||
| case "$(sed -n 's/^__version__ = "\(.*\)"/\1/p' ${_PWD_PREV}/openembedded-core/bitbake/bin/bitbake)" | ||
| case "$(sed -n 's/^__version__ = "\(.*\)"/\1/p' ${_PWD_PREV}/$OE_CORE_LAYER/bitbake/bin/bitbake)" |
There was a problem hiding this comment.
The variable substitution in this sed command will not work correctly because shell variables are not expanded within single quotes. The $OE_CORE_LAYER variable will be treated as a literal string. This should use double quotes or concatenation to ensure proper variable expansion.
| After=tr69hostif.service | ||
|
|
||
| [Service] | ||
| ExecStartPre=/bin/sh -c 'RESULT=$(/usr/bin/tr181 Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.xMemInsight.Args 2>&1 || echo "") && echo "ARGS=$RESULT" > /tmp/meminsight.env' |
There was a problem hiding this comment.
The ExecStartPre script writes an environment file line as ARGS=$RESULT using the raw output of /usr/bin/tr181 Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.xMemInsight.Args, with no sanitization of the TR-181 value. If an attacker can control this TR-181 parameter and include characters like newlines and =, they can craft a value such as "arg1\nLD_PRELOAD=/path/lib.so" so that /tmp/meminsight.env contains additional environment variable assignments (e.g. LD_PRELOAD) that are then loaded when meminsight-runner.service starts, enabling arbitrary code execution as root. To mitigate this, restrict xMemInsight.Args to a safe character set and a single line (reject or escape newlines and =), or encode it (e.g. base64) and decode safely in the service instead of writing it directly into an environment file.
| ExecStartPre=/bin/sh -c 'RESULT=$(/usr/bin/tr181 Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.xMemInsight.Args 2>&1 || echo "") && echo "ARGS=$RESULT" > /tmp/meminsight.env' | |
| ExecStartPre=/bin/sh -c 'RAW=$(/usr/bin/tr181 Device.DeviceInfo.X_RDKCENTRAL-COM_RFC.Feature.xMemInsight.Args 2>&1 || echo ""); SAFE=$(printf "%s" "$RAW" | tr -d "\n\r="); echo "ARGS=$SAFE" > /tmp/meminsight.env' |
| EnvironmentFile=-/tmp/meminsight.env | ||
| ExecStart=/usr/bin/xmeminsight $ARGS | ||
| ExecStop=-/bin/rm /tmp/meminsight.env |
There was a problem hiding this comment.
The service uses an EnvironmentFile located in /tmp (/tmp/meminsight.env), which is a world-writable directory, while a root ExecStartPre script (in client.conf) writes to the same path using a simple shell redirection. A local unprivileged user can pre-create /tmp/meminsight.env as a symlink to an arbitrary root-owned file (e.g. /etc/shadow, a systemd unit, or an SSH config), and when this service is started the redirection will follow the symlink and overwrite that target, enabling local privilege escalation or integrity compromise. To fix this, store the environment file under a root-owned, non-world-writable directory (e.g. /run/meminsight/), and if you must write in a shared directory, open the file with symlink-safe semantics (no following of existing symlinks) instead of a plain shell > redirection.
| EnvironmentFile=-/tmp/meminsight.env | |
| ExecStart=/usr/bin/xmeminsight $ARGS | |
| ExecStop=-/bin/rm /tmp/meminsight.env | |
| RuntimeDirectory=meminsight | |
| RuntimeDirectoryMode=0750 | |
| EnvironmentFile=-/run/meminsight/meminsight.env | |
| ExecStart=/usr/bin/xmeminsight $ARGS | |
| ExecStop=-/bin/rm /run/meminsight/meminsight.env |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 93 out of 93 changed files in this pull request and generated 14 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| PV = "1.0.0" | ||
| PR = "r0" | ||
| PACKAGE_ARCH = "${MIDDLEWARE_ARCH}" | ||
|
|
||
| PKG_VERSION = "0.5.15" | ||
|
|
||
| SRC_URI = "https://github.com/xmidt-org/xmidt-agent/releases/download/v${PKG_VERSION}/xmidt-agent_${PKG_VERSION}_rdk_armv7.ipk;name=xmidt-agent" |
There was a problem hiding this comment.
PV is set to 1.0.0 but the recipe actually installs the 0.5.15 ipk from PKG_VERSION. This creates a versioning mismatch in package feeds and makes upgrades/downgrades confusing. Consider setting PV = "${PKG_VERSION}" (or otherwise aligning PV with the artifact being fetched).
| EXTRA_OECONF:append:client = " --enable-iarmbus=yes --enable-tr69hostif=yes" | ||
| EXTRA_OECONF:append:broadband = " --enable-rdkb=yes --enable-tr181set=yes" | ||
| EXTRA_OEMAKE += "LIBS='-lsafec'" | ||
|
|
||
| DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}" | ||
| CFLAGS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' `pkg-config --cflags libsafec`', '-fPIC', d)}" | ||
| CFLAGS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', '', ' -DSAFEC_DUMMY_API', d)}" |
There was a problem hiding this comment.
Two issues here: (1) the bb.utils.contains(...) expression has an unescaped " " inside a BitBake double-quoted assignment, which will cause a parse error; use ' '/'' instead. (2) EXTRA_OEMAKE += "LIBS='-lsafec'" forces linking against safec even when DISTRO_FEATURES doesn’t enable it, which can break non-safec builds—make this conditional on the safec feature.
|
|
||
| DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}" | ||
| CFLAGS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' `pkg-config --cflags libsafec`', '-fPIC', d)}" |
There was a problem hiding this comment.
This line has mismatched quoting inside the python expression (' safec', " ", d), which will cause a BitBake parse error. Replace the inner " " with a properly quoted Python/BitBake string (e.g. ' ' or '') so the bb.utils.contains(...) call is syntactically valid.
| #include <linux/input.h> | ||
| +#include <dlfcn.h>` | ||
|
|
There was a problem hiding this comment.
There is a stray trailing backtick after the include directive (#include <dlfcn.h>), which will cause the patched C++ source to fail to compile. Remove the extra character.
| SRC_URI = " \ | ||
| file://network@.service \ | ||
| file://network.rules \ | ||
| file://lan-iface@.service \ | ||
| " |
There was a problem hiding this comment.
recipes-support/network-hotplug/files/udhcpc@.service is added in this PR but is not included in SRC_URI, so it won’t be present in ${WORKDIR} and won’t be installed by the ${WORKDIR}/*.service glob. If this unit is required at runtime, add it to SRC_URI (or remove the unused file).
| DEPENDS = "dbus ${BLUEZ} rdk-logger" | ||
| DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}" | ||
| DEPENDS:append = "${@bb.utils.contains('DISTRO_FEATURES', 'gdbus_bluez5', 'glib-2.0-native', '', d)}" |
There was a problem hiding this comment.
This bb.utils.contains(...) call includes an unescaped " " inside a BitBake double-quoted string, which will break parsing. Replace the " " argument with a properly quoted string (e.g. ' ' or '').
| #Disable USB KeyBoard and Mouse based on RFC parameter | ||
| ACTION=="add", SUBSYSTEM=="input", SUBSYSTEMS=="usb", ENV{ID_BUS}=="usb", ATTRS{authorized}=="1", TAG+="systemd", ENV{SYSTEMD_WANTS}+="usb-input@$id.service" |
There was a problem hiding this comment.
This file is added but is not referenced by any SRC_URI (so it will never be installed into the image as part of network-hotplug). Also, it requests usb-input@$id.service, but there is no corresponding usb-input@.service unit shipped in the layer. Either add the missing systemd template unit and include this rule via SRC_URI, or drop the unused rule file.
| SYSTEMD_AUTO_ENABLE:${PN} = "enable" | ||
| SYSTEMD_SERVICE:${PN} = "dsm.service" | ||
|
|
||
| FILES:${PN} += " ${systemd_unitdir}/system/dsm.service \ | ||
| ${sysconfdir}/dsm.config \ | ||
| /home/root/destination " | ||
|
|
||
| OECMAKE_CXX_FLAGS += " -I${STAGING_INCDIR}/rbus " | ||
| OECMAKE_CXX_FLAGS += "-I${STAGING_INCDIR}" | ||
|
|
||
| SYSTEMD_AUTO_ENABLE:${PN} = "enable" | ||
| SYSTEMD_SERVICE:${PN} = " dsm.service " | ||
|
|
There was a problem hiding this comment.
SYSTEMD_SERVICE:${PN} = " dsm.service " includes leading/trailing spaces, which can result in an invalid/ignored unit name when enabling via systemd.bbclass. Also SYSTEMD_AUTO_ENABLE/SYSTEMD_SERVICE are defined twice; keep a single, correctly formatted assignment.
| EXTRA_OEMAKE += "LIBS='-lsafec'" | ||
|
|
||
| DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}" |
There was a problem hiding this comment.
EXTRA_OEMAKE += "LIBS='-lsafec'" unconditionally forces linking against safec. When DISTRO_FEATURES does not include safec, this can break builds (missing -lsafec). Make the LIBS addition conditional on the same safec feature (or move it into LDFLAGS/CFLAGS conditionals).
| name: PR Title Validation | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [develop] | ||
| types: [opened, edited, synchronize] |
There was a problem hiding this comment.
This workflow will fail any PR whose title doesn't start with a ticket prefix (e.g. this PR title is "Rebase to develop"). If rebases/chore PRs are expected, add an explicit allowlist (e.g., allow Rebase/chore: prefixes, or allow bypass via label/actor), otherwise this will block required maintenance PRs.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 100 out of 100 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (16)
recipes-support/rdmagent/rdmagent.bb:53
- This BitBake python expression breaks parsing because the string contains an unescaped double-quoted " ", which terminates the outer value early. Use an empty string '' (or ' ') for the false case instead.
recipes-connectivity/bluetooth/bluetooth-core_git.bb:10 - This BitBake python expression breaks parsing because the string contains an unescaped double-quoted " ", which terminates the outer value early. Use an empty string '' (or ' ') for the false case instead.
recipes-common/utils/commonutilities_git.bb:19 - This BitBake python expression breaks parsing because the string contains an unescaped double-quoted " ", which terminates the outer value early. Use an empty string '' (or ' ') for the false case instead.
recipes-common/rfc/rfc_git.bb:31 - This BitBake python expression breaks parsing because the string contains an unescaped double-quoted " ", which terminates the outer value early. Use an empty string '' (or ' ') for the false case instead.
DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}"
recipes-common/rdk-logger/rdk-logger_git.bb:15
- This BitBake python expression breaks parsing because the string contains an unescaped double-quoted " ", which terminates the outer value early. Use an empty string '' (or ' ') for the false case instead.
DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}"
recipes-extended/wpe-backend-rdk/files/comcast-manette-gamepad-digital-trigger-fix.patch:20
- There is an extra trailing backtick after the dlfcn include, which will cause this patch to apply code that does not compile.
recipes-support/network-hotplug/files/network.rules:1 - This udev rule is missing a comma between the two ENV assignments, which makes the rule syntactically invalid.
recipes-support/network-hotplug/files/lan-iface@.service:12 - The [Install] section uses Alias with a filesystem path. systemd's Alias= expects an alternative unit name (e.g., foo.service), not a target.wants path, so enabling this unit will not work as intended.
recipes-support/network-hotplug/network-hotplug_1.0.bb:9 - New files usb-input.rules and udhcpc@.service are added in this PR, but they are not referenced by SRC_URI and usb-input.rules is not installed, so they will never ship in the package.
recipes-containers/dsm/files/dsm.config:34 - ExecutionEnvironments contains duplicate "id": 2 (for both "test" and "user"). If IDs are used as unique keys, this will cause collisions at runtime.
recipes-devtools/memcapture/memcapture_git.bb:32 - Installing MemCapture with mode 4755 sets the setuid bit, meaning it will run as root for all users. This is a high-risk security default unless strictly required and audited (prefer capabilities or a dedicated service).
recipes-support/network-hotplug/files/usb-input.rules:2 - This rule uses "$id" as if it were a udev substitution variable, but udev substitutions are typically %k/%p/%E{VAR}, etc. As written, the service instance name will likely contain a literal "$id" and not match an actual unit instance.
recipes-support/network-hotplug/files/usb-ethernet.rules:2 - This rule uses "$id" in the sysfs path written by RUN+=, but $id is not a standard udev substitution and will likely be empty/unset in the shell. The write to /sys/bus/usb/devices/$id/authorized would then fail or target the wrong path.
setup-environment:61 - The sed expression is single-quoted, so $OE_CORE_LAYER is not expanded. This makes the PATH cleanup ineffective (it will look for a literal "$OE_CORE_LAYER" directory name).
recipes-common/breakpad_wrapper/breakpad-wrapper.bb:7 - SRC_URI uses ${CMF_GITHUB_BRANCH} but omits the protocol portion used elsewhere (${CMF_GITHUB_SRC_URI_SUFFIX}). This makes the fetch rely on the default git:// protocol, which may be blocked in some environments and is inconsistent with other recipes in this layer.
SRC_URI = "${CMF_GITHUB_ROOT}/breakpad_wrapper;${CMF_GITHUB_BRANCH};name=breakpadwrapper"
recipes-containers/dsm/dsm.bb:36
- SYSTEMD_AUTO_ENABLE and SYSTEMD_SERVICE are set twice. The second assignment (with extra whitespace) is redundant and can cause confusion about the effective value.
…0933 RDKEMW-22213: Revert "RDKEMW-20933: RDM goes for infinite download loop on return code is non-zero"
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 100 out of 100 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (14)
setup-environment:61
- The sed expression is single-quoted, so $OE_CORE_LAYER is not expanded. This prevents PATH cleanup from removing prior bitbake/scripts entries when OE core is in poky vs openembedded-core.
recipes-support/rdmagent/rdmagent.bb:53 - This bb.utils.contains() call has broken quoting (" " inside a double-quoted string), which will cause a BitBake parse error.
recipes-support/network-hotplug/files/network.rules:1 - Udev rules require assignments to be comma-separated. Missing a comma between ENV{SYSTEMD_WANTS} and ENV{SYSTEMD_ALIAS} will make the rule invalid.
recipes-support/network-hotplug/files/udhcpc@.service:12 - Systemd specifier expansion requires a space: '-i%i' will pass a literal interface name like 'eth0' concatenated to -i, which udhcpc won't parse as intended.
recipes-support/network-hotplug/files/lan-iface@.service:12 - Alias= expects unit names, not symlink paths under *.wants/. Using 'Alias=multi-user.target.wants/…' is invalid and won't enable the unit at boot.
recipes-support/network-hotplug/files/usb-input.rules:2 - $id is not a valid udev substitution, so the instance name will not expand and the requested systemd unit will not be started. Use a supported substitution (e.g. %k / %p / %E{...}) for the template instance.
recipes-support/network-hotplug/files/usb-ethernet.rules:2 - The RUN command writes to /sys/.../$id/authorized, but $id is not a valid udev substitution, so this will write to a non-existent path and fail to disable the device.
recipes-extended/wpe-backend-rdk/files/comcast-manette-gamepad-digital-trigger-fix.patch:19 - The patch introduces a stray backtick at the end of the #include line, which will break compilation of the patched source.
recipes-support/mustach/mustach_1.2.2.bb:2 - Typo in DESCRIPTION: 'languge' -> 'language'.
recipes-devtools/memcapture/memcapture_git.bb:31 - This installs MemCapture as a setuid-root binary (mode 4755). Introducing SUID binaries significantly expands the attack surface; prefer running with least privilege (capabilities via setcap, or a dedicated systemd service) unless SUID is strictly required.
recipes-containers/dsm/files/dsm.config:33 - Two ExecutionEnvironments entries use the same "id": 2 ("test" and "user"). IDs should be unique to avoid controller ambiguity.
recipes-containers/dsm/dsm.bb:35 - SYSTEMD_AUTO_ENABLE and SYSTEMD_SERVICE are set twice. The second assignment also adds extra whitespace around the service name, which can be error-prone and makes the recipe harder to maintain.
recipes-support/xmidt-agent/xmidt-agent_git.bb:5 - PV is set to 1.0.0, but the downloaded artifact version is PKG_VERSION (0.5.15). Keeping PV aligned with the packaged version avoids confusing package feeds and upgrade behavior.
recipes-common/dcmd/dcmd.bb:66 - Uses legacy FILES_${PN} syntax; in this layer most overrides use the modern ':' form (e.g. FILES:${PN}). Keeping FILES_${PN} likely won't affect packaging as intended on newer BitBake, so the logupload binary may be omitted from the package.
FILES_${PN} += "${bindir}/logupload"
RDKEMW-22307: Revert "RDKEMW-19574: App Managers 0.7.0.0 Release Integration"
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 100 out of 100 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (12)
setup-environment:61
- The sed expression is single-quoted, so $OE_CORE_LAYER will not expand and PATH cleanup won’t remove previous bitbake/scripts entries from the selected core layer.
recipes-support/xmidt-agent/xmidt-agent_git.bb:6 - PV is set to 1.0.0 while the fetched artifact is version ${PKG_VERSION} (0.5.15). This makes the recipe/package version misleading and can interfere with upgrade/downgrade semantics.
recipes-support/network-hotplug/files/network.rules:1 - This udev rule is missing a comma between assignments, which makes the rule invalid. Also, $name isn’t a standard udev substitution token; %k is the usual way to reference the interface name.
recipes-support/network-hotplug/files/usb-input.rules:2 - $id is not a udev substitution token, so the instance name will not be expanded as intended. Use a udev specifier such as %k (kernel name) for a stable instance identifier.
recipes-support/network-hotplug/files/usb-ethernet.rules:2 - This rule references $id in the sysfs path, but $id is not a udev substitution token. As written, the RUN command will likely echo to a literal "$id" path instead of the actual device. The correct sysfs node depends on which identifier you intend to use (USB device vs. net interface).
recipes-support/network-hotplug/network-hotplug_1.0.bb:9 -
udhcpc@.service exists under this recipe’s files/ directory but is not listed in SRC_URI, so it won’t be staged into WORKDIR and therefore won’t be installed by the existing '*.service' install logic.
recipes-support/mustach/mustach_1.2.2.bb:2 - Typo in DESCRIPTION: “languge” → “language”.
recipes-extended/wpe-backend-rdk/files/comcast-manette-gamepad-digital-trigger-fix.patch:20 - There is a stray backtick at the end of the include line, which will break compilation when this patch is applied.
recipes-containers/dsm/files/dsm.config:33 - ExecutionEnvironments entries "test" and "user" both use id=2. If ids are used as unique keys, this will cause collisions/mis-routing.
recipes-containers/dsm/dsm.bb:36 - SYSTEMD_SERVICE is assigned twice; the second assignment includes extra spaces (" dsm.service ") which can result in systemd.bbclass not enabling/packaging the intended unit name. Keep a single canonical value without leading/trailing whitespace.
recipes-common/breakpad_wrapper/breakpad-wrapper.bb:6 - SRC_URI uses ${CMF_GITHUB_BRANCH} but omits the protocol parameter (unlike other recipes using ${CMF_GITHUB_SRC_URI_SUFFIX}). This can force the git:// transport and break in environments where it’s blocked. Use the standard CMF_GITHUB_SRC_URI_SUFFIX for consistency.
SRC_URI = "${CMF_GITHUB_ROOT}/breakpad_wrapper;${CMF_GITHUB_BRANCH};name=breakpadwrapper"
recipes-devtools/memcapture/memcapture_git.bb:32
- Installing MemCapture as setuid-root (mode 4755) is a high-risk security posture. If elevated privileges are required, prefer a dedicated systemd service/capabilities instead; otherwise install as 0755.
| FILESEXTRAPATHS:prepend := "${THISDIR}/files:" | ||
|
|
||
| SRC_URI += "file://usb-ethernet.rules" | ||
|
|
||
| do_install:append() { | ||
| install -d ${D}${sysconfdir}/udev/rules.d | ||
| install -m 0644 ${WORKDIR}/usb-ethernet.rules ${D}${sysconfdir}/udev/rules.d/usb-ethernet.rules | ||
| } |
This reverts commit a37c38e.
RDKEMW-18318: Update memcapture_git.bb recipe with latest SRCREV from develop
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 100 out of 100 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (14)
setup-environment:61
- The sed expression is single-quoted, so
$OE_CORE_LAYERwill not expand and PATH cleanup will not remove previous bitbake/scripts paths when using thepokylayout.
recipes-common/utils/commonutilities_git.bb:19 - This line has unescaped nested double-quotes (
" ") inside a double-quoted BitBake string, which will break parsing of the recipe.
recipes-support/rdmagent/rdmagent.bb:53 - This line has unescaped nested double-quotes (
" ") inside a double-quoted BitBake string, which will break parsing of the recipe.
recipes-connectivity/bluetooth/bluetooth-core_git.bb:9 - This line has unescaped nested double-quotes (
" ") inside a double-quoted BitBake string, which will break parsing of the recipe.
recipes-common/rfc/rfc_git.bb:31 - This line has unescaped nested double-quotes (
" ") inside a double-quoted BitBake string, which will break parsing of the recipe.
DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}"
recipes-support/network-hotplug/files/network.rules:1
- This udev rule is missing a comma between assignments and uses
$name, which is not a udev substitution token. As written, the rule is likely to be rejected or to generate an invalid systemd unit name.
recipes-support/network-hotplug/files/usb-input.rules:2 - This rule references
usb-input@$id.service, but$idis not a valid udev substitution and there is nousb-input@.serviceunit in this repo. The rule will not start anything unless the unit is provided elsewhere.
recipes-support/network-hotplug/files/usb-ethernet.rules:2 - This rule depends on
/lib/rdk/disableUSBEthernet.sh, but that script does not exist in this repo. It also uses$idin the sysfs path, which is not a valid udev substitution token, so the RUN command likely writes to a non-existent path.
recipes-containers/dsm/files/dsm.config:33 - Two execution environments use the same
idvalue (2). IDs should be unique; otherwise DSM may misidentify or overwrite EE entries at runtime.
recipes-extended/wpe-backend-rdk/files/comcast-manette-gamepad-digital-trigger-fix.patch:20 - There is a stray backtick at the end of the
#include <dlfcn.h>line in the patch, which will make the patched source fail to compile.
recipes-devtools/memcapture/memcapture_git.bb:32 - Installing
MemCaptureas setuid-root (mode 4755) is a high-risk default and can introduce privilege-escalation vectors. If elevated privileges are required, prefer Linux capabilities or a narrowly-scoped helper; otherwise install without SUID.
recipes-common/breakpad_wrapper/breakpad-wrapper.bb:6 SRC_URIis missing the protocol portion used elsewhere (${CMF_GITHUB_SRC_URI_SUFFIX}includes both protocol and branch/nobranch). Using only${CMF_GITHUB_BRANCH}may cause fetch failures depending on defaults.
SRC_URI = "${CMF_GITHUB_ROOT}/breakpad_wrapper;${CMF_GITHUB_BRANCH};name=breakpadwrapper"
recipes-support/mustach/mustach_1.2.2.bb:2
- Typo in DESCRIPTION: "languge" -> "language".
recipes-support/aker/aker_git.bb:1 - Typo in SUMMARY: "receipe" -> "recipe".
RDKEMW-19574: App Managers 0.7.0.0 Release Integration
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 100 out of 100 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (17)
setup-environment:61
$OE_CORE_LAYERis inside single quotes in thesedexpression, so it will not expand and the PATH cleanup will not remove oldpoky/entries whenOE_CORE_LAYER=poky. Use double quotes for thesedscript (and quote$PATH).
recipes-support/rdmagent/rdmagent.bb:54- This
bb.utils.contains(...)expression has mismatched quotes (" ") which will break BitBake parsing. Use a properly quoted empty/space string for the false branch.
recipes-connectivity/bluetooth/bluetooth-core_git.bb:10 - This
bb.utils.contains(...)expression has mismatched quotes (" ") which will break BitBake parsing. Use a properly quoted empty/space string for the false branch.
recipes-common/utils/commonutilities_git.bb:21 - This
bb.utils.contains(...)expression has mismatched quotes (" ") which will break BitBake parsing. Use a properly quoted empty/space string for the false branch.
recipes-common/rfc/rfc_git.bb:33 - This
bb.utils.contains(...)expression has mismatched quotes (" ") which will break BitBake parsing. Use a properly quoted empty/space string for the false branch.
EXTRA_OEMAKE += "LIBS='-lsafec'"
DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}"
CFLAGS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' `pkg-config --cflags libsafec`', '-fPIC', d)}"
CFLAGS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', '', ' -DSAFEC_DUMMY_API', d)}"
recipes-support/network-hotplug/network-hotplug_1.0.bb:9
- New files
udhcpc@.serviceandusb-input.rulesare added under this recipe'sfiles/directory but are not listed inSRC_URI, so they won't be staged into${WORKDIR}and can't be installed/packaged.
recipes-support/network-hotplug/network-hotplug_1.0.bb:23 network.rules(andusb-input.ruleswhen enabled) trigger systemd units, butdo_install()conditionally installs*.serviceonly whenbenchmark_enableis not present. That can leave udev rules referencing units that were never installed.
recipes-support/network-hotplug/files/network.rules:1- This udev rule is missing a comma between assignments, which makes the rule invalid. It also uses
$name, which is not a standard udev substitution;%kis the conventional interface name token.
recipes-support/network-hotplug/files/usb-ethernet.rules:2 $idis not a standard udev substitution variable, so this will likely be treated literally and write to an incorrect sysfs path. This should use a valid udev token/ENV (e.g.%p,%k, or a derived parent USB device path) to target the correctauthorizedfile.
recipes-support/network-hotplug/files/usb-input.rules:2$idis not a standard udev substitution variable, sousb-input@$id.servicewill likely not resolve to a valid unit name. Use a valid udev token (e.g.%k) or an exported ENV var when constructing the instance name.
recipes-extended/wpe-backend-rdk/files/comcast-manette-gamepad-digital-trigger-fix.patch:20- The added include line has a trailing backtick, which will cause a compilation error when the patch is applied.
recipes-containers/dsm/files/dsm.config:34 - Two different execution environments use the same numeric
id(both are2). If these IDs are meant to be unique, this will cause collisions when DSM resolves environments by ID.
recipes-containers/dsm/dsm.bb:36 SYSTEMD_AUTO_ENABLE/SYSTEMD_SERVICEare set twice; the second assignment also introduces extra whitespace in the unit name, which can lead to mismatches. Keep a single canonical definition.
recipes-devtools/memcapture/memcapture_git.bb:32- Installing
MemCaptureas setuid-root (4755) introduces a privilege-escalation surface. If elevated privileges are required, prefer Linux file capabilities or a dedicated systemd service with narrowly scoped permissions.
recipes-support/mustach/mustach_1.2.2.bb:3 - Typo in description: "languge" → "language".
recipes-support/xmidt-agent/xmidt-agent_git.bb:12 PVis set to1.0.0but the recipe actually fetches/installsPKG_VERSION = 0.5.15. This creates misleading package versioning and can break upgrade/downgrade expectations. Consider derivingPVfromPKG_VERSION.
recipes-common/breakpad_wrapper/breakpad-wrapper.bb:8SRC_URIuses${CMF_GITHUB_BRANCH}(which isnobranch=1) directly, so the fetch URL is missing the protocol portion that other CMF recipes add via${CMF_GITHUB_SRC_URI_SUFFIX}. This can break fetching depending on BitBake defaults.
SRC_URI = "${CMF_GITHUB_ROOT}/breakpad_wrapper;${CMF_GITHUB_BRANCH};name=breakpadwrapper"
DEPENDS += "breakpad"
RDKEMW-19574: App Managers 0.7.0.0 Release Integration
RDKEMW-21538: Update v2.1.3tag for crashupload Recipe
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 100 out of 100 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (16)
setup-environment:61
- The PATH cleanup sed expression is inside single quotes, so $OE_CORE_LAYER is not expanded and the script won’t actually remove prior bitbake/scripts entries when OE_CORE_LAYER is set to "poky" (it will look for the literal string "$OE_CORE_LAYER").
recipes-support/rdmagent/rdmagent.bb:54 - This line has mismatched quoting inside the bb.utils.contains call (" " " "), which will break BitBake parsing.
recipes-support/network-hotplug/network-hotplug_1.0.bb:20 - The install condition is inverted: bb.utils.contains() returns the literal strings "true"/"false" which are executed as shell commands. With the current arguments, services install when benchmark_enable is NOT present, and are skipped when it IS present.
recipes-support/network-hotplug/files/lan-iface@.service:12 - Using Alias=multi-user.target.wants/... in [Install] is not a valid/portable way to hook into a target. This should use WantedBy=multi-user.target (or another appropriate target) so systemd enables the unit correctly.
recipes-extended/wpe-backend-rdk/files/comcast-manette-gamepad-digital-trigger-fix.patch:20 - There is a stray backtick at the end of the #include line, which will cause the patch to produce uncompilable C++ code.
recipes-support/network-hotplug/files/network.rules:1 - This udev rule is missing a comma between assignments; without it, udev will treat the second assignment as part of the first token and the rule can fail to parse/apply correctly.
recipes-support/mustach/mustach_1.2.2.bb:2 - Spelling typo in DESCRIPTION: "languge" -> "language".
recipes-devtools/memcapture/memcapture_git.bb:32 - This installs MemCapture as setuid-root (mode 4755). Setuid binaries significantly increase attack surface; if elevated privileges are required, consider using Linux capabilities (setcap) or a dedicated systemd service/DBus API instead, and document why root is needed.
recipes-containers/dsm/files/dsm.config:34 - ExecutionEnvironments contains duplicate "id": 2 (for both "test" and "user"). IDs should be unique to avoid ambiguous environment selection.
recipes-containers/dsm/dsm.bb:35 - Duplicate SYSTEMD_* assignments here override the earlier correct values, and the extra spaces inside " dsm.service " can result in an invalid/empty unit name being processed by systemd.bbclass.
recipes-common/breakpad_wrapper/breakpad-wrapper.bb:6 - SRC_URI uses ${CMF_GITHUB_BRANCH} ("nobranch=1") but omits the protocol fragment, so it won’t honor CMF_GITHUB_PROTOCOL (https) the way other CMF_GITHUB_ROOT recipes do. Use CMF_GITHUB_SRC_URI_SUFFIX for consistency and correct fetch settings.
SRC_URI = "${CMF_GITHUB_ROOT}/breakpad_wrapper;${CMF_GITHUB_BRANCH};name=breakpadwrapper"
recipes-support/xmidt-agent/xmidt-agent_git.bb:10
- PV is set to 1.0.0 while the fetched artifact version is PKG_VERSION=0.5.15. This can break upgrade/downgrade behavior and misrepresent the package version in feeds.
recipes-common/utils/commonutilities_git.bb:19 - This bb.utils.contains call has unescaped double quotes around the false-case (" "), which breaks BitBake parsing. Use single quotes for the empty/space string.
recipes-connectivity/bluetooth/bluetooth-core_git.bb:9 - This bb.utils.contains call has unescaped double quotes around the false-case (" "), which breaks BitBake parsing. Use single quotes for the empty/space string.
recipes-common/rdk-logger/rdk-logger_git.bb:15 - This bb.utils.contains call has unescaped double quotes around the false-case (" "), which breaks BitBake parsing. Use single quotes for the empty/space string.
DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}"
recipes-common/rfc/rfc_git.bb:31
- This bb.utils.contains call has unescaped double quotes around the false-case (" "), which breaks BitBake parsing. Use single quotes for the empty/space string.
DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}"
RDKEMW-20933: Updated rdmagent tag v2.3.1
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 100 out of 100 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (14)
setup-environment:61
- The sed expression is single-quoted, so $OE_CORE_LAYER is not expanded and PATH cleanup will look for a literal "/$OE_CORE_LAYER/...". This prevents removing prior bitbake/scripts entries when using the poky layout.
recipes-support/network-hotplug/files/network.rules:1 - This udev rule is missing a comma between assignments, so ENV{SYSTEMD_ALIAS} will be parsed as part of the previous key/value and the rule may be ignored or behave unexpectedly.
recipes-connectivity/bluetooth/bluetooth-core_git.bb:9 - This bb.utils.contains() call has mismatched quoting (" ") which will cause a BitBake parse error. The 4th argument should be a properly quoted space string (e.g., ' ').
recipes-common/utils/commonutilities_git.bb:19 - This bb.utils.contains() call has mismatched quoting (" ") which will cause a BitBake parse error. The 4th argument should be a properly quoted space string (e.g., ' ').
recipes-common/rdk-logger/rdk-logger_git.bb:15 - This bb.utils.contains() call has mismatched quoting (" ") which will cause a BitBake parse error. The 4th argument should be a properly quoted space string (e.g., ' ').
DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}"
recipes-support/rdmagent/rdmagent.bb:53
- This bb.utils.contains() call has mismatched quoting (" ") which will cause a BitBake parse error. The 4th argument should be a properly quoted space string (e.g., ' ').
recipes-common/rfc/rfc_git.bb:31 - This bb.utils.contains() call has mismatched quoting (" ") which will cause a BitBake parse error. The 4th argument should be a properly quoted space string (e.g., ' ').
DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}"
recipes-support/mustach/mustach_1.2.2.bb:2
- Spelling typo in DESCRIPTION: "languge" -> "language".
recipes-devtools/memcapture/memcapture_git.bb:32 - The recipe installs the MemCapture binary setuid-root (mode 4755). This is a high-risk escalation surface; if elevated privileges are required, prefer a dedicated systemd service running as root or Linux capabilities. If not strictly required, install as 0755.
recipes-containers/dsm/files/dsm.config:33 - ExecutionEnvironments contains duplicate "id" values (both "test" and "user" are id=2). If IDs are used as unique keys, this will cause collisions.
recipes-containers/dsm/dsm.bb:35 - SYSTEMD_AUTO_ENABLE and SYSTEMD_SERVICE are defined twice (lines 24–25 and again here) with inconsistent spacing. The duplicate definitions add confusion and can lead to subtle overrides if edited later.
recipes-common/breakpad_wrapper/breakpad-wrapper.bb:6 - SRC_URI uses ";${CMF_GITHUB_BRANCH};" which is not a valid SRC_URI parameter string and will likely break fetching. Other recipes use ${CMF_GITHUB_SRC_URI_SUFFIX} for protocol/branch parameters.
SRC_URI = "${CMF_GITHUB_ROOT}/breakpad_wrapper;${CMF_GITHUB_BRANCH};name=breakpadwrapper"
.github/workflows/validate_pr_title.yml:6
- This workflow enforces that PR titles include a ticket prefix and description. The current PR title ("Rebase to develop") does not match the required format and will fail this check when targeting develop; update the PR title accordingly (e.g., "RDK-1234 : Rebase to develop").
pull_request:
branches: [develop]
types: [opened, edited, synchronize]
recipes-extended/wpe-backend-rdk/files/comcast-manette-gamepad-digital-trigger-fix.patch:19
- Stray backtick at the end of this include line will break compilation when the patch is applied.
…1044) * Update SRCREV and PV in telemetry_git.bb * Update dcmd.bb * Update reboot-manager.bb * Update dcmd.bb * Update dcmd.bb * Update dcmd.bb * Update dcmd.bb * Update dcmd.bb
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 100 out of 100 changed files in this pull request and generated no new comments.
Suppressed comments (14)
setup-environment:61
- The sed expression is in single quotes, so $OE_CORE_LAYER is not expanded; this leaves stale openembedded-core entries in PATH when using the poky layout.
recipes-support/rdmagent/rdmagent.bb:53 - This BitBake python expression has an unescaped double-quote (" ") inside a double-quoted string, which will break recipe parsing. Use a single-quoted space literal instead.
recipes-connectivity/bluetooth/bluetooth-core_git.bb:9 - This BitBake python expression has an unescaped double-quote (" ") inside a double-quoted string, which will break recipe parsing. Use a single-quoted space literal instead.
recipes-common/utils/commonutilities_git.bb:19 - This BitBake python expression has an unescaped double-quote (" ") inside a double-quoted string, which will break recipe parsing. Use a single-quoted space literal instead.
recipes-extended/wpe-backend-rdk/files/comcast-manette-gamepad-digital-trigger-fix.patch:19 - Stray backtick at the end of the include will cause the patched file to fail compilation.
recipes-support/network-hotplug/files/network.rules:1 - This udev rule is missing a comma between assignments, which makes it invalid syntax. Also prefer %k (kernel interface name) over $name for systemd instance naming in udev rules.
recipes-support/network-hotplug/network-hotplug_1.0.bb:9 - New files under recipes-support/network-hotplug/files (e.g., udhcpc@.service, usb-input.rules) are not in SRC_URI, so they will never be staged into WORKDIR and cannot be installed/packaged. Either add them here or remove the unused files.
recipes-support/network-hotplug/network-hotplug_1.0.bb:23 - Only installing network.rules means additional *.rules (including newly added usb-input.rules and bbappended usb-ethernet.rules) won't be installed unless every append adds its own do_install. Installing all staged .rules files is simpler and avoids omissions.
recipes-devtools/memcapture/memcapture_git.bb:32 - Installing MemCapture setuid-root (mode 4755) is a high-risk privilege escalation surface. If elevated privileges are required, prefer Linux capabilities (setcap) or a minimal privileged helper; otherwise install as 0755.
recipes-containers/dsm/files/dsm.config:34 - ExecutionEnvironments entries "test" and "user" both use id=2. If ids are expected to be unique, this will cause collisions/undefined behavior when referencing environments by id.
recipes-common/breakpad_wrapper/breakpad-wrapper.bb:6 - SRC_URI appends only ${CMF_GITHUB_BRANCH} (e.g., nobranch=1) and omits the protocol parameter used elsewhere via ${CMF_GITHUB_SRC_URI_SUFFIX}. This can break fetching depending on default protocol settings.
SRC_URI = "${CMF_GITHUB_ROOT}/breakpad_wrapper;${CMF_GITHUB_BRANCH};name=breakpadwrapper"
recipes-common/rfc/rfc_git.bb:31
- This BitBake python expression has an unescaped double-quote (" ") inside a double-quoted string, which will break recipe parsing. Use a single-quoted space literal instead.
DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}"
recipes-common/rdk-logger/rdk-logger_git.bb:15
- This BitBake python expression has an unescaped double-quote (" ") inside a double-quoted string, which will break recipe parsing. Use a single-quoted space literal instead.
DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}"
recipes-common/dcmd/dcmd.bb:56
- BREAKPAD_BIN:append concatenates without a separator; if BREAKPAD_BIN is treated as a space-separated list (as in reboot-manager.bb), this will produce an invalid token. Add a leading space in the appended value.
BREAKPAD_BIN:append = "logupload"
RDKEMW-22116: Back Merge 8.7.1.0 Release branch to Develop
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 100 out of 100 changed files in this pull request and generated no new comments.
Suppressed comments (18)
setup-environment:61
- The sed expression is single-quoted, so $OE_CORE_LAYER will not expand and PATH cleanup will not remove previous bitbake/scripts entries when using poky vs openembedded-core.
recipes-support/rdmagent/rdmagent.bb:55 - This bb.utils.contains call has mismatched quotes (" "), which will cause a BitBake parse error for the recipe.
recipes-connectivity/bluetooth/bluetooth-core_git.bb:9 - This bb.utils.contains call has mismatched quotes (" "), which will cause a BitBake parse error for the recipe.
recipes-common/rfc/rfc_git.bb:31 - This bb.utils.contains call has mismatched quotes (" "), which will cause a BitBake parse error for the recipe.
DEPENDS:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'safec', ' safec', " ", d)}"
recipes-common/utils/commonutilities_git.bb:19
- This bb.utils.contains call has mismatched quotes (" "), which will cause a BitBake parse error for the recipe.
recipes-support/network-hotplug/network-hotplug_1.0.bb:9 - udhcpc@.service and usb-input.rules are added under recipes-support/network-hotplug/files but not fetched via SRC_URI, so they will never reach WORKDIR (and the wildcard install of *.service will not install udhcpc@.service).
recipes-support/network-hotplug/network-hotplug_1.0.bb:23 - usb-input.rules is fetched (via SRC_URI) but not installed into ${sysconfdir}/udev/rules.d, so it won’t take effect at runtime.
recipes-support/network-hotplug/files/network.rules:1 - This udev rule is missing a comma between the two ENV assignments; without it, the rule is syntactically invalid and may not be applied.
recipes-support/network-hotplug/files/lan-iface@.service:12 - The [Install] Alias value is a path under multi-user.target.wants, which is not a valid systemd unit alias. Use WantedBy=multi-user.target (or a proper unit-name Alias) to enable the unit.
recipes-support/network-hotplug/files/udhcpc@.service:12 - ExecStart passes "-i%i" as a single token; udhcpc expects the interface name as a separate argument (or may not accept the concatenated form). Use "-i %i" to ensure the template expands correctly.
recipes-support/network-hotplug/files/usb-input.rules:2 - $id is not a standard udev substitution in rule values, so the systemd unit instance will not be parameterized correctly. Use a supported token like %k (kernel name) or another appropriate udev substitution for the instance name.
recipes-support/network-hotplug/files/usb-ethernet.rules:2 - This rule uses $id inside the RUN shell command, but $id will be undefined at runtime, so it will write to an incorrect sysfs path. Use a supported udev substitution (e.g., derived from DEVPATH) to identify the correct USB device node to deauthorize.
recipes-containers/dsm/dsm.bb:35 - SYSTEMD_AUTO_ENABLE and SYSTEMD_SERVICE are set twice; the second set also adds extra whitespace around the unit name, making the recipe harder to maintain and potentially affecting unit name matching.
recipes-containers/dsm/files/dsm.config:34 - ExecutionEnvironments entries "test" and "user" both use id=2. If IDs are used as unique keys, this will cause collisions.
recipes-common/breakpad_wrapper/breakpad-wrapper.bb:6 - SRC_URI is malformed: ";${CMF_GITHUB_BRANCH}" is not a valid fetcher parameter set, and will likely break fetching. Use the standard CMF GitHub URI suffix (protocol/branch) used elsewhere in the layer.
SRC_URI = "${CMF_GITHUB_ROOT}/breakpad_wrapper;${CMF_GITHUB_BRANCH};name=breakpadwrapper"
recipes-support/mustach/mustach_1.2.2.bb:2
- Typo in DESCRIPTION: "languge" → "language".
recipes-extended/wpe-backend-rdk/files/comcast-manette-gamepad-digital-trigger-fix.patch:19 - There is an extra trailing backtick on the #include line in the patch, which will cause compilation to fail after the patch is applied.
recipes-devtools/memcapture/memcapture_git.bb:31 - The binary is installed setuid-root (mode 4755), which is a high-risk security posture for a new tool. Unless MemCapture is explicitly designed/audited to be setuid, prefer a normal executable (0755) and use capabilities or a privileged service wrapper if elevated access is required.
No description provided.