Feature/rdkemw 22799

[Saranya2421]

No description provided.

[Copilot]

Pull request overview

This PR updates the Yocto recipe for reboot-manager, primarily by pinning it to a newer upstream commit and adjusting the logrotate configuration variables used to generate log rotation rules for reboot-related logs.

Changes:

• Bump SRCREV_reboot-manager to a newer commit (70662c1b...).
• Remove per-log LOGROTATE_ROTATION_* / LOGROTATE_ROTATION_MEM_* settings for reboot_reason and rebootInfo.

Suppressed comments (1)

recipes-support/reboot-manager/reboot-manager.bb:41

• LOGROTATE_ROTATION_* for the rebootInfo log was removed while other logrotate_config users in this layer set it explicitly (e.g. recipes-connectivity/bluetooth/bluetooth-mgr_git.bb:69-72, recipes-containers/dobby/dobby.bb:41-45). If logrotate_config doesn’t supply a default, the generated logrotate config may end up missing a rotate <N> value; even if it does, this change silently alters retention behavior. Consider restoring the explicit rotation values.

LOGROTATE_LOGNAME_rebootInfo = "rebootInfo.log"
#HDD_ENABLE
LOGROTATE_SIZE_rebootInfo = "64000"
#HDD_DISABLE
LOGROTATE_SIZE_MEM_rebootInfo = "64000"

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (2)

recipes-support/reboot-manager/reboot-manager.bb:35

• This recipe no longer sets any LOGROTATE_ROTATION_* values for reboot_reason. Other recipes that use logrotate_config in this layer consistently specify both size and rotation (e.g. recipes-common/rbus/rbus.bb:48-51, recipes-support/rdmagent/rdmagent.bb:33-36), so dropping the rotation here can change retention behavior depending on the bbclass defaults.

LOGROTATE_LOGNAME_reboot_reason="rebootreason.log"
#HDD_ENABLE
LOGROTATE_SIZE_reboot_reason="1572864"
#HDD_DISABLE
LOGROTATE_SIZE_MEM_reboot_reason="1572864"

recipes-support/reboot-manager/reboot-manager.bb:41

• This recipe no longer sets any LOGROTATE_ROTATION_* values for rebootInfo. Other logrotate_config users in this layer define an explicit rotation count alongside the size limits, so leaving it unset here makes rebootInfo retention depend on external defaults and can diverge from the rest of the layer's logrotate behavior.

LOGROTATE_LOGNAME_rebootInfo = "rebootInfo.log"
#HDD_ENABLE
LOGROTATE_SIZE_rebootInfo = "64000"
#HDD_DISABLE
LOGROTATE_SIZE_MEM_rebootInfo = "64000"

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (2)

recipes-support/reboot-manager/reboot-manager.bb:35

• The logrotate rotation count for reboot_reason is no longer set. Other recipes in this layer that inherit logrotate_config explicitly set LOGROTATE_ROTATION_* (e.g., recipes-common/rbus/rbus.bb:49-51, recipes-common/sys_mon_tools/cpuprocanalyzer_git.bb:22-25). Leaving it unset makes retention depend on an external default and can change how many rotated logs are kept (potentially growing disk usage or losing history).

LOGROTATE_SIZE_reboot_reason="1572864"
#HDD_DISABLE
LOGROTATE_SIZE_MEM_reboot_reason="1572864"

recipes-support/reboot-manager/reboot-manager.bb:41

• The logrotate rotation count for rebootInfo is no longer set. Within this layer, recipes that inherit logrotate_config typically define LOGROTATE_ROTATION_* alongside size (e.g., recipes-containers/dobby/dobby.bb:42-45, recipes-connectivity/bluetooth/bluetooth-mgr_git.bb:69-72). If the rotation value is omitted, retention will depend on an external default and may change log history/disk usage unexpectedly.

LOGROTATE_SIZE_rebootInfo = "64000"
#HDD_DISABLE
LOGROTATE_SIZE_MEM_rebootInfo = "64000"

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

recipes-support/reboot-manager/reboot-manager.bb:36

• The recipe no longer sets LOGROTATE_ROTATION_* for reboot_reason/rebootInfo. Other recipes inheriting logrotate_config consistently set explicit rotation counts (e.g., recipes-common/rbus/rbus.bb:49-51, recipes-connectivity/bluetooth/bluetooth-mgr_git.bb:70-72); omitting these risks changing log retention if the class doesn’t provide a default. Consider restoring explicit rotation values (or set the intended ones).

#HDD_ENABLE
LOGROTATE_SIZE_reboot_reason="1572864"
#HDD_DISABLE
LOGROTATE_SIZE_MEM_reboot_reason="1572864"

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (2)

recipes-support/reboot-manager/reboot-manager.bb:35

• The logrotate rotation count for reboot_reason is no longer set. Other recipes that inherit logrotate_config explicitly define both LOGROTATE_ROTATION_* and LOGROTATE_ROTATION_MEM_* (e.g., recipes-support/rdmagent/rdmagent.bb:34-36, recipes-common/rbus/rbus.bb:49-51). Dropping these variables will change retention to whatever the bbclass default is, which can reduce available reboot-history logs.

LOGROTATE_LOGNAME_reboot_reason="rebootreason.log"
#HDD_ENABLE
LOGROTATE_SIZE_reboot_reason="1572864"
#HDD_DISABLE
LOGROTATE_SIZE_MEM_reboot_reason="1572864"

recipes-support/reboot-manager/reboot-manager.bb:41

• The logrotate rotation count for rebootInfo is no longer set. In this layer, recipes using logrotate_config consistently set explicit rotation counts (for both HDD and MEM variants). Without these variables, rebootInfo.log retention will depend on the bbclass default and may regress from the previous 3-rotation behavior.

LOGROTATE_LOGNAME_rebootInfo = "rebootInfo.log"
#HDD_ENABLE
LOGROTATE_SIZE_rebootInfo = "64000"
#HDD_DISABLE
LOGROTATE_SIZE_MEM_rebootInfo = "64000"

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (3)

recipes-support/reboot-manager/reboot-manager.bb:41

• LOGROTATE_SIZE_* and LOGROTATE_SIZE_MEM_* are set for rebootInfo, but the corresponding LOGROTATE_ROTATION_* values were removed. For consistency with other logrotate_config recipes (and to keep prior retention behavior), reintroduce the rotation settings.

LOGROTATE_LOGNAME_rebootInfo = "rebootInfo.log"
#HDD_ENABLE
LOGROTATE_SIZE_rebootInfo = "64000"
#HDD_DISABLE
LOGROTATE_SIZE_MEM_rebootInfo = "64000"

recipes-support/reboot-manager/reboot-manager.bb:35

• LOGROTATE_SIZE_* and LOGROTATE_SIZE_MEM_* are set for reboot_reason, but the corresponding LOGROTATE_ROTATION_* values were removed. Other logrotate_config recipes in this repo consistently set rotation, and leaving it unset can change retention behavior or generate an incomplete logrotate rule.

LOGROTATE_LOGNAME_reboot_reason="rebootreason.log"
#HDD_ENABLE
LOGROTATE_SIZE_reboot_reason="1572864"
#HDD_DISABLE
LOGROTATE_SIZE_MEM_reboot_reason="1572864"

recipes-support/reboot-manager/reboot-manager.bb:19

• SRCREV was updated, but the nearby release-tag comment appears out of sync (line 13 says "Release Tag - 2.2.3" while PV is 2.2.4). This makes it harder to correlate PV/SRCREV during later maintenance; please update/remove the stale comment to match the version being built.

SRCREV_reboot-manager = "a1b8450d5e161969aac6539381f1f8f98b456bac"