Feature/rdkemw 22385 - #1064
Open
Abhinavpv28 wants to merge 33 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
recipes-common/dcmd/dcmd.bb:18
- SRCREV was updated but PV and PR remained unchanged. If this layer is used to produce packages/feeds, the resulting package version can stay the same (e.g., 2.1.4-r0) even though the source changed, preventing upgrades or making it hard to distinguish builds. Consider bumping PR (or PV) when changing SRCREV, or incorporating ${SRCPV} into PV to make the source revision visible in the package version.
SRCREV = "ada3b060150587f0aa317832e7edbf37f1b49cdb"
SRC_URI = "${CMF_GITHUB_ROOT}/dcm-agent;${CMF_GITHUB_SRC_URI_SUFFIX}"
PV = "2.2.1"
PR = "r0"
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
recipes-common/dcmd/dcmd.bb:18
- Updating SRCREV without changing PV/PR can produce packages with the same version string but different contents, which can break package-feed upgrades/downgrades (opkg/rpm may not detect a newer build). Please bump PR (or PV) whenever SRCREV changes so the produced package version advances.
SRCREV = "ada3b060150587f0aa317832e7edbf37f1b49cdb"
SRC_URI = "${CMF_GITHUB_ROOT}/dcm-agent;${CMF_GITHUB_SRC_URI_SUFFIX}"
PV = "2.2.1"
PR = "r0"
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
recipes-common/dcmd/dcmd.bb:18
- Changing
SRCREVwithout also changingPVor bumpingPRkeeps the package version at2.2.1-r0even though the source content changes. If this recipe is published in package feeds or used for upgrades, consumers may not pick up the new build because the version is unchanged.
Bump PR (or adjust PV to include SRCPV) so the package version reflects the new revision.
SRCREV = "66d14c0a50eac8e56362acad863592d21cb0301b"
SRC_URI = "${CMF_GITHUB_ROOT}/dcm-agent;${CMF_GITHUB_SRC_URI_SUFFIX}"
PV = "2.2.1"
PR = "r0"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.