RDKBACCL-1828: Make 6.12 kernel build changes in wrynose build - #462
Open
SsandhyaR wants to merge 1 commit into
Open
RDKBACCL-1828: Make 6.12 kernel build changes in wrynose build#462SsandhyaR wants to merge 1 commit into
SsandhyaR wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR appears aimed at resolving patch QA / metadata requirements in the Yocto build (likely triggered by the wrynose/6.12 migration) by ensuring patches carry an Upstream-Status tag, including for externally-fetched upstream patch series.
Changes:
- Updates
readline_5.2.bbto add a new task intended to injectUpstream-Status: Pendinginto the fetched readline 5.2 patchset beforedo_patch. - Adds
Upstream-Status: Pendingto several CVE fix patch headers (bzip2, zlib). - Refreshes the zlib
remove.ldconfig.call.patchpatch context to match zlib-1.2.11 paths.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| recipes-gplv2/readline/readline_5.2.bb | Adds a pre-do_patch task intended to inject Upstream-Status into fetched readline patches. |
| recipes-extended/bzip2/bzip2/CVE-2019-12900_fix.patch | Adds Upstream-Status: Pending to the patch header. |
| recipes-core/zlib/zlib-1.2.11/remove.ldconfig.call.patch | Updates patch context/header to refer to zlib-1.2.11. |
| recipes-core/zlib/files/CVE-2023-45853_fix.patch | Adds Upstream-Status: Pending to the patch header. |
| recipes-core/zlib/files/CVE-2022-37434_fix.patch | Adds Upstream-Status: Pending to the patch header. |
| recipes-core/zlib/files/CVE-2018-25032_fix.patch | Adds Upstream-Status: Pending to the patch header. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+66
to
+72
| D = "../downloads" | ||
| do_addupsteam() { | ||
| for p in ${D}/readline52-0*; do | ||
| sed -i '/^Patch:/i Upstream-Status: Pending' "$p" | ||
| done | ||
| } | ||
| addtask do_addupsteam after do_unpack before do_patch |
ssaman123
reviewed
Jun 24, 2026
There was a problem hiding this comment.
See if package version is upgraded and whether we need this CVE patch anymore
ssaman123
reviewed
Jun 24, 2026
There was a problem hiding this comment.
Why can't we edit the patch directly ? Also check if the same package version we are building in wrynose or upgraded.
Reason for change : addressed patch related issues Test procedure: None Risk: None Signed-off-by: ssiras826 <sandhyarani_sirasanagandla@comcast.com>
SsandhyaR
force-pushed
the
feature-wrynose
branch
from
June 25, 2026 10:08
561f99a to
3b61597
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change : addressed patch related issues
Test procedure: None
Risk: None