Skip to content

Update mquickjs - #56

Open
tleacmcsa wants to merge 2 commits into
developfrom
tlea/dev/mquickjs-update
Open

Update mquickjs#56
tleacmcsa wants to merge 2 commits into
developfrom
tlea/dev/mquickjs-update

Conversation

@tleacmcsa

@tleacmcsa tleacmcsa commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

mquickjs does not tag or version yet, so we use the YYYYMMDD of the
upstream commit per Yocto convention for unversioned git-only projects.

- Rename mquickjs_git.bb -> mquickjs_0.0+git20260115.bb (SHA ee50431)
- Add mquickjs_0.0+git20260604.bb (SHA 203d5bb) with breaking API changes
- Pin PREFERRED_VERSION in layer.conf to 0.0+git20260115 so the stable
  version remains the default; opt in to the new API by setting
  PREFERRED_VERSION_mquickjs = "0.0+git20260604"

Moving to latest SHA (still no upstream formal release or tag).
Copilot AI review requested due to automatic review settings July 14, 2026 20:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Yocto recipe for mquickjs to build from a newer upstream git commit (since there is still no formal release/tag), aligning the layer with the commit expected by dependent work (noted as BartonCore PR #244).

Changes:

  • Bumped mquickjs SRCREV to 203d5bb79789bc47b74855d9207415dab71661a0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mquickjs has no upstream tags or releases. Version using the
YYYYMMDD of the upstream commit per Yocto convention for unversioned
git-only projects.

- Rename mquickjs_git.bb -> mquickjs_0.0+git20260115.bb (SHA ee50431)
- Add mquickjs_0.0+git20260604.bb (SHA 203d5bb) with breaking API changes
- Pin PREFERRED_VERSION in layer.conf to 0.0+git20260115 so the stable
  version remains the default; opt in to the new API by setting
  PREFERRED_VERSION_mquickjs = "0.0+git20260604"
Copilot AI review requested due to automatic review settings July 15, 2026 19:37
@rdkcmf-jenkins

Copy link
Copy Markdown
Contributor

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 2 files pending identification.

  • Protex Server Path: /home/blackduck/github/meta-rdk-iot/56/rdkcentral/meta-rdk-iot

  • Commit: 5355caf

Report detail: gist'

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

recipes-support/mquickjs/mquickjs_0.0+git20260115.bb:14

  • This recipe is meant to represent the older/stable mquickjs version (and is referenced by PREFERRED_VERSION_mquickjs = "0.0+git20260115"), but it now points at the same SRCREV as the newer 20260604 recipe. Additionally, overriding PV to 0.0.1+git${SRCPV} means the recipe’s effective version won’t match the layer’s PREFERRED_VERSION, and it may even sort newer than 0.0+git20260604.

To make the “stable vs breaking” split (and the layer pin) work, keep this recipe on the older SRCREV and align PV with the filename (or drop the PV override entirely).

@rdkcmf-jenkins

Copy link
Copy Markdown
Contributor

b'## WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

  • Upvote reason: OK

  • Commit: 5355caf
    '

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants