RDKOSS-1091: Changes to support Hash Equivalence - #193
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates two BitBake helper classes to make syslog-ng and logrotate metadata generation more deterministic when Hash Equivalence is enabled, aiming to prevent sstate signature validation errors caused by filesystem metadata differences.
Changes:
- Run the metadata-generation tasks under fakeroot to stabilize ownership/permission metadata in
${D}. - Replace
os.makedirs()withbb.utils.mkdirhier()and explicitlychowncreated directories to root.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
classes/syslog-ng-config-gen.bbclass |
Adjusts syslog-ng metadata task to create directories via BitBake utilities and set deterministic ownership under fakeroot. |
classes/logrotate_config.bbclass |
Adjusts logrotate metadata task similarly to avoid ownership/permission drift impacting hash equivalence. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vbabypublic
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change : To avoid file permission change thus avoiding sstate sig validation error
Test procuedure : Build and verify with Hash equivalence enabled
Risk: Low