RDKEMW-21356: Set Build type to signedlab for signedlab builds - #174
Open
KTirumalaSrihari wants to merge 2 commits into
Open
RDKEMW-21356: Set Build type to signedlab for signedlab builds#174KTirumalaSrihari wants to merge 2 commits into
KTirumalaSrihari wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the rootfs post-processing hooks to mark signedlab images as BUILD_TYPE=signedlab in /etc/device.properties, aligning the device property with the signedlab build variant.
Changes:
- In the signedlab post-rootfs hook, update
device.propertiesto switchBUILD_TYPEfromprodtosignedlabwhenLABSIGNED_ENABLEDis enabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
45
to
48
| if [ -f "${R}/etc/device.properties" ]; then | ||
| sed -i 's/^LABSIGNED_ENABLED=false/LABSIGNED_ENABLED=true/g' ${R}/etc/device.properties | ||
| sed -i 's/BUILD_TYPE=prod/BUILD_TYPE=signedlab/g' ${R}/etc/device.properties | ||
| fi |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
classes/post-rootfs-hooks.bbclass:47
- The
sedpattern is not anchored, so it can also rewrite occurrences likeFOO_BUILD_TYPE=prodorBUILD_TYPE=prodlogif they appear indevice.properties. Anchor the key to the beginning of the line (and ideally the whole line) to ensure only the intended property is changed; also quote the path for consistency with other checks.
sed -i 's/BUILD_TYPE=prod/BUILD_TYPE=signedlab/g' ${R}/etc/device.properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.