Skip to content

RDKOSS-961: Changes to support Hash Equivalence - #171

Open
h1712 wants to merge 4 commits into
developfrom
feature/RDKOSS-961-Hasheq
Open

RDKOSS-961: Changes to support Hash Equivalence#171
h1712 wants to merge 4 commits into
developfrom
feature/RDKOSS-961-Hasheq

Conversation

@h1712

@h1712 h1712 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Reason for change : To avoid file permission change thus avoiding sstate sig validation error
Test procuedure : Build and verify with Hash equivalence enabled
Risk: Low

Copilot AI review requested due to automatic review settings June 30, 2026 06:50
@h1712
h1712 requested review from a team as code owners June 30, 2026 06:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds fakeroot execution and deterministic directory creation to metadata-generation tasks so the generated syslog-ng/logrotate configuration metadata doesn’t cause permission/ownership differences that can break sstate signature validation when Hash Equivalence is enabled.

Changes:

  • Run do_write_metadata_syslog_ng and do_write_metadata_logrotate under fakeroot.
  • Use bb.utils.mkdirhier() (and os.chown(..., 0, 0)) when creating the logrotate and syslog-ng metadata directories.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
classes/syslog-ng-config-gen.bbclass Runs metadata generation under fakeroot and changes metadata directory creation to be more deterministic for hash equivalence.
classes/logrotate_config.bbclass Runs logrotate metadata generation under fakeroot and uses deterministic directory creation/ownership for hash equivalence stability.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread classes/syslog-ng-config-gen.bbclass
@h1712 h1712 linked an issue Jun 30, 2026 that may be closed by this pull request
@h1712 h1712 closed this Jun 30, 2026
@h1712
h1712 deleted the feature/RDKOSS-961-Hasheq branch June 30, 2026 08:37
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 30, 2026
@h1712
h1712 restored the feature/RDKOSS-961-Hasheq branch June 30, 2026 08:39
@h1712 h1712 reopened this Jun 30, 2026
Copilot AI review requested due to automatic review settings June 30, 2026 09:03
@svc-rdkeportal01

Copy link
Copy Markdown

CCI-Build-Verified -1
sha: cdb259e

3 similar comments
@svc-rdkeportal01

Copy link
Copy Markdown

CCI-Build-Verified -1
sha: cdb259e

@svc-rdkeportal01

Copy link
Copy Markdown

CCI-Build-Verified -1
sha: cdb259e

@svc-rdkeportal01

Copy link
Copy Markdown

CCI-Build-Verified -1
sha: cdb259e

@prajwal-public

Copy link
Copy Markdown

Also https://github.com/rdkcentral/meta-rdk-auxiliary/pull/171/changes this is built on top of latest meta-rdk-aux which includes OSS4.13 and OSS4.13 is NOT yet available in MW and IA develop branch since its integration is still on-going with VL-OSS by MW layer in temporary release branch

Fakeroot changes needs to be tested well against full stack builds for STBs and TV Panels

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants