RDKEMW-9437 : Secure Unlock of Debug services(overrides) in LabSigned Build type - #108
RDKEMW-9437 : Secure Unlock of Debug services(overrides) in LabSigned Build type#108KTirumalaSrihari wants to merge 10 commits into
Conversation
…the build type is labSigned
…uild type is LABSIGNED Via the function update_labsigned_property, we are setting LABSIGNED_ENABLED to true, if the build type is LABSIGNED
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
There was a problem hiding this comment.
Pull request overview
This PR introduces a new post-rootfs hook to enable secure debug services for lab-signed build variants by toggling a property in device.properties.
Changes:
- Adds a
SignedLab-variantpost-rootfs hook that reusescommon_prod_image_hook. - Introduces
enable_debugService_propertyto flipLABSIGNED_ENABLEDfromfalsetotruein/etc/device.propertiesfor the SignedLab variant.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains("DISTRO_FEATURES", "prod-variant", "prod_image_hook; ", "", d)}' | ||
| ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains("DISTRO_FEATURES", "prodlog-variant", "prodlog_image_hook; ", "", d)}' | ||
| ROOTFS_POSTPROCESS_COMMAND += '${@bb.utils.contains("DISTRO_FEATURES", "SignedLab-variant", "SignedLab_image_hook; ", "", d)}' |
There was a problem hiding this comment.
The new hook name SignedLab_image_hook and the corresponding DISTRO_FEATURES flag SignedLab-variant use mixed capitalization, while the existing hooks and flags (e.g. prod_image_hook / prod-variant, prodlog_image_hook / prodlog-variant) are all lowercase. For consistency and discoverability, consider renaming these to follow the same lowercase/underscore pattern as the other variants.
| fi | ||
| } | ||
|
|
||
| enable_debugService_property() { |
There was a problem hiding this comment.
The function name enable_debugService_property is using camelCase inside an otherwise snake_case naming scheme (cf. update_build_type_property, cleanup_stunnel_socat, etc.), which makes it stand out and slightly harder to grep for. To align with the rest of this file, consider renaming it to a fully snake_case name (for example, using only lowercase letters and underscores).
|
the changes look good to me |
Reason for change: to enable debug services, only if the build vairant is labSigned and device is test type
Test Procedure: Flash the image and check for enabling secure debug services
Risks: Low