RDKEVD-1128 : MW ipk feedpath - #157
Open
aktamilbe wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the middleware OPKG feed configuration to pull IPKs from a different artifacts sub-path and to use a new middleware release identifier.
Changes:
- Switches middleware feed root from
middleware-rel/${RELEASE_NUM}tomiddleware-dbg/${RELEASE_NUM}for both standard and OSS middleware feeds. - Updates
RELEASE_NUMtoDVCalibrationMW_1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| conf/machine/include/oss_mw.inc | Updates OSS middleware IPK feed path root to middleware-dbg/${RELEASE_NUM}. |
| conf/machine/include/middleware.inc | Updates RELEASE_NUM and switches middleware IPK feed path root to middleware-dbg/${RELEASE_NUM}. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| PACKAGE_EXTRA_ARCHS:append = " ${MIDDLEWARE_ARCH}" | ||
|
|
||
| RELEASE_NUM = "8.6.3.0" | ||
| RELEASE_NUM = "DVCalibrationMW_1" |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
conf/machine/include/middleware.inc:8
RELEASE_NUMis set with a strong assignment (=), which makes it harder for downstream configuration (e.g., distro/local.conf) to supply a different release without relying on parse-order overrides. Since this include file appears to provide defaults, use a weak assignment (?=) to make the release identifier easily configurable.
RELEASE_NUM = "DVCalibrationMW_3"
conf/machine/include/oss_mw.inc:6
MW_OSS_IPK_SERVER_PATHuses a strong assignment (=), which makes it less configurable than the non-OSS equivalent (MW_IPK_SERVER_PATH ?=inmiddleware.inc). If this is intended as a default feed URL, consider switching to?=so downstream builds can override it cleanly without depending on parse order.
MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}"
MW_OSS_IPK_SERVER_PATH = "${RDK_ARTIFACTS_BASE_URL}/${MW_OSS_IPK_PATH}/${RDK_MW_ARCH}/${MW_OSS}/ipks/${BUILD_VARIANT}"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.