Skip to content

RDKEVD-1128 : MW ipk feedpath - #157

Open
aktamilbe wants to merge 2 commits into
developfrom
feature/DVCalibration
Open

RDKEVD-1128 : MW ipk feedpath#157
aktamilbe wants to merge 2 commits into
developfrom
feature/DVCalibration

Conversation

@aktamilbe

Copy link
Copy Markdown

No description provided.

Copilot AI review requested due to automatic review settings July 30, 2026 11:55
@aktamilbe
aktamilbe requested a review from a team as a code owner July 30, 2026 11:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the middleware OPKG feed configuration to pull IPKs from a different artifacts sub-path and to use a new middleware release identifier.

Changes:

  • Switches middleware feed root from middleware-rel/${RELEASE_NUM} to middleware-dbg/${RELEASE_NUM} for both standard and OSS middleware feeds.
  • Updates RELEASE_NUM to DVCalibrationMW_1.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
conf/machine/include/oss_mw.inc Updates OSS middleware IPK feed path root to middleware-dbg/${RELEASE_NUM}.
conf/machine/include/middleware.inc Updates RELEASE_NUM and switches middleware IPK feed path root to middleware-dbg/${RELEASE_NUM}.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread conf/machine/include/middleware.inc Outdated
PACKAGE_EXTRA_ARCHS:append = " ${MIDDLEWARE_ARCH}"

RELEASE_NUM = "8.6.3.0"
RELEASE_NUM = "DVCalibrationMW_1"
Comment thread conf/machine/include/oss_mw.inc
Copilot AI review requested due to automatic review settings July 30, 2026 18:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

conf/machine/include/middleware.inc:8

  • RELEASE_NUM is set with a strong assignment (=), which makes it harder for downstream configuration (e.g., distro/local.conf) to supply a different release without relying on parse-order overrides. Since this include file appears to provide defaults, use a weak assignment (?=) to make the release identifier easily configurable.
RELEASE_NUM = "DVCalibrationMW_3"

conf/machine/include/oss_mw.inc:6

  • MW_OSS_IPK_SERVER_PATH uses a strong assignment (=), which makes it less configurable than the non-OSS equivalent (MW_IPK_SERVER_PATH ?= in middleware.inc). If this is intended as a default feed URL, consider switching to ?= so downstream builds can override it cleanly without depending on parse order.
MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}"
MW_OSS_IPK_SERVER_PATH = "${RDK_ARTIFACTS_BASE_URL}/${MW_OSS_IPK_PATH}/${RDK_MW_ARCH}/${MW_OSS}/ipks/${BUILD_VARIANT}"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants