RDKEMW-18919 : Remove product specific systimemgr config - #125
Open
sindhu-krishnan wants to merge 6 commits into
Open
RDKEMW-18919 : Remove product specific systimemgr config#125sindhu-krishnan wants to merge 6 commits into
sindhu-krishnan wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces an image assembly-time mechanism in the middleware layer to generate /etc/systimemgr.conf based on active BitBake overrides, replacing/removing product-specific systimemgr configuration from MW for assembler builds.
Changes:
- Add a new
systimemgrconfigimage class to the commonIMAGE_CLASSESlist. - Introduce
classes/systimemgrconfig.bbclassto generate/etc/systimemgr.confbased onOVERRIDES, and (for one override) remove a systemd drop-insecure.conf.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| conf/include/image-classes.inc | Registers the new systimemgrconfig class for images. |
| classes/systimemgrconfig.bbclass | Implements rootfs postprocessing to generate /etc/systimemgr.conf and adjust systimemgr systemd drop-ins depending on overrides. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+43
to
+50
| secure_conf = os.path.join( | ||
| rootfs_dir, | ||
| "lib", | ||
| "systemd", | ||
| "system", | ||
| "systimemgr.service.d", | ||
| "secure.conf" | ||
| ) |
| # /etc/rfcdefaults/socprovisioning.ini | ||
| IMAGE_CLASSES += "socprovisioning-config" | ||
|
|
||
| #/etc/systimemgr.conf |
goruklu
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product specific systimemgr config should be removed from MW
This bbclass installs the config based on the product override for assembler builds.