RDKBACCL-1964: Build rdk-generic-ap-extender-image for extender - #520
Open
SsandhyaR wants to merge 1 commit into
Open
RDKBACCL-1964: Build rdk-generic-ap-extender-image for extender#520SsandhyaR wants to merge 1 commit into
SsandhyaR wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Banana Pi R4 RDK broadband AP extender layer to resolve build issues (notably around ccsp-common-library) and align extender image configuration/patch metadata for the target image rdk-generic-ap-extender-image.
Changes:
- Add
Upstream-Status: Pendingmetadata to multiple mac80211 patch files. - Fix
ccsp-common-library.bbappendto editRdkFwUpgradeManager.servicein${systemd_unitdir}/system(instead of${libdir}/systemd/system). - Adjust extender machine/distro feature configuration (remove
efiforwrynose, removeptest, and appendrdkb_configurable_wan_interface).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| meta-rdk-mtk-bpir4/recipes-wifi/linux-mac80211/files/1002-MAC-ACL-support-for-BPI.patch | Adds Yocto patch metadata (Upstream-Status). |
| meta-rdk-mtk-bpir4/recipes-wifi/linux-mac80211/files/1002-MAC-ACL-support-for-BPI_v6.patch | Adds Yocto patch metadata (Upstream-Status). |
| meta-rdk-mtk-bpir4/recipes-wifi/linux-mac80211/files/1001-BPIR4_Enable_Beacon_Frame_Subscription.patch | Adds Yocto patch metadata (Upstream-Status). |
| meta-rdk-mtk-bpir4/recipes-kernel/linux/linux-mediatek_%.bbappend | Removes a stray blank/whitespace-only line. |
| meta-rdk-mtk-bpir4/recipes-ccsp/ccsp/ccsp-common-library.bbappend | Corrects systemd unit path used for sed modification of RdkFwUpgradeManager.service. |
| conf/machine/bananapi4-rdk-broadband-ap-extender.conf | Updates machine feature and distro feature removals for the extender machine. |
| conf/distro/include/rdk-bpi-ap-extender.inc | Appends rdkb_configurable_wan_interface to distro features for the extender include. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
34
to
37
| # Kernel 6.6 | ||
| DISTRO_FEATURES:append = " kernel6-12" | ||
|
|
||
| DISTRO_FEATURES:append = " rdkb_configurable_wan_interface" | ||
| #Disable rdm-agent for reference platform |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
Suppressed comments (3)
conf/distro/include/rdk-bpi-ap-extender.inc:37
- The newly added DISTRO_FEATURE is placed under the "Kernel 6.6" section, but it is not kernel-version-specific. Adding a clarifying comment (or moving it to a more appropriate section) would avoid confusion when maintaining distro feature sets.
# Kernel 6.6
DISTRO_FEATURES:append = " kernel6-12"
DISTRO_FEATURES:append = " rdkb_configurable_wan_interface"
#Disable rdm-agent for reference platform
conf/include/rdk-bpi-bbmasks.inc:10
- This commented-out BBMASK line removes the code but doesn’t explain why the EasyMesh-specific rust mask was disabled; leaving disabled code in-place makes it hard to understand whether this is intentional or temporary. Prefer replacing it with a short rationale comment (or deleting it entirely if it’s no longer needed).
#BBMASK .= "${@bb.utils.contains('DISTRO_FEATURES','EasyMesh','|openembedded-core/meta/recipes-devtools/rust/','',d)}"
conf/include/rdk-bpi-ap-extender-bbmasks.inc:10
- Since the rust BBMASK was removed, it would help to document the intent here (e.g., that rust recipes must be available for the extender build). Otherwise it’s easy for future changes to reintroduce the mask and break the build again.
BBMASK .= "|meta-cmf-filogic/recipes-ccsp/ccsp/ccsp-one-wifi.bbappend"
Reason for change: Addressing build issues wrt to ccsp-common-library, picking wrynose rust version and patch issues Test Procedure: build package oss Risk : None Signed-off-by: ssiras826 <sandhyarani_sirasanagandla@comcast.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Suppressed comments (1)
conf/include/rdk-bpi-ap-extender-bbmasks.inc:37
|meta-filogic/recipes-wifi/hal/halinterface.bbappendis already masked earlier under theOneWificondition. Sincerdk-bpi-ap-extender.incunconditionally appendsOneWifi, the additional unconditional mask here is redundant and makes the mask list harder to maintain.
BBMASK .= "|meta-cmf-filogic/recipes-ccsp/hal/halinterface.bbappend"
BBMASK .= "|meta-filogic/recipes-wifi/hal/halinterface.bbappend"
Comment on lines
8
to
+10
| SRC_URI = "${CMF_GITHUB_ROOT}/broadband-utils;protocol=https;branch=develop" | ||
|
|
||
| S = "${WORKDIR}/git" | ||
| S = "${UNPACKDIR}/${PN}-${PV}" |
Comment on lines
8
to
+10
| SRC_URI = "${CMF_GITHUB_ROOT}/broadband-utils;protocol=https;branch=develop" | ||
|
|
||
| S = "${WORKDIR}/git" | ||
| S = "${UNPACKDIR}/${PN}-${PV}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Addressing build issues wrt to ccsp-common-library, patch issues
Test Procedure: build package oss
Risk : None