RDKB-66031: change fallback address source from Static to DHCP in lm_wrapper - #92
Merged
snayak002c merged 1 commit intoJul 28, 2026
Conversation
…CP in lm…" This reverts commit 8262cc9.
veeraputhiran-thangavel
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the LAN Manager wrapper’s fallback behavior for determining AddressSource so that when the code cannot conclusively identify a static/reserved mapping, it reports DHCP instead of incorrectly defaulting to Static. This aligns AddressSource with expected behavior when MAC randomization or missing reserved entries would otherwise misclassify the client.
Changes:
- Changed the fallback
AddressSourcevalue from"Static"to"DHCP"when no reserved/static determination is made.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
snayak002c
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: Resolves an issue where MAC address randomization caused the network configuration to switch from DHCP to Static. The address source now remains DHCP unless a custom static IP is set.
Test Procedure: Trigger a DHCP release from client and check AddressSource
Risks: Low
Priority: P2
Signed-off-by: Veeraputhiran_Thangavel@comcast.com