RDKB-65677 eliminate session_create leaks and strengthen regression coverage - #24
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses memory leaks in the session creation path and adds regression tests to ensure repeated session lifecycle calls behave as expected within the Duktape-based runtime.
Changes:
- Fix
session_create()leaks by handling allocation failures and freeing temporary/previously allocated session identifiers. - Add new gtest coverage for repeated
ccsp_session.create()calls and create/destroy cycles, including basic session ID format assertions. - Update the test build to compile/link the session implementation into the
parser_testbinary.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
source/jst_session.c |
Frees session_id and replaces/leak-proofs session_identifier during create(). |
tests/parser_test.cpp |
Adds regression tests for repeated create() calls and create/destroy cycles using a Duktape heap. |
tests/CMakeLists.txt |
Links jst_session.c into the test executable so the new tests can run. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
snayak002c
approved these changes
Jul 13, 2026
pavankumar464
changed the title
GoutamD2905
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.