RDKB-63696 CMXB7-6329 CPU & Load average spike and jst crash during stability test

source/jst_cosa.c

@@ -1,5 +1,5 @@
 /*
  If not stated otherwise in this file or this component's Licenses.txt file the
  following copyright and licenses apply:
 
  Copyright 2018 RDK Management
@@ -408,34 +408,65 @@
                 &pInstNumList
             );
 
-    if (iReturn != CCSP_SUCCESS)
+    if (iReturn != CCSP_SUCCESS || InstNum == 0 || pInstNumList == NULL)
     {
         //AnscTraceWarning("Failed on CcspBaseIf_GetNextLevelInstances, error code = %d.\n", iReturn);
         //RETURN_STRING("ERROR: Failed on CcspBaseIf_GetNextLevelInstances",1);
+        if (ppDestComponentName) { free(ppDestComponentName); ppDestComponentName = NULL; }
+        if (ppDestPath)          { free(ppDestPath);          ppDestPath = NULL; }
         RETURN_STRING("");
     }
 
-    for(loop1=0,loop2=0; loop1<(InstNum); loop1++) 
+    /* Build comma-separated instance list safely */
+    for (loop1 = 0, loop2 = 0; loop1 < InstNum; loop1++)
     {
-        len =sprintf(&format_s[loop2],"%d,", pInstNumList[loop1]);
-        loop2=loop2+len;
+        unsigned int prev_loop2 = loop2;
+
+        if (loop2 >= (int)(sizeof(format_s) - 1))
+        {
+            break;
+        }
+
+        len = snprintf(
+                &format_s[loop2],
+                sizeof(format_s) - loop2,
+                "%u,",
+                pInstNumList[loop1]);
+
+        if (len <= 0)
+        {
+            break;
+        }
+
+        if (len >= (int)(sizeof(format_s) - loop2))
+        {
+            /* Truncation: discard the partial write so only complete ids remain */
+            format_s[prev_loop2] = '\0';
+            loop2 = prev_loop2;
+            break;
+        }
+
+        loop2 += len;
     }
 
     if (pInstNumList)
     {
         free(pInstNumList);
     }
 
-    //Place NULL char at the end of string
-    if (loop2 >= 1)
+    if (ppDestComponentName) { free(ppDestComponentName); ppDestComponentName = NULL; }
+    if (ppDestPath)          { free(ppDestPath);          ppDestPath = NULL; }
+
+    /* Remove trailing comma safely */
+    if (loop2 > 0 && format_s[loop2 - 1] == ',')
     {
-        format_s[loop2-1]=0;
+        format_s[loop2 - 1] = '\0';
     }
     else
     {
-        format_s[0]=0;
-        CosaPhpExtLog("loop2-1 is less than zero in format_s[]\n");
+        format_s[loop2] = '\0';
     }
+
     RETURN_STRING(format_s);
 }