Release 2.5.0 - #63
Closed
bunnam988 wants to merge 4 commits into
Closed
Conversation
Release 2.4.0 2.4.0
## Summary Adds a 9-line caller workflow that runs the shared PR format check from `rdkcentral/build_tools_workflows`. **Depends on:** rdkcentral/build_tools_workflows#65 (merge that first) ## What it does Automatically checks every new/edited PR (including fork PRs) for: - Title format: `TICKET-123 : description` (multiple tickets supported) - Required description fields: Reason for change, Test Procedure, Risks, Priority **Fails** the check and posts a reminder comment if format is incorrect. Deletes the comment automatically when fixed. ## Files changed - `.github/workflows/pr-lint.yml` (9 lines — caller only, no logic)
…ow (#62) ## Summary Adds an explicit least-privilege `permissions` block to the PR Format Check caller workflow, resolving the CodeQL warning `actions/missing-workflow-permissions`. ```yaml permissions: contents: read pull-requests: write ``` Without this, the workflow inherits the repo/org default token permissions (potentially read-write). This restricts it to the minimum required. ## Files changed - `.github/workflows/pr-lint.yml`
|
📋 PR Format Reminder
Expected: |
There was a problem hiding this comment.
Pull request overview
Release PR to publish version 2.5.0, updating the project changelog and adding a GitHub Actions workflow to enforce PR formatting.
Changes:
- Add changelog entry for 2.5.0 and update 2.4.0 section content.
- Introduce a PR Format Check workflow that calls a reusable workflow from
rdkcentral/build_tools_workflows.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
CHANGELOG.md |
Adds the 2.5.0 release section and updates the 2.4.0 entry formatting/content. |
.github/workflows/pr-lint.yml |
Adds a PR-lint workflow using pull_request_target and a reusable workflow reference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+7
to
+11
| #### [2.5.0](https://github.com/rdkcentral/hotspot/compare/2.4.0...2.5.0) | ||
|
|
||
| - RDKB-66032 : Add explicit permissions block to PR Format Check workflow [`#62`](https://github.com/rdkcentral/hotspot/pull/62) | ||
| - Add PR Format Check workflow [`#59`](https://github.com/rdkcentral/hotspot/pull/59) | ||
| - Merge tag '2.4.0' into develop [`b6d33bd`](https://github.com/rdkcentral/hotspot/commit/b6d33bdb832a924fe19731f8ca8e711ad5d93f5d) |
Comment on lines
+16
to
+18
| jobs: | ||
| lint: | ||
| uses: rdkcentral/build_tools_workflows/.github/workflows/pr-lint.yml@develop |
Comment on lines
+17
to
+18
| lint: | ||
| uses: rdkcentral/build_tools_workflows/.github/workflows/pr-lint.yml@develop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 2.5.0