Restore develop firebolt-open-rpc.json

[swethasukumarr]

No description provided.

[Copilot]

Pull request overview

Updates the Firebolt OpenRPC specification JSON to match the intended “develop” state by reformatting portions of the schema, updating example payloads, and restoring missing method entries.

Changes:

• Reformats intent schemas (required and properties) to a multi-line style without changing semantics.
• Updates the Stats.memoryUsage example payload to byte-based field names/values.
• Adds/restore spec entries for Device.dolbyAtmosExperienceAvailable and Localization.timeZone.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Suppressed comments (3)

include/firebolt/actions.h:67

• This header is marked as auto-generated ("AUTO-GENERATED by fb-gen — DO NOT EDIT"). Manual formatting changes here are likely to be overwritten and can drift from generator output; please regenerate via fb-gen (or revert this change) instead of editing the generated file by hand.

    virtual Result<void> start(const IntentData& intent, std::optional<std::string> handlerAppId = std::nullopt) const = 0;

fmt.sh:8

• fmt.sh runs a pipeline (git ls-files | xargs clang-format) under set -e but without pipefail, so a failure in git ls-files could be masked by a successful xargs/clang-format run. Consider enabling -u and pipefail for more robust failure propagation.

set -e

fmt.sh:42

• Even with stricter options in the outer script, the actual formatting command runs inside a separate bash -c (local or in Docker). Add pipefail inside that bash -c snippet so failures in git ls-files are not masked by the pipeline exit status.

if [[ "${1:-}" == "--fix" ]]; then
    $RUN "set -e && git ls-files -- '*.cpp' '*.h' | xargs clang-format -i"
    echo "Done. Files reformatted."
else
    $RUN "set -e && git ls-files -- '*.cpp' '*.h' | xargs clang-format --dry-run --Werror"