Skip to content

RDKEMW-21724 : Update Actions module per Firebolt 9 spec - #92

Closed
swethasukumarr wants to merge 4 commits into
developfrom
feature/20911n
Closed

RDKEMW-21724 : Update Actions module per Firebolt 9 spec#92
swethasukumarr wants to merge 4 commits into
developfrom
feature/20911n

Conversation

@swethasukumarr

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings July 15, 2026 16:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Actions “intent” payload contract to treat the intent field as a JSON object (rather than a string), aligning tests and the OpenRPC spec with the updated wire format.

Changes:

  • Updated unit/component tests to validate intent as an object with nested fields (action, context.source).
  • Updated OpenRPC schema for Actions.intent and Actions.onIntent so intent is typed as an object (and constrained intentId to be non-negative).
  • Refreshed generated JSON type documentation comments to reflect the new payload shape.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
test/unit/actionsTest.cpp Adjusts unit test expectations to parse intent as an object and verify nested fields.
test/component/actionsGeneratedTest.cpp Updates component tests + event trigger payload to match the new intent object shape.
src/json_types/actions.h Updates the documentation comment describing the Actions intent wire format.
docs/openrpc/the-spec/firebolt-open-rpc.json Changes the OpenRPC schema/examples to declare intent as an object and enforce intentId >= 0.

Comment thread test/unit/actionsTest.cpp Outdated
Comment thread test/component/actionsGeneratedTest.cpp Outdated
Comment thread test/component/actionsGeneratedTest.cpp Outdated
Comment thread docs/openrpc/the-spec/firebolt-open-rpc.json
Comment thread docs/openrpc/the-spec/firebolt-open-rpc.json
Copilot AI review requested due to automatic review settings July 16, 2026 17:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Comment thread src/actions_impl.h Outdated
Comment thread src/json_types/actions.h
Comment thread src/actions_impl.cpp
@swethasukumarr swethasukumarr changed the title RDKEMW-20911 : Fix intent type as object and not string RDKEMW-21724 : Update Actions module per Firebolt 9 spec Jul 16, 2026
Copilot AI review requested due to automatic review settings July 16, 2026 19:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.

Comment thread src/actions_impl.cpp
Comment thread test/api_test_app/apis/actionsDemo.cpp
Comment thread include/firebolt/actions.h
Comment thread docs/openrpc/the-spec/firebolt-open-rpc.json
Comment thread docs/openrpc/the-spec/firebolt-open-rpc.json
Copilot AI review requested due to automatic review settings July 16, 2026 19:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Comment thread include/firebolt/actions.h
Comment thread docs/openrpc/the-spec/firebolt-open-rpc.json
Comment thread docs/openrpc/the-spec/firebolt-open-rpc.json
Comment thread test/api_test_app/apis/actionsDemo.cpp
Copilot AI review requested due to automatic review settings July 16, 2026 20:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Comment thread include/firebolt/actions.h
Comment thread docs/openrpc/the-spec/firebolt-open-rpc.json
Comment thread test/component/actionsGeneratedTest.cpp
Copilot AI review requested due to automatic review settings July 16, 2026 20:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Comment on lines 76 to +80
"properties": {
"intent": { "type": "string" },
"intentId": { "type": "integer" }
"intent": {
"type": "object"
},
"intentId": {
Comment on lines 138 to +142
"properties": {
"intent": { "type": "string" },
"intentId": { "type": "integer" }
"intent": {
"type": "object"
},
"intentId": {
Comment on lines +189 to +191
"schema": {
"type": "object"
}
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants