RDKEMW-22169:Updated version to 4.4.6 - #49
Open
RajaLucy wants to merge 13 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates this repository’s build and CI wiring to consume Thunder/ThunderTools release tag R4.4.6, aligning local dependency build scripts and GitHub Actions workflows with the intended patch-level dependency bump.
Changes:
- Bumped
ThunderToolsandThundergit refs toR4.4.6inbuild_dependencies.sh. - Updated
THUNDER_REFandThunderToolscheckoutreftoR4.4.6across L1/L2 workflows.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| build_dependencies.sh | Updates local dependency clone refs for Thunder/ThunderTools to R4.4.6. |
| .github/workflows/L2-tests.yml | Updates CI environment/checkout refs to use Thunder/ThunderTools R4.4.6. |
| .github/workflows/L2-tests-oop.yml | Updates CI environment/checkout refs to use Thunder/ThunderTools R4.4.6. |
| .github/workflows/L1-tests.yml | Updates CI environment/checkout refs to use Thunder/ThunderTools R4.4.6. |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
Suppressed comments (7)
.github/workflows/L2-tests.yml:113
- The workflow now checks out entservices-testframework from a mutable feature branch (feature/RDKEMW-22169). This reduces build reproducibility and can cause CI to change behavior over time. Prefer pinning to a release tag or a specific commit SHA (or promote this branch to a tag) once the needed patches are finalized.
ref: feature/RDKEMW-22169
.github/workflows/L2-tests-oop.yml:104
- The workflow now checks out entservices-testframework from a mutable feature branch (feature/RDKEMW-22169). This reduces build reproducibility and can cause CI to change behavior over time. Prefer pinning to a release tag or a specific commit SHA (or promote this branch to a tag) once the needed patches are finalized.
ref: feature/RDKEMW-22169
build_dependencies.sh:58
- This script now clones entservices-testframework from a mutable feature branch (feature/RDKEMW-22169). That makes builds less reproducible over time. Prefer pinning to a release tag or a specific commit SHA (or promote this branch to a tag) once the needed patches are finalized.
git clone --branch feature/RDKEMW-22169 https://github.com/rdkcentral/entservices-testframework.git
.github/workflows/L1-tests.yml:15
- This PR description says it updates Thunder/ThunderTools to 4.4.6, but this change also switches entservices-apis (INTERFACES_REF) from a pinned version to the moving "develop" branch. That makes builds less reproducible and is inconsistent with build_dependencies.sh still cloning entservices-apis at 4.0.8. Either pin INTERFACES_REF to a specific release/tag (and keep it consistent across scripts/workflows) or update the PR description to reflect the intended interfaces change.
REPO_NAME: "usersettings"
INTERFACES_REF: "develop"
AUTOMATICS_UNAME: ${{ secrets.AUTOMATICS_UNAME}}
.github/workflows/L2-tests.yml:14
- This PR description says it updates Thunder/ThunderTools to 4.4.6, but this change also switches entservices-apis (INTERFACES_REF) from a pinned version to the moving "develop" branch. That makes builds less reproducible and is inconsistent with build_dependencies.sh still cloning entservices-apis at 4.0.8. Either pin INTERFACES_REF to a specific release/tag (and keep it consistent across scripts/workflows) or update the PR description to reflect the intended interfaces change.
env:
BUILD_TYPE: Debug
INTERFACES_REF: "develop"
AUTOMATICS_UNAME: ${{ secrets.AUTOMATICS_UNAME}}
.github/workflows/L2-tests-oop.yml:14
- This PR description says it updates Thunder/ThunderTools to 4.4.6, but this change also switches entservices-apis (INTERFACES_REF) from a pinned version to the moving "develop" branch. That makes builds less reproducible and is inconsistent with build_dependencies.sh still cloning entservices-apis at 4.0.8. Either pin INTERFACES_REF to a specific release/tag (and keep it consistent across scripts/workflows) or update the PR description to reflect the intended interfaces change.
env:
BUILD_TYPE: Debug
INTERFACES_REF: "develop"
AUTOMATICS_UNAME: ${{ secrets.AUTOMATICS_UNAME}}
.github/workflows/L1-tests.yml:124
- The workflow now checks out entservices-testframework from a mutable feature branch (feature/RDKEMW-22169). This reduces build reproducibility and can cause CI to change behavior over time. Prefer pinning to a release tag or a specific commit SHA (or promote this branch to a tag) once the needed patches are finalized.
ref: feature/RDKEMW-22169
Comment on lines
11
to
15
| env: | ||
| BUILD_TYPE: Debug | ||
| REPO_NAME: "usersettings" | ||
| THUNDER_REF: "R4.4.1" | ||
| INTERFACES_REF: "4.0.8" | ||
| INTERFACES_REF: "develop" | ||
| AUTOMATICS_UNAME: ${{ secrets.AUTOMATICS_UNAME}} |
Comment on lines
11
to
15
| env: | ||
| BUILD_TYPE: Debug | ||
| THUNDER_REF: "R4.4.1" | ||
| INTERFACES_REF: "4.0.8" | ||
| INTERFACES_REF: "develop" | ||
| AUTOMATICS_UNAME: ${{ secrets.AUTOMATICS_UNAME}} | ||
| AUTOMATICS_PASSCODE: ${{ secrets. AUTOMATICS_PASSCODE}} |
Comment on lines
11
to
15
| env: | ||
| BUILD_TYPE: Debug | ||
| THUNDER_REF: "R4.4.1" | ||
| INTERFACES_REF: "4.0.8" | ||
| INTERFACES_REF: "develop" | ||
| AUTOMATICS_UNAME: ${{ secrets.AUTOMATICS_UNAME}} | ||
| AUTOMATICS_PASSCODE: ${{ secrets. AUTOMATICS_PASSCODE}} |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (10)
build_dependencies.sh:66
entservices-testframeworkis cloned from a moving feature branch (feature/RDKEMW-22169), which makes this build non-deterministic and risky for a patch/release workflow. Pin this to an immutable tag or commit SHA instead.
git clone --branch feature/RDKEMW-22169 https://github.com/rdkcentral/entservices-testframework.git
.github/workflows/L2-tests.yml:17
- The secret context has an extra space (
secrets. AUTOMATICS_PASSCODE), which will break expression evaluation in GitHub Actions.
INTERFACES_REF: "develop"
AUTOMATICS_UNAME: ${{ secrets.AUTOMATICS_UNAME}}
AUTOMATICS_PASSCODE: ${{ secrets. AUTOMATICS_PASSCODE}}
.github/workflows/L2-tests.yml:115
entservices-testframeworkis checked out from a moving feature branch (feature/RDKEMW-22169), making CI non-reproducible. For a patch release, pin to a tag or commit SHA.
ref: feature/RDKEMW-22169
.github/workflows/L2-tests.yml:119
entservices-persistentstoreis checked out twice to the same path in this job, which is redundant and adds unnecessary time/network traffic.
ref: feature/RDKEMW-22169
- name: Checkout entservices-persistentstore
uses: actions/checkout@v3
with:
.github/workflows/L1-tests.yml:18
- The secret context has an extra space (
secrets. AUTOMATICS_PASSCODE), which will break expression evaluation in GitHub Actions.
INTERFACES_REF: "develop"
AUTOMATICS_UNAME: ${{ secrets.AUTOMATICS_UNAME}}
AUTOMATICS_PASSCODE: ${{ secrets. AUTOMATICS_PASSCODE}}
.github/workflows/L2-tests-oop.yml:15
THUNDER_REFwas removed fromenv, but the workflow still uses${{ env.THUNDER_REF }}later (Checkout Thunder). This will fail at runtime. Also,secrets. AUTOMATICS_PASSCODEcontains an extra space which breaks expression evaluation.
env:
BUILD_TYPE: Debug
INTERFACES_REF: "develop"
AUTOMATICS_UNAME: ${{ secrets.AUTOMATICS_UNAME}}
AUTOMATICS_PASSCODE: ${{ secrets. AUTOMATICS_PASSCODE}}
build_dependencies.sh:60
entservices-apisis still pinned to4.0.8here, while CI workflows now useINTERFACES_REF: develop. This can lead to local builds behaving differently from CI; consider aligning the ref (or pinning both to the same immutable version).
cd Thunder
git checkout $THUNDER_COMMIT_SHA
cd ..
git clone --branch 4.0.8 https://github.com/rdkcentral/entservices-apis.git
.github/workflows/L1-tests.yml:66
INTERFACES_REFis set to the movingdevelopbranch, but the cache key only includes the literal branch name (develop). If caching is enabled later, the cache may be reused even afterdevelopadvances, leading to stale builds/tests. Consider pinningINTERFACES_REFto an immutable tag/SHA, or incorporating the checked-out commit SHA into the cache key.
key: ${{ runner.os }}-${{ env.REPO_NAME }}-${{ env.THUNDER_COMMIT_SHA }}-${{ env.INTERFACES_REF }}-4
.github/workflows/L1-tests.yml:126
entservices-testframeworkis checked out from a moving feature branch (feature/RDKEMW-22169), making CI non-reproducible. For a patch release, pin to a tag or commit SHA.
ref: feature/RDKEMW-22169
.github/workflows/L2-tests-oop.yml:104
entservices-testframeworkis checked out from a moving feature branch (feature/RDKEMW-22169), making CI non-reproducible. For a patch release, pin to a tag or commit SHA.
ref: feature/RDKEMW-22169
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (12)
.github/workflows/L2-tests.yml:17
- The secrets context expression has an extra space after
secrets.(${{ secrets. AUTOMATICS_PASSCODE}}), which is invalid GitHub Actions syntax and will preventAUTOMATICS_PASSCODEfrom being populated.
AUTOMATICS_PASSCODE: ${{ secrets. AUTOMATICS_PASSCODE}}
.github/workflows/L2-tests-oop.yml:17
- The secrets context expression has an extra space after
secrets.(${{ secrets. AUTOMATICS_PASSCODE}}), which is invalid GitHub Actions syntax and will preventAUTOMATICS_PASSCODEfrom being populated.
AUTOMATICS_PASSCODE: ${{ secrets. AUTOMATICS_PASSCODE}}
.github/workflows/L1-tests.yml:18
- The secrets context expression has an extra space after
secrets.(${{ secrets. AUTOMATICS_PASSCODE}}), which is invalid GitHub Actions syntax and will preventAUTOMATICS_PASSCODEfrom being populated.
AUTOMATICS_PASSCODE: ${{ secrets. AUTOMATICS_PASSCODE}}
build_dependencies.sh:91
- After removing the Thunder patch steps, these
cdcommands are now a no-op (cd Thunderimmediately followed bycd -) and can be removed to reduce noise.
cd Thunder
cd -
build_dependencies.sh:66
entservices-testframeworkis now cloned from a moving feature branch (feature/RDKEMW-22169). This can make builds non-reproducible if the branch changes; consider pinning to a tag or commit SHA (similar to Thunder/ThunderTools) for deterministic builds.
git clone --branch feature/RDKEMW-22169 https://github.com/rdkcentral/entservices-testframework.git
.github/workflows/L2-tests.yml:116
- This workflow now checks out
entservices-testframeworkfrom a moving feature branch (feature/RDKEMW-22169). For repeatable CI results, pin this to a tag or commit SHA.
- name: Checkout entservices-testframework
uses: actions/checkout@v3
with:
repository: rdkcentral/entservices-testframework
path: entservices-testframework
ref: feature/RDKEMW-22169
.github/workflows/L2-tests-oop.yml:107
- This workflow now checks out
entservices-testframeworkfrom a moving feature branch (feature/RDKEMW-22169). For repeatable CI results, pin this to a tag or commit SHA.
- name: Checkout entservices-testframework
uses: actions/checkout@v3
with:
repository: rdkcentral/entservices-testframework
path: entservices-testframework
ref: feature/RDKEMW-22169
build_dependencies.sh:73
- After removing the ThunderTools patch step, these
cdcommands are now a no-op (cd ThunderToolsimmediately followed bycd -) and can be removed to reduce noise.
This issue also appears on line 90 of the same file.
cd ThunderTools
cd -
.github/workflows/L1-tests.yml:127
- This workflow now checks out
entservices-testframeworkfrom a moving feature branch (feature/RDKEMW-22169). For repeatable CI results, pin this to a tag or commit SHA.
- name: Checkout entservices-testframework
uses: actions/checkout@v3
with:
repository: rdkcentral/entservices-testframework
path: entservices-testframework
ref: feature/RDKEMW-22169
.github/workflows/L1-tests.yml:16
INTERFACES_REFwas changed todevelop, which makes the CI dependency onrdkcentral/entservices-apisnon-deterministic and expands the PR scope beyond the stated Thunder/ThunderTools version bump. Consider pinningentservices-apisto a release tag/commit SHA (and keeping it consistent withbuild_dependencies.sh, which still clones--branch 4.0.8).
THUNDER_TOOLS_COMMIT_SHA: "d5dd83c7c19c49c7f25c558c126500bd2d64f7a4"
THUNDER_COMMIT_SHA: "2c0fcc5529e7da734be558ca6efa05d934dcce31"
INTERFACES_REF: "develop"
.github/workflows/L2-tests.yml:15
INTERFACES_REFwas changed todevelop, which makes the CI dependency onrdkcentral/entservices-apisnon-deterministic and expands the PR scope beyond the stated Thunder/ThunderTools version bump. Consider pinningentservices-apisto a release tag/commit SHA (and keeping it consistent withbuild_dependencies.sh, which still clones--branch 4.0.8).
THUNDER_TOOLS_COMMIT_SHA: "d5dd83c7c19c49c7f25c558c126500bd2d64f7a4"
THUNDER_COMMIT_SHA: "2c0fcc5529e7da734be558ca6efa05d934dcce31"
INTERFACES_REF: "develop"
.github/workflows/L2-tests-oop.yml:15
INTERFACES_REFwas changed todevelop, which makes the CI dependency onrdkcentral/entservices-apisnon-deterministic and expands the PR scope beyond the stated Thunder/ThunderTools version bump. Consider pinningentservices-apisto a release tag/commit SHA (and keeping it consistent withbuild_dependencies.sh, which still clones--branch 4.0.8).
THUNDER_TOOLS_COMMIT_SHA: "d5dd83c7c19c49c7f25c558c126500bd2d64f7a4"
THUNDER_COMMIT_SHA: "2c0fcc5529e7da734be558ca6efa05d934dcce31"
INTERFACES_REF: "develop"
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (6)
build_dependencies.sh:57
git checkoutarguments should be quoted to avoid word-splitting/globbing (even if currently unlikely with SHA values).
git checkout $THUNDER_COMMIT_SHA
build_dependencies.sh:66
- Cloning
entservices-testframeworkfrom a feature branch makes builds non-reproducible (branch can be force-pushed or deleted). Prefer pinning to an immutable tag or commit SHA (and optionally documenting the intended version).
git clone --branch feature/RDKEMW-22169 https://github.com/rdkcentral/entservices-testframework.git
.github/workflows/L1-tests.yml:18
INTERFACES_REFis changed todevelop, which makes CI consume moving interface definitions and also diverges frombuild_dependencies.sh(still clones entservices-apis4.0.8). Additionally,secrets. AUTOMATICS_PASSCODEincludes an extra space after the dot; usesecrets.AUTOMATICS_PASSCODEto avoid expression parse issues.
INTERFACES_REF: "develop"
AUTOMATICS_UNAME: ${{ secrets.AUTOMATICS_UNAME}}
AUTOMATICS_PASSCODE: ${{ secrets. AUTOMATICS_PASSCODE}}
.github/workflows/L2-tests.yml:17
INTERFACES_REFis changed todevelop, which makes CI consume moving interface definitions and also diverges frombuild_dependencies.sh(still clones entservices-apis4.0.8). Additionally,secrets. AUTOMATICS_PASSCODEincludes an extra space after the dot; usesecrets.AUTOMATICS_PASSCODEto avoid expression parse issues.
INTERFACES_REF: "develop"
AUTOMATICS_UNAME: ${{ secrets.AUTOMATICS_UNAME}}
AUTOMATICS_PASSCODE: ${{ secrets. AUTOMATICS_PASSCODE}}
.github/workflows/L2-tests-oop.yml:17
INTERFACES_REFis changed todevelop, which makes CI consume moving interface definitions and also diverges frombuild_dependencies.sh(still clones entservices-apis4.0.8). Additionally,secrets. AUTOMATICS_PASSCODEincludes an extra space after the dot; usesecrets.AUTOMATICS_PASSCODEto avoid expression parse issues.
INTERFACES_REF: "develop"
AUTOMATICS_UNAME: ${{ secrets.AUTOMATICS_UNAME}}
AUTOMATICS_PASSCODE: ${{ secrets. AUTOMATICS_PASSCODE}}
build_dependencies.sh:52
git checkoutarguments should be quoted to avoid word-splitting/globbing (even if currently unlikely with SHA values).
This issue also appears on line 57 of the same file.
git checkout $THUNDER_TOOLS_COMMIT_SHA
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (8)
.github/workflows/L2-tests-oop.yml:17
- The secret expression has an extra space (
secrets. AUTOMATICS_PASSCODE), which prevents GitHub Actions from resolving the secret value correctly.
AUTOMATICS_PASSCODE: ${{ secrets. AUTOMATICS_PASSCODE}}
build_dependencies.sh:66
entservices-testframeworkis cloned from a moving feature branch (feature/RDKEMW-22169), which makes builds non-reproducible and can change unexpectedly. Pin this dependency to a specific tag or commit SHA (similar to Thunder/ThunderTools) so CI and local builds are deterministic.
cd "$GITHUB_WORKSPACE"
git clone --branch feature/RDKEMW-22169 https://github.com/rdkcentral/entservices-testframework.git
build_dependencies.sh:62
entservices-apisis still pinned to--branch 4.0.8here, while the CI workflows in this PR switchINTERFACES_REFtodevelop. This can lead to different headers/JSONRPC interfaces between native builds and L1/L2 jobs. Align the reference across scripts/workflows (ideally pin to an immutable tag/commit).
cd ..
git clone --branch 4.0.8 https://github.com/rdkcentral/entservices-apis.git
cd ..
.github/workflows/L1-tests.yml:18
- The secret expression has an extra space (
secrets. AUTOMATICS_PASSCODE), which prevents GitHub Actions from resolving the secret value correctly.
AUTOMATICS_PASSCODE: ${{ secrets. AUTOMATICS_PASSCODE}}
.github/workflows/L2-tests.yml:17
- The secret expression has an extra space (
secrets. AUTOMATICS_PASSCODE), which prevents GitHub Actions from resolving the secret value correctly.
AUTOMATICS_PASSCODE: ${{ secrets. AUTOMATICS_PASSCODE}}
.github/workflows/L1-tests.yml:16
INTERFACES_REFis changed from a released/tagged version todevelop, but the PR description only mentions updating Thunder/ThunderTools to 4.4.6. Please confirm whether this interfaces change is required; if it is, update the PR description/risk assessment accordingly or pin to an immutable ref (tag/commit) to avoid CI drift.
INTERFACES_REF: "develop"
.github/workflows/L2-tests.yml:15
INTERFACES_REFis changed from a released/tagged version todevelop, but the PR description only mentions updating Thunder/ThunderTools to 4.4.6. Please confirm whether this interfaces change is required; if it is, update the PR description/risk assessment accordingly or pin to an immutable ref (tag/commit) to avoid CI drift.
INTERFACES_REF: "develop"
.github/workflows/L2-tests-oop.yml:15
INTERFACES_REFis changed from a released/tagged version todevelop, but the PR description only mentions updating Thunder/ThunderTools to 4.4.6. Please confirm whether this interfaces change is required; if it is, update the PR description/risk assessment accordingly or pin to an immutable ref (tag/commit) to avoid CI drift.
INTERFACES_REF: "develop"
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.
Suppressed comments (12)
cov_build.sh:80
USE_THUNDER_R4is used as a preprocessor switch inplugin/UserSettingsImplementation.h, but it is no longer defined in the compiler flags passed viaCMAKE_CXX_FLAGShere, whileTHUNDER_VERSION=4is still set. This mismatch can select the wrong code path for Thunder 4 builds.
-DENABLE_TELEMETRY_LOGGING -DUSE_IARMBUS \
-DENABLE_SYSTEM_GET_STORE_DEMO_LINK -DENABLE_DEEP_SLEEP \
-DENABLE_SET_WAKEUP_SRC_CONFIG -DENABLE_THERMAL_PROTECTION \
-DUSE_DRM_SCREENCAPTURE -DHAS_API_SYSTEM -DHAS_API_POWERSTATE \
-DHAS_RBUS -DDISABLE_SECURITY_TOKEN -DENABLE_DEVICE_MANUFACTURER_INFO -DTHUNDER_VERSION=4 -DTHUNDER_VERSION_MAJOR=4 -DTHUNDER_VERSION_MINOR=4" \
.github/workflows/L1-tests.yml:360
- This CMake invocation sets
THUNDER_VERSION=4but no longer definesUSE_THUNDER_R4in the compiler flags.USE_THUNDER_R4is used byplugin/UserSettingsImplementation.hto select the Thunder 4 code path, so it should be defined consistently for Thunder 4 builds.
-DCMAKE_CXX_FLAGS="
-DEXCEPTIONS_ENABLE=ON
-DTHUNDER_VERSION=4
-DTHUNDER_VERSION_MAJOR=4
-DTHUNDER_VERSION_MINOR=4
.github/workflows/L1-tests.yml:417
- This build config sets
THUNDER_VERSION=4but does not defineUSE_THUNDER_R4in the compiler flags.USE_THUNDER_R4gates Thunder 4-specific code inplugin/UserSettingsImplementation.h; without it, the build may compile/run against the wrong Thunder API behavior.
-DCMAKE_CXX_FLAGS="
-fprofile-arcs
-ftest-coverage
-DEXCEPTIONS_ENABLE=ON
-DTHUNDER_VERSION=4
-DTHUNDER_VERSION_MAJOR=4
-DTHUNDER_VERSION_MINOR=4
.github/workflows/L1-tests.yml:498
- This testframework build sets
THUNDER_VERSION=4but no longer definesUSE_THUNDER_R4in the compiler flags. SinceUSE_THUNDER_R4is used to select the Thunder 4 code path, it should be defined when building against Thunder 4.
-DCMAKE_CXX_FLAGS="
-fprofile-arcs
-ftest-coverage
-DEXCEPTIONS_ENABLE=ON
-DTHUNDER_VERSION=4
-DTHUNDER_VERSION_MAJOR=4
-DTHUNDER_VERSION_MINOR=4
.github/workflows/L2-tests.yml:361
- This CMake flags block sets
THUNDER_VERSION=4but does not defineUSE_THUNDER_R4.USE_THUNDER_R4is used as a compile-time switch inplugin/UserSettingsImplementation.hand should be defined for Thunder 4 builds to select the intended code path.
-DCMAKE_CXX_FLAGS="
-DEXCEPTIONS_ENABLE=ON
-fprofile-arcs
-ftest-coverage
-DTHUNDER_VERSION=4
-DTHUNDER_VERSION_MAJOR=4
-DTHUNDER_VERSION_MINOR=4
.github/workflows/L2-tests.yml:447
- This build sets
THUNDER_VERSION=4but does not defineUSE_THUNDER_R4in the compiler flags.USE_THUNDER_R4controls the Thunder 4-specific code path inplugin/UserSettingsImplementation.h, so it should be present for consistency and correctness.
-DCMAKE_CXX_FLAGS="
-DEXCEPTIONS_ENABLE=ON
-fprofile-arcs
-ftest-coverage
-DTHUNDER_VERSION=4
-DTHUNDER_VERSION_MAJOR=4
-DTHUNDER_VERSION_MINOR=4
.github/workflows/L2-tests.yml:530
- This testframework build sets
THUNDER_VERSION=4but no longer definesUSE_THUNDER_R4in the compiler flags. SinceUSE_THUNDER_R4selects the Thunder 4 code path, it should be defined when compiling against Thunder 4.
-DCMAKE_CXX_FLAGS="
-DEXCEPTIONS_ENABLE=ON
-fprofile-arcs
-ftest-coverage
-DTHUNDER_VERSION=4
-DTHUNDER_VERSION_MAJOR=4
-DTHUNDER_VERSION_MINOR=4
.github/workflows/L2-tests-oop.yml:384
- This CMake flags block sets
THUNDER_VERSION=4but does not defineUSE_THUNDER_R4.USE_THUNDER_R4is a compile-time switch used inplugin/UserSettingsImplementation.hand should be defined for Thunder 4 builds.
-DCMAKE_CXX_FLAGS="
-DEXCEPTIONS_ENABLE=ON
-fprofile-arcs
-ftest-coverage
-DTHUNDER_VERSION=4
-DTHUNDER_VERSION_MAJOR=4
-DTHUNDER_VERSION_MINOR=4
.github/workflows/L2-tests-oop.yml:469
- This build sets
THUNDER_VERSION=4but does not defineUSE_THUNDER_R4in the compiler flags.USE_THUNDER_R4controls the Thunder 4 code path inplugin/UserSettingsImplementation.h, so it should be defined for Thunder 4 builds.
-DCMAKE_CXX_FLAGS="
-DEXCEPTIONS_ENABLE=ON
-fprofile-arcs
-ftest-coverage
-DTHUNDER_VERSION=4
-DTHUNDER_VERSION_MAJOR=4
-DTHUNDER_VERSION_MINOR=4
.github/workflows/L2-tests-oop.yml:549
- This testframework build sets
THUNDER_VERSION=4but does not defineUSE_THUNDER_R4in the compiler flags. SinceUSE_THUNDER_R4is used as a compile-time selector for Thunder 4, it should be present when building against Thunder 4.
-DCMAKE_CXX_FLAGS="
-DEXCEPTIONS_ENABLE=ON
-fprofile-arcs
-ftest-coverage
-DTHUNDER_VERSION=4
-DTHUNDER_VERSION_MAJOR=4
-DTHUNDER_VERSION_MINOR=4
build_dependencies.sh:93
- This CMake configure command for Thunder ends with a trailing line-continuation ("") followed by a blank line, which causes the next
cmake --build ...line to be concatenated into the configure invocation and fail.
cmake -G Ninja -S Thunder -B build/Thunder \
build_dependencies.sh:73
- The ThunderTools CMake configure block below ends with a trailing line-continuation ("") followed by a blank line, which causes the next
cmake --build ...line to be concatenated into the configure command as an extra argument and can break the script.
# Build Thunder-Tools
echo "======================================================================================"
echo "buliding thunderTools"
cd ThunderTools
cd -
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason: Updated Thunder and ThunderTools version to 4.4.6.
Test Procedure: Refer ticket.
Risks: Medium.
Priority: P0.
Version: Patch.