Skip to content

RDKEMW-12937: Test PR to validate workflow #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
balav08 wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

RDKEMW-12937: Test PR to validate workflow #10

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2ed263e
Update UserSettingsImplementation.cpp
balav08 Mar 9, 2026
523e78d
Merge branch 'develop' into feature/RDKEMW-12937
MukeshkumarK Mar 19, 2026
619016b
Merge branch 'develop' into feature/RDKEMW-12937
RajaLucy Apr 15, 2026
867037d
Update UserSettingsImplementation.cpp
RajaLucy Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions plugin/UserSettingsImplementation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
* limitations under the License.
*/


Copilot AI Apr 20, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are now two consecutive blank lines between the license header and the first include. This appears inconsistent with nearby files (e.g., plugin/UserSettings.cpp keeps a single blank line before includes) and adds unnecessary whitespace—please drop the extra empty line.

Suggested change

Copilot uses AI. Check for mistakes.
#include "UserSettingsImplementation.h"
#include <sys/prctl.h>
#include <regex>
Expand All @@ -25,6 +26,7 @@
#include <fstream>
#include "tracing/Logging.h"


Copilot AI Mar 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds an extra blank line between the include block and the namespace, creating a whitespace-only change and making the diff noisier. Consider keeping a single blank line here for consistency with the surrounding style.

Suggested change

Copilot uses AI. Check for mistakes.

Copilot AI Apr 15, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds an extra blank line between the includes and the namespace declaration, creating a whitespace-only change and slightly reducing consistency with other files in this module (which typically have a single blank line here). Consider removing the extra empty line to keep diffs clean and formatting consistent.

Suggested change

Copilot uses AI. Check for mistakes.

Copilot AI Apr 20, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are now two consecutive blank lines between the include block and the start of the namespace. To keep formatting consistent and reduce diff noise, remove the extra empty line.

Suggested change

Copilot uses AI. Check for mistakes.
namespace WPEFramework {
namespace Plugin {

Expand Down
Loading