Skip to content

RDKEMW-13483: Integrate entservices-UserSettings into middleware builds #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agampa263 wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

RDKEMW-13483: Integrate entservices-UserSettings into middleware builds #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7485493
entservices-usersettings repo split
Feb 13, 2026
c00bf1e
L1, L2 tests yaml cleanup
Feb 13, 2026
54cbc4e
L2-test-oop yaml file cleanup
Feb 13, 2026
ef741cd
revert the helpers/UtilsFile.h removed earlier
Feb 16, 2026
90fadbf
usersettings plugin repo cleanup done
Feb 16, 2026
b9a4ebb
added subdirectory based on PLUGIN enable/disable
Feb 16, 2026
5048442
removed unnecessary files
Feb 16, 2026
7935e89
cleanup done
Feb 17, 2026
06a0849
modified the cmake files
Feb 17, 2026
196b259
edited test workflows
Feb 17, 2026
4095b7f
uncommented some compiler options
Feb 17, 2026
41a3330
workflows .yml files edited
Feb 17, 2026
567b9ab
L2 test workflow file modified
Feb 17, 2026
d830e23
L1, L2 test workflows edited
Feb 17, 2026
6f692c6
plugin name corrected
Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
# the repo. Unless a later match takes precedence,
# @global-owner1 and @global-owner2 will be requested for
# review when someone opens a pull request.
* @rdkcentral/rdke_ghec_entinfra_maintainer
* @rdkcentral/entservices-maintainers

Copilot AI Feb 17, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code owner team reference should be verified to ensure @rdkcentral/entservices-maintainers exists and has the appropriate permissions in the GitHub organization. This change affects who receives review requests for all files in the repository.

Copilot uses AI. Check for mistakes.
16 changes: 8 additions & 8 deletions .github/copilot-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,20 @@

When writing review comments based on custom instructions located in .github/instructions/**.instructions.md, include a direct GitHub link to the exact violated guideline in the respective instruction file. Use the following format:

Refer: https://github.com/rdkcentral/entservices-infra/blob/develop/.github/instructions/<instruction-file>.instructions.md#guideline-section-name
Refer: https://github.com/rdkcentral/entservices-usersettings/blob/develop/.github/instructions/<instruction-file>.instructions.md#guideline-section-name

## Examples

Refer: https://github.com/rdkcentral/entservices-infra/blob/develop/.github/instructions/Plugin.instructions.md#interface-implementation
Refer: https://github.com/rdkcentral/entservices-usersettings/blob/develop/.github/instructions/Plugin.instructions.md#interface-implementation

Refer: https://github.com/rdkcentral/entservices-infra/blob/develop/.github/instructions/Pluginlifecycle.instructions.md#deactivated
Refer: https://github.com/rdkcentral/entservices-usersettings/blob/develop/.github/instructions/Pluginlifecycle.instructions.md#deactivated

Refer: https://github.com/rdkcentral/entservices-infra/blob/develop/.github/instructions/Pluginimplementation.instructions.md#inter-plugin-communication
Refer: https://github.com/rdkcentral/entservices-usersettings/blob/develop/.github/instructions/Pluginimplementation.instructions.md#inter-plugin-communication

Refer: https://github.com/rdkcentral/entservices-infra/blob/develop/.github/instructions/Pluginmodule.instructions.md#module-name-convention
Refer: https://github.com/rdkcentral/entservices-usersettings/blob/develop/.github/instructions/Pluginmodule.instructions.md#module-name-convention

Refer: https://github.com/rdkcentral/entservices-infra/blob/develop/.github/instructions/Pluginconfig.instructions.md#plugin-configuration
Refer: https://github.com/rdkcentral/entservices-usersettings/blob/develop/.github/instructions/Pluginconfig.instructions.md#plugin-configuration

Refer: https://github.com/rdkcentral/entservices-infra/blob/develop/.github/instructions/Plugincmake.instructions.md#namespace-usage
Refer: https://github.com/rdkcentral/entservices-usersettings/blob/develop/.github/instructions/Plugincmake.instructions.md#namespace-usage

Refer: https://github.com/rdkcentral/entservices-infra/blob/develop/.github/instructions/PluginOnboardingCompliance.instructions.md#coverity-scan-inclusion-and-test-workflow-updates-for-new-plugins
Refer: https://github.com/rdkcentral/entservices-usersettings/blob/develop/.github/instructions/PluginOnboardingCompliance.instructions.md#coverity-scan-inclusion-and-test-workflow-updates-for-new-plugins
8 changes: 4 additions & 4 deletions .github/instructions/Plugin.instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ applyTo: "**/*.cpp,**/*.h"
---

# Instructions summary
1. [Interface Implementation](https://github.com/rdkcentral/entservices-infra/blob/develop/.github/instructions/Plugin.instructions.md#interface-implementation)
2. [Service Registration](https://github.com/rdkcentral/entservices-infra/blob/develop/.github/instructions/Plugin.instructions.md#service-registration)
3. [JSON-RPC Stub Registration](https://github.com/rdkcentral/entservices-infra/blob/develop/.github/instructions/Plugin.instructions.md#json-rpc-stub-registration)
4. [Handling Out-of-Process Plugin Failures](https://github.com/rdkcentral/entservices-infra/blob/develop/.github/instructions/Plugin.instructions.md#handling-out-of-process-plugin-failures)
1. [Interface Implementation](https://github.com/rdkcentral/entservices-usersettings/blob/develop/.github/instructions/Plugin.instructions.md#interface-implementation)
2. [Service Registration](https://github.com/rdkcentral/entservices-usersettings/blob/develop/.github/instructions/Plugin.instructions.md#service-registration)
3. [JSON-RPC Stub Registration](https://github.com/rdkcentral/entservices-usersettings/blob/develop/.github/instructions/Plugin.instructions.md#json-rpc-stub-registration)
4. [Handling Out-of-Process Plugin Failures](https://github.com/rdkcentral/entservices-usersettings/blob/develop/.github/instructions/Plugin.instructions.md#handling-out-of-process-plugin-failures)

### Interface Implementation

Expand Down
6 changes: 3 additions & 3 deletions .github/instructions/Pluginimplementation.instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ applyTo: "**/**Implementation.cpp,**/**Implementation.h,**/**.cpp,**/**.h"
---

# Instruction Summary
1. [Inter-Plugin Communication](https://github.com/rdkcentral/entservices-infra/blob/develop/.github/instructions/Pluginimplementation.instructions.md#inter-plugin-communication)
2. [On-Demand Plugin Interface Acquisition](https://github.com/rdkcentral/entservices-infra/blob/develop/.github/instructions/Pluginimplementation.instructions.md#on-demand-plugin-interface-acquisition)
1. [Inter-Plugin Communication](https://github.com/rdkcentral/entservices-usersettings/blob/develop/.github/instructions/Pluginimplementation.instructions.md#inter-plugin-communication)
2. [On-Demand Plugin Interface Acquisition](https://github.com/rdkcentral/entservices-usersettings/blob/develop/.github/instructions/Pluginimplementation.instructions.md#on-demand-plugin-interface-acquisition)

### Inter-Plugin Communication

Expand All @@ -14,7 +14,7 @@ Plugins should use COM-RPC (e.g., use QueryInterfaceByCallsign or QueryInterface

### Example

Telemetry Plugin accessing UserSettings(via COM-RPC) through the IShell Interface API **QueryInterfaceByCallsign()** exposed for each Plugin - (Refer https://github.com/rdkcentral/entservices-infra/blob/7988b8a719e594782f041309ce2d079cf6f52863/Telemetry/TelemetryImplementation.cpp#L160 )
Telemetry Plugin accessing UserSettings(via COM-RPC) through the IShell Interface API **QueryInterfaceByCallsign()** exposed for each Plugin - (Refer https://github.com/rdkcentral/entservices-usersettings/blob/7988b8a719e594782f041309ce2d079cf6f52863/Telemetry/TelemetryImplementation.cpp#L160 )

Copilot AI Feb 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example link appears to reference Telemetry/TelemetryImplementation.cpp inside entservices-usersettings, but this repository is being reduced to only UserSettings (Telemetry is not expected to live here). Update the reference to a stable location where the Telemetry example actually exists (e.g., the repo that owns Telemetry), or replace it with an in-repo example to avoid a dead/404 link.

Suggested change
Telemetry Plugin accessing UserSettings(via COM-RPC) through the IShell Interface API **QueryInterfaceByCallsign()** exposed for each Plugin - (Refer https://github.com/rdkcentral/entservices-usersettings/blob/7988b8a719e594782f041309ce2d079cf6f52863/Telemetry/TelemetryImplementation.cpp#L160 )
Telemetry Plugin accessing UserSettings(via COM-RPC) through the IShell Interface API **QueryInterfaceByCallsign()** exposed for each Plugin - (Refer https://github.com/rdkcentral/entservices-infra/blob/7988b8a719e594782f041309ce2d079cf6f52863/Telemetry/TelemetryImplementation.cpp#L160 )

Copilot uses AI. Check for mistakes.

```cpp
_userSettingsPlugin = _service->QueryInterfaceByCallsign<WPEFramework::Exchange::IUserSettings>(USERSETTINGS_CALLSIGN);
Expand Down
Loading
Loading