RDKEMW-22169:Updated version to 4.4.6 - #31
Open
RajaLucy wants to merge 16 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the pinned Thunder/ThunderTools release references used by local dependency build scripting and CI workflows to align with the 4.4.6 release tags.
Changes:
- Bump
ThunderToolsclone/checkout ref toR4.4.6in build script and CI workflows. - Bump
Thundercheckout ref (viaTHUNDER_REF) toR4.4.6in L1/L2 workflows. - Keep CI/build dependency sources aligned to the same Thunder release line.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
build_dependencies.sh |
Updates ThunderTools/Thunder clone branches to R4.4.6 for local dependency setup. |
.github/workflows/L1-tests.yml |
Updates CI env THUNDER_REF and ThunderTools checkout ref to R4.4.6. |
.github/workflows/L2-tests.yml |
Updates CI env THUNDER_REF and ThunderTools checkout ref to R4.4.6. |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
build_dependencies.sh:48
- Cloning
entservices-testframeworkfrom a moving feature branch (feature/RDKEMW-22169) makes local/native builds non-reproducible. Prefer pinning to an immutable tag or commit SHA so builds don’t change over time.
git clone --branch feature/RDKEMW-22169 https://github.com/rdkcentral/entservices-testframework.git
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (7)
.github/workflows/L1-tests.yml:17
AUTOMATICS_PASSCODEsecret reference has an extra dot/space (secrets. AUTOMATICS_PASSCODE), which will make the GitHub Actions expression invalid and leave the env var unset.
INTERFACES_REF: "develop"
AUTOMATICS_UNAME: ${{ secrets.AUTOMATICS_UNAME}}
AUTOMATICS_PASSCODE: ${{ secrets. AUTOMATICS_PASSCODE}}
.github/workflows/L2-tests.yml:16
AUTOMATICS_PASSCODEsecret reference has an extra dot/space (secrets. AUTOMATICS_PASSCODE), which will make the GitHub Actions expression invalid and leave the env var unset.
THUNDER_REF: "R4.4.6"
INTERFACES_REF: "develop"
AUTOMATICS_UNAME: ${{ secrets.AUTOMATICS_UNAME}}
AUTOMATICS_PASSCODE: ${{ secrets. AUTOMATICS_PASSCODE}}
build_dependencies.sh:48
entservices-testframeworkis now cloned from a feature branch (feature/RDKEMW-22169). Depending on a mutable feature branch can break reproducibility if it is force-pushed or deleted; prefer pinning to a release tag or an immutable commit SHA.
git clone --branch feature/RDKEMW-22169 https://github.com/rdkcentral/entservices-testframework.git
.github/workflows/L1-tests.yml:125
- Workflow now checks out
entservices-testframeworkfrom a feature branch (feature/RDKEMW-22169). Depending on a mutable feature branch can break reproducibility if it is force-pushed or deleted; prefer pinning to a release tag or an immutable commit SHA.
- name: Checkout entservices-testframework
uses: actions/checkout@v3
with:
repository: rdkcentral/entservices-testframework
path: entservices-testframework
ref: feature/RDKEMW-22169
.github/workflows/L1-tests.yml:15
INTERFACES_REFwas changed to the floatingdevelopbranch. This makes CI builds non-reproducible and can introduce unrelated breakages over time; consider pinning to a stable tag/commit (and keep it consistent withbuild_dependencies.sh, which still clonesentservices-apisat4.0.8).
THUNDER_REF: "R4.4.6"
INTERFACES_REF: "develop"
.github/workflows/L2-tests.yml:14
INTERFACES_REFwas changed to the floatingdevelopbranch. This makes CI builds non-reproducible and can introduce unrelated breakages over time; consider pinning to a stable tag/commit (and keep it consistent withbuild_dependencies.sh, which still clonesentservices-apisat4.0.8).
THUNDER_REF: "R4.4.6"
INTERFACES_REF: "develop"
.github/workflows/L2-tests.yml:115
- Workflow now checks out
entservices-testframeworkfrom a feature branch (feature/RDKEMW-22169). Depending on a mutable feature branch can break reproducibility if it is force-pushed or deleted; prefer pinning to a release tag or an immutable commit SHA.
- name: Checkout entservices-testframework
uses: actions/checkout@v3
with:
repository: rdkcentral/entservices-testframework
path: entservices-testframework
ref: feature/RDKEMW-22169
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (9)
.github/workflows/L1-tests.yml:127
- The workflow now pulls entservices-testframework from a feature branch, which is mutable and makes test results hard to reproduce. Prefer pinning to a tag or commit SHA (or promote the changes to a release tag) once validated.
- name: Checkout entservices-testframework
uses: actions/checkout@v3
with:
repository: rdkcentral/entservices-testframework
path: entservices-testframework
ref: feature/RDKEMW-22169
build_dependencies.sh:56
- This script now clones entservices-testframework from a feature branch. That branch can move, making builds non-reproducible. Prefer pinning to a specific commit SHA (or a release tag) once validated.
git clone --branch feature/RDKEMW-22169 https://github.com/rdkcentral/entservices-testframework.git
.github/workflows/L1-tests.yml:68
- The cache key covers build/ThunderTools, but it doesn’t include THUNDER_TOOLS_COMMIT_SHA. If ThunderTools changes while Thunder stays the same, the workflow can restore an incompatible cached ThunderTools build, leading to non-deterministic failures.
key: ${{ runner.os }}-${{ env.REPO_NAME }}-${{ env.THUNDER_COMMIT_SHA }}-${{ env.INTERFACES_REF }}-4
.github/workflows/L1-tests.yml:17
- INTERFACES_REF was switched to the moving "develop" branch, which makes CI non-reproducible and can introduce unrelated breakages. Consider pinning entservices-apis to a release tag or a specific commit SHA (similar to Thunder/ThunderTools) so reruns are deterministic.
THUNDER_REF: "R4.4.6"
INTERFACES_REF: "develop"
.github/workflows/L1-tests.yml:17
- THUNDER_REF is no longer referenced (checkout uses THUNDER_COMMIT_SHA). Keeping an unused env var can be misleading when debugging version mismatches.
THUNDER_TOOLS_COMMIT_SHA: "d5dd83c7c19c49c7f25c558c126500bd2d64f7a4"
THUNDER_COMMIT_SHA: "2c0fcc5529e7da734be558ca6efa05d934dcce31"
THUNDER_REF: "R4.4.6"
INTERFACES_REF: "develop"
.github/workflows/L2-tests.yml:16
- INTERFACES_REF was switched to the moving "develop" branch, which makes CI non-reproducible and can introduce unrelated breakages. Consider pinning entservices-apis to a release tag or a specific commit SHA so reruns are deterministic.
THUNDER_REF: "R4.4.6"
INTERFACES_REF: "develop"
.github/workflows/L2-tests.yml:117
- The workflow now pulls entservices-testframework from a feature branch, which is mutable and makes test results hard to reproduce. Prefer pinning to a tag or commit SHA once validated.
- name: Checkout entservices-testframework
uses: actions/checkout@v3
with:
repository: rdkcentral/entservices-testframework
path: entservices-testframework
ref: feature/RDKEMW-22169
.github/workflows/L2-tests.yml:16
- THUNDER_REF is no longer referenced (checkout uses THUNDER_COMMIT_SHA). Keeping an unused env var can be misleading when debugging version mismatches.
THUNDER_TOOLS_COMMIT_SHA: "d5dd83c7c19c49c7f25c558c126500bd2d64f7a4"
THUNDER_COMMIT_SHA: "2c0fcc5529e7da734be558ca6efa05d934dcce31"
THUNDER_REF: "R4.4.6"
INTERFACES_REF: "develop"
build_dependencies.sh:50
- The workflows now build entservices-apis from the moving "develop" branch, but this script still clones entservices-apis from the fixed 4.0.8 tag. That inconsistency can cause CI vs local build differences; align both to the same pinned ref (tag or commit SHA) to keep results reproducible.
cd Thunder
git checkout $THUNDER_COMMIT_SHA
cd ..
git clone --branch 4.0.8 https://github.com/rdkcentral/entservices-apis.git
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
Suppressed comments (7)
.github/workflows/L1-tests.yml:127
- The workflow is now pinning
entservices-testframeworkto a feature branch (feature/RDKEMW-22169). Feature branches can be rebased/force-pushed or deleted, which can break CI reproducibility; prefer a tag or commit SHA (and update the PR description if this dependency change is intended).
repository: rdkcentral/entservices-testframework
path: entservices-testframework
ref: feature/RDKEMW-22169
.github/workflows/L2-tests.yml:116
- The workflow is now pinning
entservices-testframeworkto a feature branch (feature/RDKEMW-22169). Feature branches can be rebased/force-pushed or deleted, which can break CI reproducibility; prefer a tag or commit SHA (and update the PR description if this dependency change is intended).
repository: rdkcentral/entservices-testframework
path: entservices-testframework
ref: feature/RDKEMW-22169
build_dependencies.sh:56
entservices-testframeworkis cloned from a feature branch (feature/RDKEMW-22169). For reproducible dependency builds, prefer cloning a tag or checking out a specific commit SHA (and keep this aligned with the workflows).
git clone --branch feature/RDKEMW-22169 https://github.com/rdkcentral/entservices-testframework.git
.github/workflows/L1-tests.yml:16
THUNDER_REFis defined but not referenced anywhere else in this workflow (Thunder is checked out viaTHUNDER_COMMIT_SHA). Keeping an unused version variable is confusing and risks drifting from the pinned SHA.
THUNDER_TOOLS_COMMIT_SHA: "d5dd83c7c19c49c7f25c558c126500bd2d64f7a4"
THUNDER_COMMIT_SHA: "2c0fcc5529e7da734be558ca6efa05d934dcce31"
THUNDER_REF: "R4.4.6"
.github/workflows/L1-tests.yml:17
INTERFACES_REFis changed to the movingdevelopbranch, which makes CI results non-reproducible and goes beyond the PR’s stated scope (Thunder/ThunderTools version bump). Prefer pinning to a release tag or a specific commit SHA.
INTERFACES_REF: "develop"
.github/workflows/L2-tests.yml:15
THUNDER_REFis defined but not referenced anywhere else in this workflow (Thunder is checked out viaTHUNDER_COMMIT_SHA). Keeping an unused version variable is confusing and risks drifting from the pinned SHA.
THUNDER_TOOLS_COMMIT_SHA: "d5dd83c7c19c49c7f25c558c126500bd2d64f7a4"
THUNDER_COMMIT_SHA: "2c0fcc5529e7da734be558ca6efa05d934dcce31"
THUNDER_REF: "R4.4.6"
.github/workflows/L2-tests.yml:16
INTERFACES_REFis changed to the movingdevelopbranch, which makes CI results non-reproducible and goes beyond the PR’s stated scope (Thunder/ThunderTools version bump). Prefer pinning to a release tag or a specific commit SHA.
INTERFACES_REF: "develop"
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (10)
.github/workflows/L1-tests.yml:128
- The workflow now checks out
entservices-testframeworkfrom a feature branch (feature/RDKEMW-22169). That can change over time and break repeatability; prefer pinning to a tag or commit SHA (similar to Thunder/ThunderTools).
- name: Checkout entservices-testframework
uses: actions/checkout@v3
with:
repository: rdkcentral/entservices-testframework
path: entservices-testframework
ref: feature/RDKEMW-22169
build_dependencies.sh:56
entservices-testframeworkis now cloned from a feature branch (feature/RDKEMW-22169). For reproducible local builds, prefer pinning to a tag or commit SHA (similar to the Thunder/ThunderTools pinning added above).
git clone --branch feature/RDKEMW-22169 https://github.com/rdkcentral/entservices-testframework.git
.github/workflows/L2-tests.yml:15
THUNDER_REFis defined but never referenced in this workflow (Thunder checkout usesTHUNDER_COMMIT_SHA). Keeping unused env vars increases drift/confusion; either remove it or use it consistently.
THUNDER_REF: "R4.4.6"
.github/workflows/L1-tests.yml:16
THUNDER_REFis defined but never referenced in this workflow (Thunder checkout usesTHUNDER_COMMIT_SHA, and cache keys no longer useTHUNDER_REF). Keeping unused env vars increases drift/confusion; either remove it or use it consistently.
THUNDER_REF: "R4.4.6"
plugin/CMakeLists.txt:90
- The new
write_config(PLUGINS ${PLUGIN_NAME})invocation uses a different argument pattern than the otherwrite_config(...)usage in this repo (e.g.,Tests/L1Tests/CMakeLists.txt:132still callswrite_config(${PLUGIN_NAME})). If the macro signature changed in Thunder/ThunderTools 4.4.6, all call sites should be updated consistently; if it didn’t, this new call may break configuration generation.
write_config(PLUGINS ${PLUGIN_NAME})
.github/workflows/L1-tests.yml:17
INTERFACES_REFwas changed from a pinned release todevelop, which makes CI builds non-reproducible and also diverges frombuild_dependencies.sh(still cloningentservices-apisat4.0.8). If this PR’s scope is only Thunder/ThunderTools 4.4.6, consider keeping interfaces pinned (or switch to a specific commit SHA).
This issue also appears on line 16 of the same file.
THUNDER_REF: "R4.4.6"
INTERFACES_REF: "develop"
.github/workflows/L1-tests.yml:412
- The entservices-avinput build no longer defines the
USE_THUNDER_R4compile-time macro, but the plugin sources and CMake logic still branch on it (e.g.,plugin/AVInputImplementation.huses#ifndef USE_THUNDER_R4, andplugin/CMakeLists.txtusesif (USE_THUNDER_R4)). Re-introduce the macro (and ideally the CMake cache variable) so the build matches the intended Thunder 4.4.x configuration.
-DCMAKE_INSTALL_PREFIX="$GITHUB_WORKSPACE/install/usr"
-DCMAKE_MODULE_PATH="$GITHUB_WORKSPACE/install/tools/cmake"
-DCMAKE_CXX_FLAGS="
-fprofile-arcs
-ftest-coverage
.github/workflows/L2-tests.yml:16
INTERFACES_REFwas changed todevelop, which makes CI builds non-reproducible and diverges frombuild_dependencies.sh(still cloningentservices-apisat4.0.8). Ifdevelopis required for compatibility, consider pinning to a specific commit SHA instead.
This issue also appears on line 15 of the same file.
THUNDER_REF: "R4.4.6"
INTERFACES_REF: "develop"
.github/workflows/L2-tests.yml:117
- The workflow now checks out
entservices-testframeworkfrom a feature branch (feature/RDKEMW-22169). For repeatable CI, prefer pinning to a tag or commit SHA (similar to Thunder/ThunderTools).
- name: Checkout entservices-testframework
uses: actions/checkout@v3
with:
repository: rdkcentral/entservices-testframework
path: entservices-testframework
ref: feature/RDKEMW-22169
.github/workflows/L2-tests.yml:474
- The entservices-avinput build does not define the
USE_THUNDER_R4compile-time macro, but the plugin sources and CMake logic still branch on it. Re-introduce the macro (and ideally the CMake cache variable) so the build matches the intended Thunder 4.4.x configuration.
-DCMAKE_TOOLCHAIN_FILE="${{ env.TOOLCHAIN_FILE }}"
-DCMAKE_INSTALL_PREFIX="$GITHUB_WORKSPACE/install/usr"
-DCMAKE_MODULE_PATH="$GITHUB_WORKSPACE/install/tools/cmake"
-DHIDE_NON_EXTERNAL_SYMBOLS=OFF
-DCMAKE_CXX_FLAGS="
-DEXCEPTIONS_ENABLE=ON
-fprofile-arcs
-ftest-coverage
-DTHUNDER_VERSION=4
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Suppressed comments (5)
.github/workflows/L1-tests.yml:19
- GitHub expression context lookup is invalid due to the space after
secrets.; this will not resolve the secret at runtime.
AUTOMATICS_PASSCODE: ${{ secrets. AUTOMATICS_PASSCODE}}
.github/workflows/L2-tests.yml:18
- GitHub expression context lookup is invalid due to the space after
secrets.; this will not resolve the secret at runtime.
AUTOMATICS_PASSCODE: ${{ secrets. AUTOMATICS_PASSCODE}}
.github/workflows/L1-tests.yml:127
- Checking out entservices-testframework from a moving feature branch reduces build reproducibility; if the branch is rebased/updated, historical workflow runs can no longer be reproduced. Prefer pinning to an immutable tag or a specific commit SHA (similar to how Thunder/ThunderTools are pinned).
ref: feature/RDKEMW-22169
build_dependencies.sh:56
- Cloning entservices-testframework from a moving feature branch makes local builds non-reproducible over time. Consider pinning to a specific commit SHA (as is done for Thunder/ThunderTools above) so future runs build the same dependency set.
git clone --branch feature/RDKEMW-22169 https://github.com/rdkcentral/entservices-testframework.git
.github/workflows/L2-tests.yml:116
- Checking out entservices-testframework from a moving feature branch reduces build reproducibility; if the branch is rebased/updated, historical workflow runs can no longer be reproduced. Prefer pinning to an immutable tag or a specific commit SHA (similar to how Thunder/ThunderTools are pinned).
ref: feature/RDKEMW-22169
| install(TARGETS ${MODULE_NAME} DESTINATION lib/${STORAGE_DIRECTORY}/plugins) | ||
|
|
||
| write_config(${PLUGIN_NAME}) | ||
| write_config(PLUGINS ${PLUGIN_NAME}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason: Updated Thunder and ThunderTools version to 4.4.6.
Test Procedure: Refer ticket.
Risks: Medium.
Priority: P0.
Version: Patch