Update cov_build.sh - #96
Open
Abhinavpv28 wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Coverity build helper script to change how common_utilities is fetched/built as part of the dependency setup.
Changes:
- Switch
common_utilitiesclone from a specific feature branch to the default branch. - Update the
common_utilities./configureoptions to include--enable-mountutils.
| cd common_utilities | ||
| autoreconf -i | ||
| ./configure --enable-rdkcertselector --prefix=${INSTALL_DIR} CFLAGS="-Wno-stringop-truncation -DL2_TEST_ENABLED -DRDK_LOGGER" | ||
| ./configure --enable-rdkcertselector --enable-mountutils -DL2_TEST_ENABLED -DRDK_LOGGER" |
| @@ -55,10 +55,10 @@ cp include/*.h /usr/local/include | |||
| sh build_inside_container.sh | |||
|
|
|||
| cd ${ROOT} | |||
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the cov_build.sh dependency build step for common_utilities, switching to cloning the default branch and adjusting the configure options used when building that dependency.
Changes:
- Update
git cloneofcommon_utilitiesto no longer pin tofeature/upload_L2. - Change the
common_utilities./configureinvocation (adds--enable-mountutilsand alters how flags are passed).
| cd common_utilities | ||
| autoreconf -i | ||
| ./configure --enable-rdkcertselector --prefix=${INSTALL_DIR} CFLAGS="-Wno-stringop-truncation -DL2_TEST_ENABLED -DRDK_LOGGER" | ||
| ./configure --enable-rdkcertselector --enable-mountutils CFLAGS="-DL2_TEST_ENABLED -DRDK_LOGGER" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.