RDK-57502 - [RDKE] Migrate Operation Support Log Upload Related Scrip… by Abhinavpv28 · Pull Request #46 · rdkcentral/dcm-agent

Abhinavpv28 · 2026-01-07T12:59:07Z

…ts To C Implementation (#35)

Created a comprehensive L2 test suite with 6 test modules covering error handling, normal uploads, retry logic, security, resource management, and upload strategies Updated build scripts and CI/CD workflow to compile with L2_TEST_ENABLED flag and execute the new test suite

This feature file contains scenarios for normal log uploads, large log file handling, and MD5 checksum verification for the uploadSTBLogs service.

…ts To C Implementation (#35) * Created a comprehensive L2 test suite with 6 test modules covering error handling, normal uploads, retry logic, security, resource management, and upload strategies Updated build scripts and CI/CD workflow to compile with L2_TEST_ENABLED flag and execute the new test suite This feature file contains scenarios for normal log uploads, large log file handling, and MD5 checksum verification for the uploadSTBLogs service.

Copilot

Pull request overview

This PR migrates operation support log upload scripts from shell to C implementation and adds a comprehensive L2 test suite with 6 test modules covering error handling, normal uploads, retry logic, security, resource management, and upload strategies. The implementation includes conditional compilation for test environments and updates to build scripts and CI/CD workflows.

Key Changes

Added L2_TEST_ENABLED conditional compilation to skip sleep() calls in test environments for faster test execution
Created comprehensive L2 test infrastructure with 6 pytest modules and corresponding BDD feature files
Updated build scripts (cov_build.sh) and CI/CD workflow to compile with test flags and execute the new test suite

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 82 comments.

Show a summary per file

File	Description
`uploadstblogs/src/strategy_reboot.c`	Added conditional compilation guards around sleep() calls to skip delays during L2 testing
`test/run_uploadstblogs_l2.sh`	New test runner script that sets up test environment and executes all 6 L2 test suites
`test/functional-tests/tests/uploadstblogs_helper.py`	New helper module with 260 lines of utility functions for test setup, log analysis, and resource management
`test/functional-tests/tests/test_uploadstblogs_upload_strategies.py`	Test module for upload strategies (on-demand, reboot, DCM scheduled, RBUS integration)
`test/functional-tests/tests/test_uploadstblogs_security.py`	Security test module covering mTLS authentication, SSL validation, and path security
`test/functional-tests/tests/test_uploadstblogs_retry_logic.py`	Test module for network failure handling, retry attempts, and server error responses
`test/functional-tests/tests/test_uploadstblogs_resource_management.py`	Resource management tests covering cleanup, memory management, and concurrent requests
`test/functional-tests/tests/test_uploadstblogs_normal_upload.py`	Test module for normal upload operations and large file handling
`test/functional-tests/tests/test_uploadstblogs_error_handling.py`	Error handling tests for invalid configuration, size limits, and empty logs
`test/functional-tests/features/*.feature`	BDD feature files corresponding to each test module
`cov_build.sh`	Updated to clone feature/upload_L2 branch and compile with L2_TEST_ENABLED flag
`.github/workflows/L2-tests.yml`	Updated CI/CD workflow to execute uploadstblogs L2 tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-07T13:09:06Z

@@ -0,0 +1,86 @@
+####################################################################################
+# If not stated otherwise in this file or this component's Licenses


Incomplete copyright header - line 2 is missing "file the" text. The header should read "If not stated otherwise in this file or this component's Licenses file the" but it currently says "If not stated otherwise in this file or this component's Licenses"

Add the missing text to match the standard copyright header format used in other files.

Suggested change

# If not stated otherwise in this file or this component's Licenses

# If not stated otherwise in this file or this component's Licenses file the

Copilot · 2026-01-07T13:09:06Z

@@ -0,0 +1,48 @@
+####################################################################################
+# If not stated otherwise in this file or this component's Licenses


Incomplete copyright header - line 2 is missing "file the" text. The header should read "If not stated otherwise in this file or this component's Licenses file the" but it currently says "If not stated otherwise in this file or this component's Licenses"

Add the missing text to match the standard copyright header format used in other files.

Suggested change

# If not stated otherwise in this file or this component's Licenses

# If not stated otherwise in this file or this component's Licenses file the

Copilot · 2026-01-07T13:09:06Z

 cd telemetry
 cp include/*.h /usr/local/include
-sh  build_inside_container.sh 
+sh  build_inside_container.sh


Trailing whitespace at the end of the line. This should be removed for cleaner code formatting.

Copilot · 2026-01-07T13:09:07Z

+cd /usr/common_utilities
+sed -i '/file_upload\.sslverify/s/= 1;/= 0;/' uploadutils/mtls_upload.c
+sed -i 's/\(ret_code = setCommonCurlOpt(curl, s3url, NULL, \)true\()\)/\1false\2/g' uploadutils/uploadUtil.c
+sed -i '/if (auth) {/,/}/s/^/\/\/ /' uploadutils/uploadUtil.c
+cd -
+
+echo pwd
+
+# Create log directories


These sed commands modify source code in a different repository (common_utilities) during test execution. This is a security and maintainability issue because:

It modifies source code outside this repository at runtime, making the test behavior unpredictable and dependent on external code structure

The modifications disable SSL verification and authentication, which are critical security features

If the external code structure changes, these sed commands could silently fail or produce incorrect modifications

This makes it difficult to reproduce test results consistently

Consider using proper mocking/stubbing mechanisms or test-specific build configurations instead of runtime source code modifications.

Suggested change

cd /usr/common_utilities

sed -i '/file_upload\.sslverify/s/= 1;/= 0;/' uploadutils/mtls_upload.c

sed -i 's/\(ret_code = setCommonCurlOpt(curl, s3url, NULL, \)true\()\)/\1false\2/g' uploadutils/uploadUtil.c

sed -i '/if (auth) {/,/}/s/^/\/\/ /' uploadutils/uploadUtil.c

cd -

echo pwd

# Create log directories

# NOTE: Do not modify external common_utilities source here.

# Any SSL/authentication behavior changes for tests should be handled via

# configuration, mocking, or test-specific builds, not in-place sed edits.

echo pwd

# Create log directories

# Create log directories

Copilot · 2026-01-07T13:09:07Z

+            for chunk in iter(lambda: f.read(4096), b""):
+                md5_hash.update(chunk)
+        return md5_hash.hexdigest()
+    except:


The bare except clause catches all exceptions including system exits and keyboard interrupts. This makes debugging difficult and can hide serious issues.

Replace with a more specific exception handler like except (OSError, IOError): or except Exception as e: to allow system exceptions to propagate.

Suggested change

except:

except OSError:

Copilot · 2026-01-07T13:09:27Z

+import time
+import subprocess as sp
+from uploadstblogs_helper import *
+from helper_functions import *


Import pollutes the enclosing namespace, as the imported module helper_functions does not define 'all'.

Copilot · 2026-01-07T13:09:28Z

+"""
+
+import pytest
+import time


Import of 'time' is not used.

Copilot · 2026-01-07T13:09:28Z

+"""
+
+import pytest
+import time


Import of 'time' is not used.

Copilot · 2026-01-07T13:09:28Z

+"""
+
+import pytest
+import time


Import of 'time' is not used.

Copilot · 2026-01-07T13:09:28Z

+import os
+import time
+import re
+import json


Import of 'json' is not used.

…ts To C Implementation (#49) * Simplify some pieces of code over engineered by AI models. * Update run_uploadstblogs_l2.sh for L2 coverage --------- Co-authored-by: Abhinav P V <Abhinav_Valappil@comcast.com>

…ts To C Implementation (#51) * Remove logging of response URLs * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Shibu Kakkoth Vayalambron <shibu.kakkoth@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot · 2026-01-13T18:18:41Z

+    if (ctx->rrd_flag == 0) {
    // Check PREV_LOG_PATH - critical for upload (matches script behavior)
-    if (strlen(ctx->paths.prev_log_path) > 0) {
-        if (!dir_exists(ctx->paths.prev_log_path)) {
-            RDK_LOG(RDK_LOG_ERROR, LOG_UPLOADSTB, "[%s:%d] The Previous Logs folder is missing: %s\n", 
-                    __FUNCTION__, __LINE__, ctx->paths.prev_log_path);
+        if (strlen(ctx->prev_log_path) > 0) {
+            if (!dir_exists(ctx->prev_log_path)) {
+                RDK_LOG(RDK_LOG_ERROR, LOG_UPLOADSTB, "[%s:%d] The Previous Logs folder is missing: %s\n", 
+                        __FUNCTION__, __LINE__, ctx->prev_log_path);
            // Script sends MAINT_LOGUPLOAD_ERROR=5 when PREV_LOG_PATH is missing
-            emit_folder_missing_error();
-            all_valid = false;
-        } else {
-            RDK_LOG(RDK_LOG_DEBUG, LOG_UPLOADSTB, "[%s:%d] PREV_LOG_PATH exists: %s\n", 
-                    __FUNCTION__, __LINE__, ctx->paths.prev_log_path);
+                emit_folder_missing_error();
+                all_valid = false;
+             } else {
+                RDK_LOG(RDK_LOG_DEBUG, LOG_UPLOADSTB, "[%s:%d] PREV_LOG_PATH exists: %s\n", 
+                        __FUNCTION__, __LINE__, ctx->prev_log_path);
+            }
        }
    }


The structure flattening from nested structs (ctx.paths.log_path) to flat fields (ctx.log_path) is inconsistently applied. In validation.c line 85, there's a condition if (ctx->rrd_flag == 0) wrapping the PREV_LOG_PATH validation. This condition was not present in the original code and changes the validation logic. The PREV_LOG_PATH validation should run unconditionally as it did before, not only when rrd_flag is 0.

Copilot · 2026-01-13T18:18:41Z

+        result = run_uploadstblogs()
+
+        # Check for telemetry markers
+        telemetry_logs = grep_uploadstb_logs_regex(r"telemetry|marker|warning")


Variable telemetry_logs is not used.

Suggested change

telemetry_logs = grep_uploadstb_logs_regex(r"telemetry|marker|warning")

telemetry_logs = grep_uploadstb_logs_regex(r"telemetry|marker|warning")

assert telemetry_logs, "Expected telemetry markers in uploadSTB logs"

Copilot · 2026-01-13T18:18:42Z

+        result = run_uploadstblogs()
+
+        # Check for informative message
+        logs = grep_uploadstb_logs_regex(r"no.*file|empty|nothing to upload")


Variable logs is not used.

Copilot · 2026-01-13T18:18:42Z

+
+        # Should not attempt upload
+        upload_logs = grep_uploadstb_logs_regex(r"upload.*success|uploading|HTTP")
+        # Might not see upload attempts


Variable upload_logs is not used.

Suggested change

# Might not see upload attempts

# Verify that no upload-related log entries are present

assert len(upload_logs) == 0, "Should not attempt upload when no log files are available"

…ts To C Implementation (#54) * Update cov_build.sh to enable the rdkcertselector feature in the common_utilities build configuration to support the migration of operation support log upload scripts to C implementation. The change is part of resolving L2 test failures.

Copilot

Pull request overview

Copilot reviewed 61 out of 62 changed files in this pull request and generated 26 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-21T19:08:37Z

+        # Check for configuration error detection
+        error_logs = grep_uploadstb_logs_regex(r"ERROR|error|fail.*properties|invalid")
+        # Should handle gracefully
+        assert result.returncode in [0, 1], "Should detect corrupted config"


Variable error_logs is not used.

Suggested change

assert result.returncode in [0, 1], "Should detect corrupted config"

assert result.returncode in [0, 1], "Should detect corrupted config"

assert len(error_logs) > 0 or result.returncode != 0, "Configuration errors should be logged"

Copilot · 2026-01-21T19:08:38Z

+        result = run_uploadstblogs()
+
+        # Check for size-related logs
+        logs = grep_uploadstb_logs_regex(r"size|large|limit|truncate")


Copilot · 2026-01-21T19:08:38Z

+
+        # Should not attempt upload
+        upload_logs = grep_uploadstb_logs_regex(r"upload.*success|uploading|HTTP")
+        # Might not see upload attempts


Variable upload_logs is not used.

Suggested change

# Might not see upload attempts

# Ensure no upload-related entries are present in the logs

assert len(upload_logs) == 0, "No upload logs should be present when there are no files"

# Process should still handle the no-files case gracefully

Copilot · 2026-01-21T19:08:38Z

+        assert len(archive_logs) > 0, "Archive process should complete. Found {len(archive_logs)} archive-related logs: {archive_logs}"
+
+        upload_logs = grep_uploadstb_logs_regex(r"upload.*success|uploading|HTTP")
+        # Telemetry should be attempted
+        assert len(archive_logs) > 0, "Upload Process should complete and succeed"


Variable upload_logs is not used.

Suggested change

assert len(archive_logs) > 0, "Archive process should complete. Found {len(archive_logs)} archive-related logs: {archive_logs}"

upload_logs = grep_uploadstb_logs_regex(r"upload.*success|uploading|HTTP")

# Telemetry should be attempted

assert len(archive_logs) > 0, "Upload Process should complete and succeed"

assert len(archive_logs) > 0, (

f"Archive process should complete. Found {len(archive_logs)} archive-related logs: {archive_logs}"

)

upload_logs = grep_uploadstb_logs_regex(r"upload.*success|uploading|HTTP")

# Telemetry should be attempted

assert len(upload_logs) > 0, (

f"Upload process should complete and succeed. "

f"Found {len(upload_logs)} upload-related logs: {upload_logs}"

)

Copilot · 2026-01-21T19:08:39Z

+        # Verify files were processed
+
+        # Check for compression/archive activity
+        compression_logs = grep_uploadstb_logs_regex(r"compress|archive|tgz")


Variable compression_logs is not used.

Suggested change

compression_logs = grep_uploadstb_logs_regex(r"compress|archive|tgz")

Copilot · 2026-01-21T19:08:43Z

+        # Check for configuration loading
+        config_logs = grep_uploadstb_logs_regex(r"load.*TR-181|load.*param|endpoint|RFC")
+        # Should attempt to load config
+        assert result.returncode in [0, 1], "Should load RBUS configuration"


Variable config_logs is not used.

Suggested change

assert result.returncode in [0, 1], "Should load RBUS configuration"

assert result.returncode in [0, 1], "Should load RBUS configuration"

assert config_logs, "RBUS configuration logs should be present"

Copilot · 2026-01-21T19:08:44Z

+    try:
+        subprocess.run(f"echo '' > {UPLOADSTB_LOG}", shell=True)
+        return True
+    except:


Except block directly handles BaseException.

Copilot · 2026-01-21T19:08:44Z

+        if os.path.exists(LOCK_FILE):
+            os.remove(LOCK_FILE)
+        return True
+    except:


Except block directly handles BaseException.

Copilot · 2026-01-21T19:08:44Z

+            for chunk in iter(lambda: f.read(4096), b""):
+                md5_hash.update(chunk)
+        return md5_hash.hexdigest()
+    except:


Except block directly handles BaseException.

Copilot · 2026-01-21T19:08:44Z

+    """Get file size in bytes"""
+    try:
+        return os.path.getsize(filepath)
+    except:


Except block directly handles BaseException.

…ts To C Implementation (#60)

Copilot

Pull request overview

Copilot reviewed 62 out of 63 changed files in this pull request and generated 31 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-03T09:03:02Z

+        result = run_uploadstblogs()
+
+        # Check for size limit detection
+        size_logs = grep_uploadstb_logs_regex(r"size.*limit|too large|exceed")


Variable size_logs is not used.

Suggested change

size_logs = grep_uploadstb_logs_regex(r"size.*limit|too large|exceed")

size_logs = grep_uploadstb_logs_regex(r"size.*limit|too large|exceed")

assert size_logs, "Expected size-related log entries for oversized file"

Copilot · 2026-02-03T09:03:02Z

+        result = run_uploadstblogs()
+
+        # Check for no files detection
+        no_files_logs = grep_uploadstb_logs_regex(r"no.*file|empty|not found|no logs")


Variable no_files_logs is not used.

Copilot · 2026-02-03T09:03:03Z

+        telemetry_logs = grep_uploadstb_logs_regex(r"telemetry|marker|event")
+        # Process should complete
+        assert result.returncode in [0, 1], "Should handle empty logs with telemetry"
+


Variable telemetry_logs is not used.

Suggested change

# Telemetry entries should be present

assert len(telemetry_logs) > 0, "Expected telemetry markers for empty logs"

Copilot · 2026-02-03T09:03:03Z

+
+        create_test_log_files(count=2)
+
+        result = run_uploadstblogs()


Variable result is not used.

Suggested change

result = run_uploadstblogs()

run_uploadstblogs()

Copilot · 2026-02-03T09:03:03Z

+
+        create_test_log_files(count=1)
+
+        result = run_uploadstblogs()


Variable result is not used.

Copilot · 2026-02-03T09:03:09Z

+"""
+
+import pytest
+import time


Import of 'time' is not used.

Suggested change

import time

Copilot · 2026-02-03T09:03:09Z

+"""
+
+import pytest
+import time


Import of 'time' is not used.

Suggested change

import time

Copilot · 2026-02-03T09:03:10Z

+import os
+import time
+import re
+import json


Import of 'json' is not used.

Suggested change

import json

Copilot · 2026-02-03T09:03:10Z

+            for chunk in iter(lambda: f.read(4096), b""):
+                md5_hash.update(chunk)
+        return md5_hash.hexdigest()
+    except:


Except block directly handles BaseException.

Suggested change

except:

except Exception:

Copilot · 2026-02-03T09:03:10Z

+    """Get file size in bytes"""
+    try:
+        return os.path.getsize(filepath)
+    except:


Except block directly handles BaseException.

Suggested change

except:

except OSError:

DCM Agent 2.0.1 release

* Create uploadlogsnow.h --------- Co-authored-by: nhanasi <navihansi@gmail.com>

DCM Agent Release 2.2.0

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

* Update L2-tests.yml * L2 automatics upload Error --------- Co-authored-by: Abhinav P V <Abhinav_Valappil@comcast.com>

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

…161) * Update dcm_parseconf.c * Update log message for backup_logs sentinel detection * Update backup_engine.c * Remove old copyright and documentation comments

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

* Update archive_manager.h * Update archive_manager.c * Update strategies.c * Update archive_manager.c * Update archive_manager.c * Update strategies.c * Update strategies.c * Update strategies.c * Update strategies.c * Update strategies.c * Update strategies.c * Update strategies.c * Update strategies.c * Update strategies.c * Fix formatting of comment in strategies.c * Update archive_manager_gtest.cpp * Update strategies_gtest.cpp

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

DCM Agent 2.2.1 release

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

…from RDK analytics portal (#169) * Update strategies.c * Update strategies.c * Remove unnecessary blank line in strategies.c

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

…ed to logupload server is not available (#168) * Update archive_manager.c * Update backup_engine.c * Update backup_engine_gtest.cpp * Update backup_engine_gtest.cpp * Update Makefile.am * Update Makefile.am * Update Makefile.am * Update backup_engine_gtest.cpp * Update backup_logs_gtest.cpp * Update Makefile.am * Update backup_engine_gtest.cpp * Update backup_logs_gtest.cpp * Update backup_logs_gtest.cpp * Update backup_engine_gtest.cpp * Update backup_logs_gtest.cpp * Update Makefile.am * Update backup_engine_gtest.cpp * Update Makefile.am * Update Makefile.am * Update Makefile.am * Update Makefile.am * Update backup_engine_gtest.cpp * Update backup_engine.c * Clean up mock functions and tests for backup logs Removed unused mock open functions and related tests for backup_and_recover_logs. * Remove -U_FORTIFY_SOURCE from backup_engine_gtest_CFLAGS

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

DCM Agent 2.2.2 release

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

shibu-kv and others added 3 commits February 10, 2025 06:57

Merge branch 'release/1.1.0'

b12ff0c

Merge branch 'release/1.2.0'

0397413

Copilot AI review requested due to automatic review settings January 7, 2026 12:59

Abhinavpv28 requested a review from a team as a code owner January 7, 2026 12:59

Copilot started reviewing on behalf of Abhinavpv28 January 7, 2026 12:59 View session

Copilot AI reviewed Jan 7, 2026

View reviewed changes

Abhinavpv28 and others added 2 commits January 12, 2026 13:40

RDK-57502 - [RDKE] Migrate Operation Support Log Upload Related Scrip…

ffd0993

…ts To C Implementation (#49) * Simplify some pieces of code over engineered by AI models. * Update run_uploadstblogs_l2.sh for L2 coverage --------- Co-authored-by: Abhinav P V <Abhinav_Valappil@comcast.com>

Copilot AI review requested due to automatic review settings January 13, 2026 18:09

Copilot started reviewing on behalf of shibu-kv January 13, 2026 18:09 View session

Copilot AI reviewed Jan 13, 2026

Abhinavpv28 added 2 commits January 14, 2026 08:57

Enable breakpad support for analyzing any crashes

d68ca8c

Copilot AI review requested due to automatic review settings January 21, 2026 18:58

Copilot started reviewing on behalf of shibu-kv January 21, 2026 18:59 View session

Changelog updates for 2.0.0 release

6e7c40d

Copilot AI reviewed Jan 21, 2026

View reviewed changes

shibu-kv and others added 3 commits January 21, 2026 11:18

Merge branch 'release/2.0.0'

99acb75

Merge branch 'release/2.0.0' into develop

8696fdc

RDK-57502 - [RDKE] Migrate Operation Support Log Upload Related Scrip…

52ad7e1

…ts To C Implementation (#60)

Copilot AI review requested due to automatic review settings February 3, 2026 08:55

Copilot started reviewing on behalf of tdeva14 February 3, 2026 08:55 View session

Copilot AI reviewed Feb 3, 2026

View reviewed changes

naveenkumarhanasi and others added 4 commits February 3, 2026 19:04

DCM Agent 2.0.1 release changelog updates

c4a4a53

Merge branch 'release/2.0.1'

6af7b08

Merge tag '2.0.1' into develop

835a632

DCM Agent 2.0.1 release

RDK-59919 : [RDKE] Port Ops Support Upload Scripts to Source code (#59)

9a67596

* Create uploadlogsnow.h --------- Co-authored-by: nhanasi <navihansi@gmail.com>

Copilot AI review requested due to automatic review settings February 10, 2026 20:53

Copilot started reviewing on behalf of shibu-kv February 10, 2026 20:54 View session

naveenkumarhanasi added 3 commits July 22, 2026 14:50

DCM Agent 2.2.0 release changelog updates

b6e72e4

Merge branch 'release/2.2.0'

890ec94

Merge tag '2.2.0' into develop

fb9c6c6

DCM Agent Release 2.2.0

Copilot AI review requested due to automatic review settings July 22, 2026 15:14

Copilot AI reviewed Jul 22, 2026

RDKEMW-21374 : Fix L2 Upload Results to Automatics Error (#159)

75435b7

* Update L2-tests.yml * L2 automatics upload Error --------- Co-authored-by: Abhinav P V <Abhinav_Valappil@comcast.com>

Copilot AI review requested due to automatic review settings July 28, 2026 14:50

Copilot AI reviewed Jul 28, 2026

RDKEMW-22204 : Logupload is not triggering after maintenance reboot (#…

e6bd184

…161) * Update dcm_parseconf.c * Update log message for backup_logs sentinel detection * Update backup_engine.c * Remove old copyright and documentation comments

Copilot AI review requested due to automatic review settings July 29, 2026 20:42

Copilot AI reviewed Jul 29, 2026

Copilot AI review requested due to automatic review settings July 30, 2026 13:07

Copilot AI reviewed Jul 30, 2026

naveenkumarhanasi added 3 commits July 30, 2026 16:17

DCM Agent 2.2.1 release changelog updates

cf9c7f5

Merge branch 'release/2.2.1'

68f13e1

Merge tag '2.2.1' into develop

671514a

DCM Agent 2.2.1 release

Copilot AI review requested due to automatic review settings July 30, 2026 16:47

Copilot AI reviewed Jul 30, 2026

RDKEMW-22920 : [Develop] Log files looks to be empty when downloaded …

10140e5

…from RDK analytics portal (#169) * Update strategies.c * Update strategies.c * Remove unnecessary blank line in strategies.c

Copilot AI review requested due to automatic review settings August 3, 2026 18:26

Copilot AI reviewed Aug 3, 2026

Copilot AI review requested due to automatic review settings August 7, 2026 18:14

Copilot AI reviewed Aug 7, 2026

naveenkumarhanasi added 3 commits August 7, 2026 18:17

DCM Agent 2.2.2 release changelog updates

bd0c335

Merge branch 'release/2.2.2'

4dd555a

Merge tag '2.2.2' into develop

c07ce8e

DCM Agent 2.2.2 release

Copilot AI review requested due to automatic review settings August 7, 2026 18:17

Copilot AI reviewed Aug 7, 2026

		@@ -0,0 +1,86 @@
		####################################################################################
		# If not stated otherwise in this file or this component's Licenses

		@@ -0,0 +1,48 @@
		####################################################################################
		# If not stated otherwise in this file or this component's Licenses

	telemetry_logs = grep_uploadstb_logs_regex(r"telemetry\|marker\|warning")
	telemetry_logs = grep_uploadstb_logs_regex(r"telemetry\|marker\|warning")
	assert telemetry_logs, "Expected telemetry markers in uploadSTB logs"

	# Might not see upload attempts
	# Verify that no upload-related log entries are present
	assert len(upload_logs) == 0, "Should not attempt upload when no log files are available"

	assert result.returncode in [0, 1], "Should detect corrupted config"
	assert result.returncode in [0, 1], "Should detect corrupted config"
	assert len(error_logs) > 0 or result.returncode != 0, "Configuration errors should be logged"

	logs = grep_uploadstb_logs_regex(r"size\|large\|limit\|truncate")
	grep_uploadstb_logs_regex(r"size\|large\|limit\|truncate")

-        # Might not see upload attempts
+        # Ensure no upload-related entries are present in the logs
+        assert len(upload_logs) == 0, "No upload logs should be present when there are no files"
+        # Process should still handle the no-files case gracefully

	assert result.returncode in [0, 1], "Should load RBUS configuration"
	assert result.returncode in [0, 1], "Should load RBUS configuration"
	assert config_logs, "RBUS configuration logs should be present"

	size_logs = grep_uploadstb_logs_regex(r"size.*limit\|too large\|exceed")
	size_logs = grep_uploadstb_logs_regex(r"size.*limit\|too large\|exceed")
	assert size_logs, "Expected size-related log entries for oversized file"


	# Telemetry entries should be present
	assert len(telemetry_logs) > 0, "Expected telemetry markers for empty logs"

Uh oh!

Conversation

Abhinavpv28 commented Jan 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!