Skip to content

RDKEMW-22932 : Remove ctrlm IARM calls/events removed from control te… - #270

Open
dwolaver wants to merge 3 commits into
developfrom
feature/RDKEMW-22932_remove_iarm_calls_events
Open

RDKEMW-22932 : Remove ctrlm IARM calls/events removed from control te…#270
dwolaver wants to merge 3 commits into
developfrom
feature/RDKEMW-22932_remove_iarm_calls_events

Conversation

@dwolaver

Copy link
Copy Markdown
Contributor

…st app

@dwolaver
dwolaver marked this pull request as ready for review August 13, 2026 20:09
@dwolaver
dwolaver requested a review from a team as a code owner August 13, 2026 20:09
Copilot AI lite review requested due to automatic review settings August 13, 2026 20:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes several legacy IARM calls/events and associated queue plumbing (notably controller unbind, control-service set/get values, and RIB get/set), aligning Control Manager’s IPC surface with what’s now supported by the control test app and simplifying RF4CE network interfaces accordingly.

Changes:

  • Removed Main IARM APIs for property set, controller unbind, and control-service set/get values, along with their queue message types and handlers.
  • Removed RCU IARM APIs and internal request processing for RIB get/set.
  • Simplified cs_values_set by dropping the db_load parameter and updating the call site used for DB-loaded control-service values.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/rf4ce/ctrlm_rf4ce_network.h Updates RF4CE network interface to remove RIB request handlers and simplify cs_values_set signature.
src/rf4ce/ctrlm_rf4ce_network.cpp Removes RF4CE RIB get/set processing implementations; updates cs_values_set implementation to new signature.
src/ctrlm.h Removes main-queue message types and structs tied to deprecated IARM calls.
src/ctrlm_utils.cpp Removes string mappings for deleted main-queue message types.
src/ctrlm_rcu.h Removes RIB request result “pending” and RIB queue message struct; removes RIB get/set API declarations.
src/ctrlm_rcu.cpp Removes RCU-side RIB request get/set implementations.
src/ctrlm_rcu_iarm.cpp Unregisters and deletes IARM call handlers for RIB request get/set.
src/ctrlm_network.h Removes base virtual RIB request processing and updates cs_values_set signature.
src/ctrlm_network.cpp Removes base implementations of RIB request processing; updates cs_values_set signature.
src/ctrlm_main.cpp Removes main-thread handling for deprecated messages and updates DB-driven cs_values_set call.
src/ctrlm_main_iarm.cpp Unregisters and deletes Main IARM handlers for deprecated calls (property set, controller unbind, control-service set/get).
include/ctrlm_ipc.h Removes public Main IPC call names and structs for deprecated features.
include/ctrlm_ipc_rcu.h Removes public RCU IPC call names and structs for RIB requests.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread include/ctrlm_ipc_rcu.h
Comment thread src/ctrlm_main.cpp
Comment thread include/ctrlm_ipc.h

@jthomp007c jthomp007c left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants