RDKEMW-22932 : Remove ctrlm IARM calls/events removed from control te… - #270
Open
dwolaver wants to merge 3 commits into
Open
RDKEMW-22932 : Remove ctrlm IARM calls/events removed from control te…#270dwolaver wants to merge 3 commits into
dwolaver wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes several legacy IARM calls/events and associated queue plumbing (notably controller unbind, control-service set/get values, and RIB get/set), aligning Control Manager’s IPC surface with what’s now supported by the control test app and simplifying RF4CE network interfaces accordingly.
Changes:
- Removed Main IARM APIs for property set, controller unbind, and control-service set/get values, along with their queue message types and handlers.
- Removed RCU IARM APIs and internal request processing for RIB get/set.
- Simplified
cs_values_setby dropping thedb_loadparameter and updating the call site used for DB-loaded control-service values.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/rf4ce/ctrlm_rf4ce_network.h | Updates RF4CE network interface to remove RIB request handlers and simplify cs_values_set signature. |
| src/rf4ce/ctrlm_rf4ce_network.cpp | Removes RF4CE RIB get/set processing implementations; updates cs_values_set implementation to new signature. |
| src/ctrlm.h | Removes main-queue message types and structs tied to deprecated IARM calls. |
| src/ctrlm_utils.cpp | Removes string mappings for deleted main-queue message types. |
| src/ctrlm_rcu.h | Removes RIB request result “pending” and RIB queue message struct; removes RIB get/set API declarations. |
| src/ctrlm_rcu.cpp | Removes RCU-side RIB request get/set implementations. |
| src/ctrlm_rcu_iarm.cpp | Unregisters and deletes IARM call handlers for RIB request get/set. |
| src/ctrlm_network.h | Removes base virtual RIB request processing and updates cs_values_set signature. |
| src/ctrlm_network.cpp | Removes base implementations of RIB request processing; updates cs_values_set signature. |
| src/ctrlm_main.cpp | Removes main-thread handling for deprecated messages and updates DB-driven cs_values_set call. |
| src/ctrlm_main_iarm.cpp | Unregisters and deletes Main IARM handlers for deprecated calls (property set, controller unbind, control-service set/get). |
| include/ctrlm_ipc.h | Removes public Main IPC call names and structs for deprecated features. |
| include/ctrlm_ipc_rcu.h | Removes public RCU IPC call names and structs for RIB requests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…st app