RDKEMW-21599 : Control manager crashed on executing tr181 command - #262
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a crash path when processing RFC/TR-181-driven voice configuration updates in the Control Manager voice subsystem by improving RFC handling and VSDK JSON lifetime management.
Changes:
- Limit voice enable/disable overrides to the
force_voice_settingspath (scopingenabledaccordingly). - Improve logging and adjust VSDK RFC JSON ownership so the config object isn’t prematurely released.
- Fix a potential leak in RFC attribute base64/JSON parsing by ensuring the decoded buffer is freed even on early returns.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/voice/ctrlm_voice_obj.cpp | Adjusts RFC handlers and VSDK config ownership to avoid freeing JSON while it may still be used. |
| src/rfc/ctrlm_rfc_attr.cpp | Ensures decoded base64 buffers are freed promptly during RFC JSON parsing. |
egalla204
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.