RDKEMW-17614 : mask_pii RFC not applied correctly - #218
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes application of the mask_pii RFC value so that changes propagate beyond voice to other components that log keycodes, ensuring consistent PII masking behavior across the control manager.
Changes:
- Apply RFC-updated
mask_piivalue to the voice session (guarded by null check). - Apply RFC-updated
mask_piivalue to the IR controller keycode masking. - Apply RFC-updated
mask_piivalue to all instantiated networks’ keycode masking.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
klu339
approved these changes
Apr 27, 2026
egalla204
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.