Skip to content

Revert "RDKEMW-16763 : rf4ce init failure causes deadlock (#198)" - #211

Merged
egalla204 merged 1 commit into
developfrom
feature/RDKEMW-16763
Apr 22, 2026
Merged

Revert "RDKEMW-16763 : rf4ce init failure causes deadlock (#198)"#211
egalla204 merged 1 commit into
developfrom
feature/RDKEMW-16763

Conversation

@klu339

@klu339 klu339 commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

After a factory reset rf4ce HAL init can take up to 7 seconds. So this needs to be reverted and a better solution will be developed.

This reverts commit d1afc07.

Copilot AI review requested due to automatic review settings April 22, 2026 19:12
@klu339
klu339 requested a review from a team as a code owner April 22, 2026 19:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts commit d1afc074... that previously added bounded waiting/error handling around RF4CE HAL initialization, returning the code to an unbounded blocking wait.

Changes:

  • Removed errno.h include (no longer needed after reverting timed-wait logic).
  • Replaced sem_timedwait + timeout/EINTR/error handling with a plain sem_wait during RF4CE HAL initialization.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/rf4ce/ctrlm_rf4ce_network.cpp
@egalla204
egalla204 merged commit 48775fc into develop Apr 22, 2026
12 checks passed
@egalla204
egalla204 deleted the feature/RDKEMW-16763 branch April 22, 2026 19:19
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants