RDKEMW-17330,RDKEMW-17315: ctrlm hotfix release 1.1.7.1 (support/8.4.4.0) - #204
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the 1.1.7.1 hotfix release notes and introduces runtime fixes related to RF4CE initialization waiting and BLE voice streaming end conditions.
Changes:
- Add a timed wait (with EINTR handling) to avoid RF4CE init deadlock when init confirm is never received.
- Adjust BLE audio streaming behavior so “Press and Release” sessions end based on audio duration rather than key-up.
- Add a 1.1.7.1 entry to
CHANGELOG.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/rf4ce/ctrlm_rf4ce_network.cpp |
Switch init wait from sem_wait to sem_timedwait with timeout/error logging. |
src/ble/ctrlm_ble_network.cpp |
Invert press-and-hold support condition to select correct stream end mode. |
CHANGELOG.md |
Add release notes section for version 1.1.7.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+430
to
+439
| if(sem_result == -1) { | ||
| if(errno == ETIMEDOUT) { | ||
| XLOGD_ERROR("Timeout waiting for %s initialization", name_get()); | ||
| } else { | ||
| XLOGD_ERROR("Error waiting for %s initialization: %s", name_get(), strerror(errno)); | ||
| } | ||
| init_result_ = CTRLM_HAL_RESULT_ERROR; | ||
| } else { | ||
| sem_destroy(&semaphore_); | ||
| } |
klu339
changed the title
klu339
changed the title
egalla204
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.