XIONE-18570:[RDKV 8.4]Xumo TV devices got stuck with old firmware with http error code 405 - #94
Merged
Merged
Conversation
…h http error code 405
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the firmware-download cleanup logic to avoid deleting required “param”/PDRI artifacts (and their header sidecars), which can leave devices stuck on older firmware.
Changes:
- Renames and extends the folder-cleanup helper to preserve both a primary file and a PDRI file plus their
.headerfiles. - Switches exclusion logic to case-insensitive exact filename matching.
- Adds
<strings.h>forstrcasecmp()usage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| utils/system_utils.h | Updates the public API prototype (rename + additional parameter). |
| utils/system_utils.c | Implements new exclusion rules using strcasecmp() and preserves additional header files. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.