RDKB-66347: Add conditional support for rdk logger init for RDKB - #102
Open
gomathishankar37 wants to merge 2 commits into
Open
RDKB-66347: Add conditional support for rdk logger init for RDKB#102gomathishankar37 wants to merge 2 commits into
gomathishankar37 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a compile-time switch to choose between the newer rdk_logger_ext_init() path and a legacy rdk_logger_init("/etc/debug.ini") path when RDK_LOGGER is enabled, supporting RDKB environments that still require the legacy init.
Changes:
- Add
USE_LEGACY_LOGGER_INITconditional to select logger initialization method underRDK_LOGGER. - Introduce legacy init branch calling
rdk_logger_init(DEBUG_INI_NAME).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
utils/rdkv_cdl_log_wrapper.c:30
printf("RDKLOG init completed")currently runs before the logger is initialized, and it prints even whenRDK_LOGGERis not enabled (so no init happens). This makes the message misleading.
Move the message into the #if defined(RDK_LOGGER) block after whichever init path runs (or adjust wording to reflect that init may be skipped).
int log_init( ) {
printf("RDKLOG init completed\n");
#if defined(RDK_LOGGER)
#if !defined(USE_LEGACY_LOGGER_INIT)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.