Skip to content

RDKB-66347: Add conditional support for rdk logger init for RDKB - #102

Open
gomathishankar37 wants to merge 2 commits into
developfrom
topic/RDKB-66347
Open

RDKB-66347: Add conditional support for rdk logger init for RDKB#102
gomathishankar37 wants to merge 2 commits into
developfrom
topic/RDKB-66347

Conversation

@gomathishankar37

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings August 6, 2026 04:50
@gomathishankar37
gomathishankar37 requested a review from a team as a code owner August 6, 2026 04:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a compile-time switch to choose between the newer rdk_logger_ext_init() path and a legacy rdk_logger_init("/etc/debug.ini") path when RDK_LOGGER is enabled, supporting RDKB environments that still require the legacy init.

Changes:

  • Add USE_LEGACY_LOGGER_INIT conditional to select logger initialization method under RDK_LOGGER.
  • Introduce legacy init branch calling rdk_logger_init(DEBUG_INI_NAME).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread utils/rdkv_cdl_log_wrapper.c Outdated
Copilot AI review requested due to automatic review settings August 6, 2026 06:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

utils/rdkv_cdl_log_wrapper.c:30

  • printf("RDKLOG init completed") currently runs before the logger is initialized, and it prints even when RDK_LOGGER is not enabled (so no init happens). This makes the message misleading.

Move the message into the #if defined(RDK_LOGGER) block after whichever init path runs (or adjust wording to reflect that init may be skipped).

int log_init( ) {
    printf("RDKLOG init completed\n");
#if defined(RDK_LOGGER)
#if !defined(USE_LEGACY_LOGGER_INIT)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants